From 8667dd7121f3ff1ed10371602079a781a706943a Mon Sep 17 00:00:00 2001 From: Classic298 <27028174+Classic298@users.noreply.github.com> Date: Mon, 28 Sep 2026 04:16:07 +0200 Subject: [PATCH] fix: actions in a model's menu in the model selector do nothing (#31503) Picking Edit, Keep in Sidebar, Copy Link or Delete from the menu next to a model in the model selector did nothing: the selector closed and the action never ran. These actions work again. Edit and Delete now also close the selector, so the first click in the settings window or the delete confirmation that opens is not lost. --- src/lib/components/chat/ModelSelector/ModelItem.svelte | 2 ++ src/lib/components/chat/ModelSelector/ModelItemMenu.svelte | 3 +++ src/lib/components/chat/ModelSelector/Selector.svelte | 4 ++++ 3 files changed, 9 insertions(+) diff --git a/src/lib/components/chat/ModelSelector/ModelItem.svelte b/src/lib/components/chat/ModelSelector/ModelItem.svelte index b15041b08c..dad2ab33e5 100644 --- a/src/lib/components/chat/ModelSelector/ModelItem.svelte +++ b/src/lib/components/chat/ModelSelector/ModelItem.svelte @@ -33,6 +33,7 @@ export let selectionOnly = false; export let onClick: () => void = () => {}; + export let onEdit: () => void = () => {}; $: localizedDescription = resolveLocalizedModelDescription(item.model, $i18n.language); @@ -304,6 +305,7 @@ model={item.model} {pinModelHandler} {deleteModelHandler} + {onEdit} copyLinkHandler={() => { copyLinkHandler(item.model); }} diff --git a/src/lib/components/chat/ModelSelector/ModelItemMenu.svelte b/src/lib/components/chat/ModelSelector/ModelItemMenu.svelte index 57fd390f6a..acf546d5f6 100644 --- a/src/lib/components/chat/ModelSelector/ModelItemMenu.svelte +++ b/src/lib/components/chat/ModelSelector/ModelItemMenu.svelte @@ -20,6 +20,7 @@ export let pinModelHandler: (modelId: string) => void = () => {}; export let copyLinkHandler: Function = () => {}; export let deleteModelHandler: Function = () => {}; + export let onEdit: () => void = () => {}; export let onClose: Function = () => {}; @@ -30,6 +31,7 @@ bind:show align="end" sideOffset={-2} + contentClass="model-selector-child-menu" onOpenChange={(state) => { if (state === false) { onClose(); @@ -61,6 +63,7 @@ showSettings.set({ tab: 'admin:models', state: { id: model?.id ?? null } }); } show = false; + onEdit(); }} > diff --git a/src/lib/components/chat/ModelSelector/Selector.svelte b/src/lib/components/chat/ModelSelector/Selector.svelte index c235cff80c..81b4f28b2a 100644 --- a/src/lib/components/chat/ModelSelector/Selector.svelte +++ b/src/lib/components/chat/ModelSelector/Selector.svelte @@ -810,6 +810,7 @@ let deleteModelTarget: any = null; const deleteModelHandler = async (model: any) => { + show = false; deleteModelTarget = model; showDeleteConfirm = true; }; @@ -1108,6 +1109,9 @@ onClick={() => { selectItem(item, index); }} + onEdit={() => { + show = false; + }} /> {/each}