From 5cc0ed71d61023919a98a96b26ed0e6ad3878d37 Mon Sep 17 00:00:00 2001
From: G30 <50341825+silentoplayz@users.noreply.github.com>
Date: Sun, 25 Oct 2026 01:14:04 -0400
Subject: [PATCH] fix(a11y): opening the Terminal menu focuses its first
 terminal, not the Add Terminal button, and the arrow keys move through the
 terminals (#33153)

---
 src/lib/components/chat/MessageInput/TerminalMenu.svelte | 4 ++++
 src/lib/components/common/Dropdown.svelte                | 9 ++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/lib/components/chat/MessageInput/TerminalMenu.svelte b/src/lib/components/chat/MessageInput/TerminalMenu.svelte
index a53779e75d..83679adc7a 100644
--- a/src/lib/components/chat/MessageInput/TerminalMenu.svelte
+++ b/src/lib/components/chat/MessageInput/TerminalMenu.svelte
@@ -208,6 +208,8 @@
 						{#each directTerminals as terminal}
 							<button
 								type="button"
+								role="menuitemradio"
+								aria-checked={$selectedTerminalId === terminal.url}
 								class="flex w-full justify-between gap-2 items-center h-[1.6875rem] px-2 text-[0.8125rem] font-normal cursor-pointer rounded-xl {$selectedTerminalId ===
 								terminal.url
 									? 'bg-gray-50/40 dark:bg-gray-800/40'
@@ -277,6 +279,8 @@
 						{#each systemTerminals as terminal}
 							<button
 								type="button"
+								role="menuitemradio"
+								aria-checked={$selectedTerminalId === terminal.id}
 								class="flex w-full justify-between gap-2 items-center h-[1.6875rem] px-2 text-[0.8125rem] font-normal cursor-pointer rounded-xl {$selectedTerminalId ===
 								terminal.id
 									? 'bg-gray-50/40 dark:bg-gray-800/40'
diff --git a/src/lib/components/common/Dropdown.svelte b/src/lib/components/common/Dropdown.svelte
index aca4a0c857..925a845ecc 100644
--- a/src/lib/components/common/Dropdown.svelte
+++ b/src/lib/components/common/Dropdown.svelte
@@ -258,8 +258,15 @@
 
 		if (shouldFocusContent) {
 			shouldFocusContent = false;
+			const firstControl = contentEl?.querySelector<HTMLElement>(
+				'button:not([disabled]), a[href], input'
+			);
 			(
-				contentEl?.querySelector<HTMLElement>('button:not([disabled]), a[href], input') ?? contentEl
+				(firstControl?.matches('input')
+					? firstControl
+					: contentEl?.querySelector<HTMLElement>('[role^="menuitem"]:not([disabled])')) ??
+				firstControl ??
+				contentEl
 			)?.focus();
 		}
 	}