From 3a46f629f1d4c02192c5be7a8dfb22d0ee5f1c03 Mon Sep 17 00:00:00 2001
From: G30 <50341825+silentoplayz@users.noreply.github.com>
Date: Sat, 24 Oct 2026 15:42:00 -0400
Subject: [PATCH] fix(a11y): a folder's options button is named and not nested
 inside another button (#33093)

---
 src/lib/components/chat/Placeholder/FolderTitle.svelte    | 8 ++------
 .../components/layout/Sidebar/Folders/FolderMenu.svelte   | 1 +
 src/lib/components/layout/Sidebar/RecursiveFolder.svelte  | 5 +++--
 3 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/lib/components/chat/Placeholder/FolderTitle.svelte b/src/lib/components/chat/Placeholder/FolderTitle.svelte
index 2c9483bd2e..bfa72248bb 100644
--- a/src/lib/components/chat/Placeholder/FolderTitle.svelte
+++ b/src/lib/components/chat/Placeholder/FolderTitle.svelte
@@ -261,13 +261,9 @@
 						showCreateSubFolderModal = true;
 					}}
 				>
-					<button
-						class="p-1.5 dark:hover:bg-gray-850 rounded-full touch-auto"
-						aria-label={$i18n.t('Folder options')}
-						on:click={(e) => {}}
-					>
+					<div class="inline-flex p-1.5 dark:hover:bg-gray-850 rounded-full touch-auto">
 						<EllipsisHorizontal className="size-4" strokeWidth="2.5" />
-					</button>
+					</div>
 				</FolderMenu>
 			</div>
 		{/if}
diff --git a/src/lib/components/layout/Sidebar/Folders/FolderMenu.svelte b/src/lib/components/layout/Sidebar/Folders/FolderMenu.svelte
index f465a26572..ef86dd18a6 100644
--- a/src/lib/components/layout/Sidebar/Folders/FolderMenu.svelte
+++ b/src/lib/components/layout/Sidebar/Folders/FolderMenu.svelte
@@ -38,6 +38,7 @@
 >
 	<Tooltip content={$i18n.t('More')}>
 		<button
+			aria-label={$i18n.t('Folder options')}
 			on:click={(e) => {
 				e.stopPropagation();
 				show = !show;
diff --git a/src/lib/components/layout/Sidebar/RecursiveFolder.svelte b/src/lib/components/layout/Sidebar/RecursiveFolder.svelte
index a3f99753e7..b589bc960c 100644
--- a/src/lib/components/layout/Sidebar/RecursiveFolder.svelte
+++ b/src/lib/components/layout/Sidebar/RecursiveFolder.svelte
@@ -914,8 +914,9 @@
 				</div>
 
 				{#if isWritable}
-					<button
+					<div
 						class="absolute z-10 right-2 hover-reveal self-center flex items-center dark:text-gray-300"
+						role="presentation"
 						on:pointerdown={() => (openPreview = false)}
 					>
 						<FolderMenu
@@ -941,7 +942,7 @@
 								<MoreHorizontal className="size-3.5" strokeWidth="2" />
 							</div>
 						</FolderMenu>
-					</button>
+					</div>
 				{/if}
 			</div>
 		</div>