scriptoriumadmin/open-webui
1
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-09-07 08:27:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: prevent null crashes in users and notes routers (#20279)

Browse source 
Add null checks for ui settings in update_user_settings_by_session_user() and for user in get_notes(). Prevents AttributeError when ui dict is None or when note's user has been deleted.
This commit is contained in:
Classic298 2025-12-31 08:30:14 +01:00 • committed by GitHub
parent a2e9263af0
commit 2c0ebbcced
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
backend/open_webui/routers/notes.py
View file

@ -70,19 +70,20 @@ async def get_notes(
limit = 60
skip = (page - 1) * limit
notes = [
NoteUserResponse(
**{
**note.model_dump(),
"user": UserResponse(
**Users.get_user_by_id(note.user_id, db=db).model_dump()
),
}
)
for note in Notes.get_notes_by_user_id(
user.id, "read", skip=skip, limit=limit, db=db
)
]
notes = []
for note in Notes.get_notes_by_user_id(
user.id, "read", skip=skip, limit=limit, db=db
):
note_user = Users.get_user_by_id(note.user_id, db=db)
if note_user:
notes.append(
NoteUserResponse(
**{
**note.model_dump(),
"user": UserResponse(**note_user.model_dump()),
}
)
)
return notes

4
backend/open_webui/routers/users.py
View file

@ -292,9 +292,11 @@ async def update_user_settings_by_session_user(
db: Session = Depends(get_session),
):
updated_user_settings = form_data.model_dump()
ui_settings = updated_user_settings.get("ui")
if (
user.role != "admin"
and "toolServers" in updated_user_settings.get("ui").keys()
and ui_settings is not None
and "toolServers" in ui_settings.keys()
and not has_permission(
user.id,
"features.direct_tool_servers",