mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-17 23:51:30 +00:00
b76def0e5d
`pytest.raises(Exception)` with no `match=` passes on any error that broad. A TypeError from a refactor, a botched fixture, an import that moved: all of them read as the rejection the test claims to police, so the test goes green for the wrong reason and stays green after the behaviour it guards is gone. PT011 closes that gap for the 317 sites B017 could not reach, because B017 only fires on a single-statement body with no `as e` binding. Each pattern here is the message the code actually raised, recorded by running the sites under a plugin that logged the concrete type and text per call site, so the assertions describe observed behaviour rather than a guess. Where a site raises more than one message across its parametrize cases, the pattern is an alternation of what was seen; where the exception carries an empty `str()` and puts the text on `.message`, the site keeps a narrow `noqa` with the reason. PT014 removes four parametrize cases that were listed twice. The duplicate re-runs an assertion that already passed, and it usually marks a case someone meant to vary and forgot to edit.
63 lines
2.7 KiB
Python
63 lines
2.7 KiB
Python
import pytest
|
|
import sys
|
|
import os
|
|
|
|
sys.path.insert(0, os.path.abspath("../.."))
|
|
|
|
from litellm.utils import validate_chat_completion_tool_choice
|
|
|
|
|
|
def test_validate_tool_choice_none():
|
|
"""Test that None is returned as-is."""
|
|
result = validate_chat_completion_tool_choice(None)
|
|
assert result is None
|
|
|
|
|
|
def test_validate_tool_choice_string():
|
|
"""Test that string values are returned as-is."""
|
|
assert validate_chat_completion_tool_choice("auto") == "auto"
|
|
assert validate_chat_completion_tool_choice("none") == "none"
|
|
assert validate_chat_completion_tool_choice("required") == "required"
|
|
|
|
|
|
def test_validate_tool_choice_standard_dict():
|
|
"""Test standard OpenAI format with function."""
|
|
tool_choice = {"type": "function", "function": {"name": "my_function"}}
|
|
result = validate_chat_completion_tool_choice(tool_choice)
|
|
assert result == tool_choice
|
|
|
|
|
|
def test_validate_tool_choice_cursor_format():
|
|
"""Cursor IDE format {"type": "auto"} is unwrapped to the bare string."""
|
|
assert validate_chat_completion_tool_choice({"type": "auto"}) == "auto"
|
|
assert validate_chat_completion_tool_choice({"type": "none"}) == "none"
|
|
assert validate_chat_completion_tool_choice({"type": "required"}) == "required"
|
|
|
|
|
|
def test_validate_tool_choice_invalid_dict():
|
|
"""Test that invalid dict formats raise exceptions."""
|
|
# Missing both type and function
|
|
with pytest.raises(Exception, match='Invalid tool choice, tool_choice=\\{\\}\\. Please ensure') as exc_info:
|
|
validate_chat_completion_tool_choice({})
|
|
assert "Invalid tool choice" in str(exc_info.value)
|
|
|
|
# Invalid type value
|
|
with pytest.raises(Exception, match="Invalid tool choice, tool_choice=\\{'type': 'invalid'\\}\\.") as exc_info:
|
|
validate_chat_completion_tool_choice({"type": "invalid"})
|
|
assert "Invalid tool choice" in str(exc_info.value)
|
|
|
|
# Has type but missing function when type is "function"
|
|
with pytest.raises(Exception, match="Invalid tool choice, tool_choice=\\{'type': 'function'\\}\\.") as exc_info:
|
|
validate_chat_completion_tool_choice({"type": "function"})
|
|
assert "Invalid tool choice" in str(exc_info.value)
|
|
|
|
|
|
def test_validate_tool_choice_invalid_type():
|
|
"""Test that invalid types raise exceptions."""
|
|
with pytest.raises(Exception, match="<class 'int'>\\. Expecting str, or dict\\. Please ensure") as exc_info:
|
|
validate_chat_completion_tool_choice(123)
|
|
assert "Got=<class 'int'>" in str(exc_info.value)
|
|
|
|
with pytest.raises(Exception, match="Invalid tool choice, tool_choice=\\[\\]\\. Got=<class 'list'>\\.") as exc_info:
|
|
validate_chat_completion_tool_choice([])
|
|
assert "Got=<class 'list'>" in str(exc_info.value)
|