mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-23 00:41:40 +00:00
a35ffd420b
Some checks are pending
Unit Tests: Proxy DB Operations / key-generation (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / assert-shard-coverage (push) Waiting to run
Unit Tests: Proxy DB Operations / auth-checks (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / budgets (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / custom-logging (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / db-and-spend (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / endpoints-and-responses (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / guardrails-hooks (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / jwt-and-keys (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / logging-misc (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / proxy-runtime (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / proxy-server-core (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / schema-migration (push) Blocked by required conditions
Unit Tests: Proxy DB Operations / proxy-utils (push) Blocked by required conditions
Unit Tests: Security / security (push) Waiting to run
The second assertion in test_bash_allow_rule_is_pinned_to_exact_echo_pong was dead code: '"Bash"' not in text or '"Bash(echo pong)"' in text short-circuits to True any time the allow rule is present, which is guaranteed by the first assertion. A test file containing both the unrestricted "Bash" pattern AND the restricted "Bash(echo pong)" pattern would have passed this security check undetected, defeating the exact-match permissions pin that protects the PR-gate machine executor from arbitrary host command execution. Strip the allowed pattern out of the file text before scanning, so the residual check is independent of the first assertion. The pure helper _has_bare_bash_token() is exercised directly by three new unit tests covering both the positive (bare "Bash" → flagged) and negative (only "Bash(echo pong)" → accepted; unrelated 'Bashing' substrings → ignored) paths so this regression cannot recur silently. Co-authored-by: Mateo Wang <mateo-berri@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| test_bash_tool_restrictions.py | ||
| test_circleci_pr_gate_wiring.py | ||
| test_pr_gate_version_resolver.py | ||