mirror of
https://github.com/BerriAI/litellm.git
synced 2026-10-11 03:38:38 +00:00
ebfec956d2
`migrationJob.retries` and `migrationJob.disableSchemaUpdate` are declared in values.yaml but referenced by no template, no test and no README row. Setting either changes nothing about the rendered Job. `disableSchemaUpdate` is the misleading one: its comment promises "the job will exit with code 0", but the Job hardcodes DISABLE_SCHEMA_UPDATE=false and renders it after envVars/extraEnvVars precisely so nothing can turn the migration off — that ordering is what #12809 fixed. An operator who reads values.yaml, sets the flag and watches migrations run anyway has no way to tell the knob is inert. `migrationJob.enabled: false` is the supported way to skip the Job, and the componentized chart in helm/litellm already ships a migrationJob block with neither key. `retries` is simply dead: Jobs retry through `backoffLimit`, which the chart does render. Removing values keys is backward compatible — Helm ignores user values that no template consumes, so existing releases setting either key keep working. Adds a test pinning the override: with envVars.DISABLE_SCHEMA_UPDATE="true" the Job's last env entry is still DISABLE_SCHEMA_UPDATE=false, so the last-wins ordering cannot regress and the key cannot quietly come back as a chart value. Verified by mutation: flipping the hardcoded value and moving the entry above the envVars loop each fail the suite. Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: ryan-crabbe-berri <ryan@berri.ai> |
||
|---|---|---|
| .. | ||
| billing_metrics_tests.yaml | ||
| bundled_db_images_tests.yaml | ||
| collector_tests.yaml | ||
| connection_pool_tests.yaml | ||
| coordination_redis_tests.yaml | ||
| deployment_command_args_labels_tests.yaml | ||
| deployment_tests.yaml | ||
| hpa_tests.yaml | ||
| ingress_tests.yaml | ||
| keda_tests.yaml | ||
| masterkey-secret_tests.yaml | ||
| metrics_server_tests.yaml | ||
| migrations-job_tests.yaml | ||
| pdb_tests.yaml | ||
| service_tests.yaml | ||