mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-19 00:01:29 +00:00
4c18f557b1
partition_spend_logs.sql and unpartition_spend_logs.sql hardcode every
index Prisma defines on LiteLLM_SpendLogs, because `LIKE ... INCLUDING
DEFAULTS INCLUDING GENERATED` copies columns but not indexes. They also
rename the old table's indexes aside first, since index names are unique
per schema and a surviving name makes `CREATE INDEX IF NOT EXISTS` a
silent no-op.
The new (api_key, startTime) index was in neither list, so an operator who
partitions (or unpartitions) after this migration lands gets a replacement
table without it, and Prisma will not recreate it: the migration is already
recorded as applied, and `migrate deploy` skips its drift sanity check when
there is nothing pending.
Verified on Postgres 18 against the shipped migration statements:
* unpatched partition script -> parent table has no api_key index, and
re-running the migration's own `CREATE INDEX IF NOT EXISTS` reports
success while being skipped, because the legacy table still owns the
name. The recovery an operator would reach for silently does nothing.
* patched -> index survives partitioning, propagates to every partition
(LiteLLM_SpendLogs_p*_api_key_startTime_idx) and to DEFAULT, is chosen
by the planner for the key+date-range query shape the endpoints use,
and survives the unpartition round-trip with all rows intact.
74 lines
3.3 KiB
PL/PgSQL
74 lines
3.3 KiB
PL/PgSQL
-- Rolls back db_scripts/partition_spend_logs.sql: converts the native
|
|
-- range-partitioned "LiteLLM_SpendLogs" table back into a plain,
|
|
-- non-partitioned table matching the default LiteLLM schema.
|
|
--
|
|
-- When/why: run this if you want to stop using partition-based retention and
|
|
-- return to DELETE-based cleanup, or to restore the original single-column
|
|
-- primary key ("request_id") that the partitioned layout had to widen to a
|
|
-- composite ("request_id", "startTime").
|
|
--
|
|
-- IMPORTANT
|
|
-- * Test on a staging copy first and take a backup.
|
|
-- * Postgres cannot convert a partitioned table back in place, so this
|
|
-- renames the partitioned table aside and creates a fresh plain table.
|
|
-- * The composite PK could in principle hold the same "request_id" in more
|
|
-- than one partition, so rows are copied with ON CONFLICT DO NOTHING to
|
|
-- restore the single-column PK without failing on such duplicates.
|
|
-- * For large tables the INSERT ... SELECT copies every surviving row and may
|
|
-- run long; do it during a low-traffic window.
|
|
-- * Also remove use_spend_logs_partitioning from proxy_config.yaml (or set it
|
|
-- to false) so the cleanup job returns to DELETE-based retention.
|
|
|
|
BEGIN;
|
|
|
|
ALTER TABLE "LiteLLM_SpendLogs" RENAME TO "LiteLLM_SpendLogs_partitioned";
|
|
|
|
-- Renaming a table does NOT rename its indexes, and index names are unique per
|
|
-- schema. Move the partitioned table's indexes aside so the CREATE INDEX
|
|
-- statements below actually create indexes on the new plain table instead of
|
|
-- being silently skipped by IF NOT EXISTS, and so the new PK keeps the
|
|
-- canonical name.
|
|
ALTER INDEX IF EXISTS "LiteLLM_SpendLogs_pkey"
|
|
RENAME TO "LiteLLM_SpendLogs_partitioned_pkey";
|
|
ALTER INDEX IF EXISTS "LiteLLM_SpendLogs_pkey1"
|
|
RENAME TO "LiteLLM_SpendLogs_partitioned_pkey1";
|
|
ALTER INDEX IF EXISTS "LiteLLM_SpendLogs_startTime_idx"
|
|
RENAME TO "LiteLLM_SpendLogs_partitioned_startTime_idx";
|
|
ALTER INDEX IF EXISTS "LiteLLM_SpendLogs_startTime_request_id_idx"
|
|
RENAME TO "LiteLLM_SpendLogs_partitioned_startTime_request_id_idx";
|
|
ALTER INDEX IF EXISTS "LiteLLM_SpendLogs_end_user_idx"
|
|
RENAME TO "LiteLLM_SpendLogs_partitioned_end_user_idx";
|
|
ALTER INDEX IF EXISTS "LiteLLM_SpendLogs_session_id_idx"
|
|
RENAME TO "LiteLLM_SpendLogs_partitioned_session_id_idx";
|
|
ALTER INDEX IF EXISTS "LiteLLM_SpendLogs_api_key_startTime_idx"
|
|
RENAME TO "LiteLLM_SpendLogs_partitioned_api_key_startTime_idx";
|
|
|
|
CREATE TABLE "LiteLLM_SpendLogs" (
|
|
LIKE "LiteLLM_SpendLogs_partitioned" INCLUDING DEFAULTS INCLUDING GENERATED
|
|
);
|
|
|
|
ALTER TABLE "LiteLLM_SpendLogs"
|
|
ADD PRIMARY KEY ("request_id");
|
|
|
|
CREATE INDEX IF NOT EXISTS "LiteLLM_SpendLogs_startTime_idx"
|
|
ON "LiteLLM_SpendLogs" ("startTime");
|
|
|
|
CREATE INDEX IF NOT EXISTS "LiteLLM_SpendLogs_startTime_request_id_idx"
|
|
ON "LiteLLM_SpendLogs" ("startTime", "request_id");
|
|
|
|
CREATE INDEX IF NOT EXISTS "LiteLLM_SpendLogs_end_user_idx"
|
|
ON "LiteLLM_SpendLogs" ("end_user");
|
|
|
|
CREATE INDEX IF NOT EXISTS "LiteLLM_SpendLogs_session_id_idx"
|
|
ON "LiteLLM_SpendLogs" ("session_id");
|
|
|
|
CREATE INDEX IF NOT EXISTS "LiteLLM_SpendLogs_api_key_startTime_idx"
|
|
ON "LiteLLM_SpendLogs" ("api_key", "startTime");
|
|
|
|
INSERT INTO "LiteLLM_SpendLogs"
|
|
SELECT * FROM "LiteLLM_SpendLogs_partitioned"
|
|
ON CONFLICT ("request_id") DO NOTHING;
|
|
|
|
DROP TABLE "LiteLLM_SpendLogs_partitioned";
|
|
|
|
COMMIT;
|