mirror of
https://github.com/BerriAI/litellm.git
synced 2026-10-06 02:48:13 +00:00
25445e8b5c
The spec pinned Base UI's collision behaviour, not our code: it only passes while the template popup happens to fit under the trigger at 1280x900, and #41315's taller Add Auto Router form broke that premise for the second time in three weeks. #41527 tried to scroll the trigger into the upper half, but the dialog content is shorter than its max height, so nothing scrolls and CI still fails 3/3 with the trigger at y=487 The guarantee #38554 introduced is that the popup never covers the trigger, and the sibling spec keeps asserting that at a viewport with no room below
52 lines
1.9 KiB
TypeScript
52 lines
1.9 KiB
TypeScript
import { expect, test, type Locator, type Page as PlaywrightPage } from "@playwright/test";
|
|
import { ADMIN_STORAGE_PATH } from "../../constants";
|
|
import { navigateToPage } from "../../helpers/navigation";
|
|
import { Page } from "../../fixtures/pages";
|
|
|
|
/**
|
|
* Opens Add Auto Router and returns the Template select's trigger, which is the
|
|
* shallowest real page that renders SelectContent with tall multi-line options.
|
|
*/
|
|
async function openTemplateSelect(page: PlaywrightPage) {
|
|
await navigateToPage(page, Page.Models);
|
|
await page.getByRole("tab", { name: "Auto-Routers" }).click();
|
|
await page.getByRole("button", { name: "Add Auto Router" }).click();
|
|
|
|
const trigger = page.getByTestId("template-selector");
|
|
await expect(trigger).toBeVisible();
|
|
return trigger;
|
|
}
|
|
|
|
async function boxes(trigger: Locator, options: Locator) {
|
|
const triggerBox = await trigger.boundingBox();
|
|
const optionsBox = await options.boundingBox();
|
|
return triggerBox && optionsBox ? { triggerBox, optionsBox } : null;
|
|
}
|
|
|
|
const clippedPopup = (page: PlaywrightPage) => page.locator('[data-slot="select-content"]');
|
|
|
|
function pollOptionsCoverTrigger(trigger: Locator, options: Locator) {
|
|
return expect.poll(async () => {
|
|
const box = await boxes(trigger, options);
|
|
return (
|
|
box &&
|
|
box.optionsBox.y < box.triggerBox.y + box.triggerBox.height &&
|
|
box.optionsBox.y + box.optionsBox.height > box.triggerBox.y
|
|
);
|
|
});
|
|
}
|
|
|
|
test.describe("Auto Router template select anchoring", () => {
|
|
test.use({ storageState: ADMIN_STORAGE_PATH });
|
|
|
|
test("keeps the trigger uncovered when the options open with no room below it", async ({ page }) => {
|
|
await page.setViewportSize({ width: 1280, height: 560 });
|
|
const trigger = await openTemplateSelect(page);
|
|
await trigger.scrollIntoViewIfNeeded();
|
|
|
|
await trigger.click();
|
|
await expect(page.getByRole("listbox")).toBeVisible();
|
|
|
|
await pollOptionsCoverTrigger(trigger, clippedPopup(page)).toBe(false);
|
|
});
|
|
});
|