mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-27 01:22:18 +00:00
* ci: run the unit_selection.sh shard files on every event instead of only fork pull requests Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * ci: rename fork-flag to unit-flag now that it applies on every event * test: move tests/test_litellm root and small trees into tests/unit Pure renames, no content changes. Follow-up commits in this PR fix references, merge the three files that already existed in tests/unit, keep live-provider tests in tests/test_litellm and wire CI. * test: carry tests/test_litellm conftest isolation into tests/unit Callback lists, routing fallbacks, cached HTTP clients, logger state, AWS, proxy-URL and keychain env, and session-end client cleanup now reset for unit tests too. The environment isolation owns its MonkeyPatch so a test's own monkeypatch is undone before the model-cost teardown runs. * test: merge, split and prune the moved root and small-tree tests Merge batches/test_batch_utils.py and the chat_completions and messages dispatch tests into the files that already existed in tests/unit. Keep the live Gemini interactions tests, the async image-fetch format test and the OpenAI embedding scorer test in tests/test_litellm since they need real network or keys. Put test_router.py under tests/unit/test_router so the existing package no longer shadows it. Delete eight tests the audit found superseded by stronger ones kept in this move. * ci: run the moved root and small-tree tests under their legacy flags Add the misc and responses-caching-types flags to unit_selection.sh and CircleCI, extend enterprise-routing and mcp-integration, and point the legacy GHA shards, Makefile, redis-compat workflow, merge smoke manifest and change classifier at the new paths. * test: make the new tests/unit directories packages tests/unit/test_package_layout.py requires every directory to carry an __init__.py, and without one the moved and retained test_litellm_responses_bridge.py modules collide on import. * test: scope the unit socket block to tests/unit in shared sessions The GHA shards collect the legacy test-path and the unit selection in one pytest session. The unit conftest's loopback-only block leaked into legacy modules that reach the network at import. The legacy conftest now lifts the restriction at collect and setup time, and the unit conftest re-applies it when collecting its own modules. * test: move tests/test_litellm/llms into tests/unit/llms Rename-only. Moves the provider tests and the fine-tuning fixtures they load, mirroring the old paths. Follow-up commits merge, split and wire them. * test: merge, split and prune the moved llms tests Merges the Databricks chat transformation tests into the existing unit file, keeps the tests that need real keys or the network in tests/test_litellm, deletes the audited tests a stronger unit test already covers, and points imports at tests.unit.llms. * ci: run the moved llms tests under their legacy flags The Vertex AI and All Other Providers shards keep their legacy test-path for the retained files and add the llm-vertex-ai and llm-other-providers unit selections. CircleCI gets matching unit jobs. * test: make the tests/unit/llms directories packages Adds __init__.py to the moved dirs and drops the legacy ones whose directories no longer hold tests. * test: drop script runners and path hacks the llms split left dangling The __main__ runners in the split openai_like files and the Databricks e2e runner called tests that now live in the other half of the split or were deleted. The retained legacy halves also no longer need sys.path edits. * test: give the shard-script tests their own GITHUB_OUTPUT They only passed where the runner set it. The CircleCI unit job's env allowlist drops it, so the script's redirect failed there. * test: point the router and module-deletion checks at tests/unit router_code_coverage and code_qa_check_tests only searched tests/test_litellm, so the moved router tests no longer counted. The two silent-experiment tests the audit deleted were the only direct callers of those methods; they are replaced with tests that assert the forwarded shadow request and the recursion guard. * test: move tests/test_litellm integrations and secret_managers into tests/unit Rename-only. Mirrors the old paths, including the directory conftests and the prompt and JSON fixtures. Follow-up commits prune and wire them. * test: prune and repoint the moved integrations tests Deletes the 7 audited tests a stronger test in the same tree already covers, imports the TLS sink helpers from their new conftest path, and restores os.environ after each integrations test. Some presets write OTEL_EXPORTER_OTLP_HEADERS straight into os.environ, and without the legacy tree's test ordering that header leaked into the AgentOps tests. * ci: run the moved integrations tests under their legacy flag The integrations GHA shard and a new CircleCI job run the integrations unit selection. secret_managers joins the misc selection. * docs: point integrations and secret_managers references at tests/unit * test: make the moved integrations directories packages * test: keep the Databricks manual e2e runner and fix the SageMaker Nova run path The Databricks e2e file is a manual script whose main() calls the tests that were pruned, so pruning them broke the documented run. It is back to its main version. The SageMaker Nova docstring now points at the file's real location in tests/local_testing. * test: move tests/test_litellm core utils, routing, responses, caching and rust_bridge into tests/unit Rename-only. Mirrors the old paths, including fixtures, the stubtest config and the native-route wheel script. Two files that collide with existing unit files are merged in a follow-up commit. * test: merge, prune and repoint the moved core, routing, responses, caching and rust_bridge tests Merges the two files that collided with existing unit files, folding the legacy extra case into test_is_chat_completion_cached_dict, and deletes the 9 audited tests a stronger test in the same file already covers. Keeps what needs the network in tests/test_litellm: test_tokenizers pulls a tokenizer from the Hugging Face hub, and the gpt2 and r50k_base tokenizer cases download their BPE files. The unit core_utils conftest points TIKTOKEN_CACHE_DIR at litellm's bundled encodings so the rest never depend on import order to stay offline, and FakeSecretVault moves to a shared module so both trees can build it. * ci: run the moved core, routing, responses, caching and rust_bridge tests under their flags core_utils gets a core-utils flag and CircleCI job, and its GHA shard keeps the legacy path for the retained network tests. router_utils and router_strategy join enterprise-routing, responses joins responses-caching-types (minus responses/mcp, which mcp-integration owns), caching joins caching-local and rust_bridge joins misc. The redis-compat, test-rust, stubtest and merge-smoke paths follow the move. * docs: point the Rust crate references at tests/unit * test: make the moved core, routing and rust_bridge directories packages * test: keep the no-loop DualCache batch_get_cache regression test It runs the sync path outside any event loop, which the inside-loop test cannot, so a change that picks the Redis client by loop state would only show up there. * test: keep the job's UNIT_FLAG out of the shard-script tests * fix(url_utils): block 192.0.0.0/24 on every Python patch release * test: move the new budget limiter tests into tests/unit/router_strategy * test: move the new sentry scrubbing tests into tests/unit/litellm_core_utils * test: move the new zerobus tests into tests/unit/integrations * test: make tests/unit/integrations/zerobus a package * test: load litellm's own tiktoken cache setup once instead of resetting it per test --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1571 lines
76 KiB
Python
1571 lines
76 KiB
Python
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import inspect
|
|
import json
|
|
import re
|
|
from collections.abc import Mapping
|
|
from dataclasses import dataclass
|
|
from functools import partial
|
|
from importlib import import_module
|
|
from types import SimpleNamespace
|
|
from typing import Final, Never
|
|
from urllib.parse import urlsplit
|
|
|
|
import httpx
|
|
import pytest
|
|
from botocore.auth import SigV4Auth
|
|
from botocore.awsrequest import AWSRequest
|
|
from botocore.credentials import Credentials
|
|
from pydantic import JsonValue
|
|
|
|
import litellm
|
|
from litellm.rust_bridge import bindings
|
|
from litellm.rust_bridge.bindings import NativeBinding
|
|
from litellm.rust_bridge.catalog import Rules, SecretManagerRule
|
|
from litellm.rust_bridge.configuration import Rollout
|
|
from litellm.rust_bridge.secret_manager import (
|
|
NativeSecretManagerFactory,
|
|
NativeSecretManagerRuntime,
|
|
capture_secret_manager,
|
|
native_secret_manager_config,
|
|
resolve_native_provider_reader,
|
|
resolve_native_provider_writer,
|
|
resolve_native_secret_manager,
|
|
)
|
|
from litellm.secret_managers.aws_secret_manager_v2 import AWSSecretsManagerV2
|
|
from litellm.secret_managers.cyberark_secret_manager import CyberArkSecretManager
|
|
from litellm.secret_managers.dispatch import get_secret_from_manager
|
|
from litellm.secret_managers.hashicorp_secret_manager import HashicorpSecretManager
|
|
from litellm.types.secret_managers.main import KeyManagementSettings, KeyManagementSystem
|
|
from tests.test_litellm_rust.support.recording_server import ResponseSpec, recording_service
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def preserve_manager_globals(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(litellm, "secret_manager_client", litellm.secret_manager_client)
|
|
monkeypatch.setattr(litellm, "_key_management_system", litellm._key_management_system)
|
|
monkeypatch.setattr(litellm, "_key_management_settings", litellm._key_management_settings)
|
|
|
|
|
|
def _vault(monkeypatch: pytest.MonkeyPatch, address: str) -> HashicorpSecretManager:
|
|
from litellm.proxy import proxy_server
|
|
|
|
monkeypatch.setattr(proxy_server, "premium_user", True)
|
|
monkeypatch.setenv("HCP_VAULT_ADDR", address)
|
|
monkeypatch.setenv("HCP_VAULT_TOKEN", "token")
|
|
return HashicorpSecretManager()
|
|
|
|
|
|
def _vault_body(value: str) -> dict[str, object]:
|
|
return {
|
|
"data": {
|
|
"data": {"key": value},
|
|
"metadata": {
|
|
"created_time": "",
|
|
"deletion_time": "",
|
|
"custom_metadata": None,
|
|
"destroyed": False,
|
|
"version": 1,
|
|
},
|
|
},
|
|
"lease_id": "",
|
|
"lease_duration": 0,
|
|
"renewable": False,
|
|
"request_id": "",
|
|
"warnings": None,
|
|
"wrap_info": None,
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize("system", ("aws_secret_manager", "hashicorp_vault", "cyberark"))
|
|
async def test_python_native_handle_reuses_backend_across_sync_and_async_reads(system: str) -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
environment: Final = {
|
|
"AWS_REGION_NAME": "us-east-1",
|
|
"AWS_ACCESS_KEY_ID": "captured-access",
|
|
"AWS_SECRET_ACCESS_KEY": "captured-secret",
|
|
"AWS_BEDROCK_RUNTIME_ENDPOINT": server.base_url,
|
|
"AZURE_KEY_VAULT_URI": server.base_url,
|
|
"AZURE_AD_TOKEN": "azure-token",
|
|
"HCP_VAULT_ADDR": server.base_url,
|
|
"HCP_VAULT_TOKEN": "vault-token",
|
|
"CYBERARK_API_BASE": server.base_url,
|
|
"CYBERARK_API_KEY": "cyberark-key",
|
|
"CYBERARK_ACCOUNT": "account",
|
|
"CYBERARK_USERNAME": "reader",
|
|
}
|
|
responses: Final = {
|
|
"aws_secret_manager": {"SecretString": "native-value"},
|
|
"azure_key_vault": {"value": "native-value"},
|
|
"hashicorp_vault": _vault_body("native-value"),
|
|
"cyberark": "native-value",
|
|
}
|
|
server.default_response = ResponseSpec(body=responses[system])
|
|
server.expected_requests = 2 if system == "cyberark" else 1 if system == "hashicorp_vault" else 3
|
|
if system == "cyberark":
|
|
server.enqueue(ResponseSpec(body="authentication-token"))
|
|
handle: Final = native._SecretManagerRuntime.from_config(system, environment, enterprise_enabled=True)
|
|
expected: Final = '"native-value"' if system == "cyberark" else "native-value"
|
|
assert handle.read_secret("KEY") == expected
|
|
assert await handle.async_read_secret("KEY") == expected
|
|
assert handle.read_secret("KEY") == expected
|
|
|
|
|
|
def test_shared_initializer_captures_credentials_and_tracks_instance_settings(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body={"SecretString": "native-value"})
|
|
server.expected_requests = 2
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "captured-access")
|
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "captured-secret")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", server.base_url)
|
|
from litellm.proxy.proxy_server import ProxyConfig
|
|
|
|
monkeypatch.setattr(litellm, "_key_management_settings", KeyManagementSettings(aws_region_name="us-east-1"))
|
|
ProxyConfig().initialize_secret_manager(KeyManagementSystem.AWS_SECRET_MANAGER.value)
|
|
manager: Final = litellm.secret_manager_client
|
|
assert isinstance(manager, AWSSecretsManagerV2)
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "changed-access")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", "http://127.0.0.1:1")
|
|
first: Final = native._SecretManagerRuntime.from_client(manager)
|
|
assert first is not None
|
|
assert native._SecretManagerRuntime.from_client(manager) is first
|
|
assert first.read_secret("KEY") == "native-value"
|
|
manager.aws_region_name = "us-west-2"
|
|
second: Final = native._SecretManagerRuntime.from_client(manager)
|
|
assert second is not None
|
|
assert second is not first
|
|
assert second.read_secret("KEY") == "native-value"
|
|
assert "Credential=captured-access/" in server.requests[0].headers["authorization"]
|
|
assert "/us-east-1/" in server.requests[0].headers["authorization"]
|
|
assert "/us-west-2/" in server.requests[1].headers["authorization"]
|
|
|
|
|
|
def test_configuration_replacement_rebuilds_without_invalidating_existing_handles(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as first_server, recording_service() as second_server:
|
|
first_server.default_response = ResponseSpec(body=_vault_body("first"))
|
|
second_server.default_response = ResponseSpec(body=_vault_body("second"))
|
|
manager: Final = _vault(monkeypatch, first_server.base_url)
|
|
first: Final = native._SecretManagerRuntime.from_client(manager)
|
|
assert first is not None
|
|
assert first.read_secret("KEY") == "first"
|
|
manager.vault_addr = second_server.base_url
|
|
second: Final = native._SecretManagerRuntime.from_client(manager)
|
|
assert second is not None
|
|
assert second is not first
|
|
assert second.read_secret("KEY") == "second"
|
|
assert first.read_secret("KEY") == "first"
|
|
|
|
|
|
def test_custom_subclass_keeps_its_python_reader_under_native_selection() -> None:
|
|
class CustomManager(AWSSecretsManagerV2):
|
|
def sync_read_secret(self, secret_name: str, primary_secret_name: str | None = None) -> str:
|
|
return f"custom:{secret_name}"
|
|
|
|
class DecliningFactory:
|
|
@staticmethod
|
|
def from_client(client: object) -> NativeSecretManagerRuntime | None:
|
|
assert native_secret_manager_config(client) is None
|
|
return None
|
|
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(DecliningFactory)
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_REQUIRED, systems=frozenset({"aws_secret_manager"})),)
|
|
assert (
|
|
get_secret_from_manager(
|
|
CustomManager(aws_region_name="us-east-1"), "aws_secret_manager", "KEY", rules=rules, binding=binding
|
|
)
|
|
== "custom:KEY"
|
|
)
|
|
|
|
|
|
def test_read_dispatch_uses_native_backend_with_explicit_rules(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body=_vault_body("native-value"))
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_REQUIRED, systems=frozenset({"hashicorp_vault"})),)
|
|
assert get_secret_from_manager(manager, "hashicorp_vault", "KEY", rules=rules) == "native-value"
|
|
runtime: Final = native._SecretManagerRuntime.from_client(manager)
|
|
assert runtime is not None
|
|
assert runtime.read_secret("KEY") == "native-value"
|
|
assert len(server.requests) == 1
|
|
|
|
|
|
@pytest.mark.parametrize("system", ("google_secret_manager", "hashicorp_vault", "cyberark"))
|
|
def test_enterprise_backends_cannot_initialize_without_entitlement(system: str) -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with pytest.raises(ValueError, match=r"[Ee]nterprise|[Pp]remium"):
|
|
native._SecretManagerRuntime.from_config(system, {"CYBERARK_API_KEY": "key"})
|
|
|
|
|
|
def test_azure_factory_rejects_unencrypted_vault_endpoints() -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with pytest.raises(ValueError, match="https"):
|
|
native._SecretManagerRuntime.from_config("azure_key_vault", {"AZURE_KEY_VAULT_URI": "http://127.0.0.1:1"})
|
|
|
|
|
|
def test_direct_builtin_constructor_can_use_native_without_registration(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body=_vault_body("native-value"))
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
handle: Final = native._SecretManagerRuntime.from_client(manager)
|
|
assert handle is not None
|
|
assert handle.read_secret("KEY") == "native-value"
|
|
|
|
|
|
def test_binding_rejects_a_different_backend_before_reading() -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.expected_requests = 0
|
|
handle: Final = native._SecretManagerRuntime.from_config(
|
|
"hashicorp_vault",
|
|
{"HCP_VAULT_ADDR": server.base_url, "HCP_VAULT_TOKEN": "token"},
|
|
enterprise_enabled=True,
|
|
)
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_REQUIRED, systems=frozenset({"aws_secret_manager"})),)
|
|
with pytest.raises(ValueError, match="system does not match"):
|
|
resolve_native_secret_manager(handle, "aws_secret_manager", rules)
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_OPT_OUT))
|
|
def test_python_selection_and_missing_extension_preserve_python_reader(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout
|
|
) -> None:
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(None)
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body=_vault_body("python-value"))
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
rules: Final[Rules] = (SecretManagerRule(rollout, systems=frozenset({"hashicorp_vault"})),)
|
|
assert (
|
|
get_secret_from_manager(manager, "hashicorp_vault", "KEY", rules=rules, binding=binding) == "python-value"
|
|
)
|
|
assert server.requests[0].headers["x-vault-token"] == "token"
|
|
|
|
|
|
def test_required_native_missing_extension_does_not_read_python(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(None)
|
|
with recording_service() as server:
|
|
server.expected_requests = 0
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_REQUIRED, systems=frozenset({"hashicorp_vault"})),)
|
|
with pytest.raises(RuntimeError, match="unavailable"):
|
|
get_secret_from_manager(manager, "hashicorp_vault", "KEY", rules=rules, binding=binding)
|
|
|
|
|
|
def test_native_failure_is_not_replayed_in_python(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(status=403, body={"errors": ["denied"]})
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_OPT_OUT, systems=frozenset({"hashicorp_vault"})),)
|
|
with pytest.raises(ValueError, match="HashiCorp Vault"):
|
|
get_secret_from_manager(manager, "hashicorp_vault", "KEY", rules=rules)
|
|
assert len(server.requests) == 1
|
|
|
|
|
|
@pytest.mark.parametrize("explicit_capture", (False, True))
|
|
def test_config_capture_preserves_credentials_and_excludes_unrelated_environment(
|
|
monkeypatch: pytest.MonkeyPatch, explicit_capture: bool
|
|
) -> None:
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "initial-access")
|
|
monkeypatch.setenv("SECRET_MANAGER_REFRESH_INTERVAL", "45")
|
|
monkeypatch.setenv("UNRELATED_PRIVATE_TOKEN", "unrelated-secret")
|
|
manager: Final = AWSSecretsManagerV2(aws_region_name="us-east-1")
|
|
if explicit_capture:
|
|
capture_secret_manager(manager, "aws_secret_manager")
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "replacement-access")
|
|
captured: Final = native_secret_manager_config(manager)
|
|
assert captured is not None
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "replacement-access")
|
|
|
|
retained: Final = native_secret_manager_config(manager)
|
|
|
|
assert retained is captured
|
|
assert retained.system == "aws_secret_manager"
|
|
assert dict(retained.environment)["AWS_ACCESS_KEY_ID"] == "initial-access"
|
|
assert dict(retained.environment)["SECRET_MANAGER_REFRESH_INTERVAL"] == "45"
|
|
assert "UNRELATED_PRIVATE_TOKEN" not in dict(retained.environment)
|
|
assert "initial-access" not in repr(retained)
|
|
assert retained.settings == KeyManagementSettings().model_dump(mode="json")
|
|
|
|
|
|
def test_kms_sdk_client_capture_preserves_environment(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
import boto3
|
|
|
|
monkeypatch.setenv("AWS_REGION_NAME", "captured-region")
|
|
client: Final = boto3.client(
|
|
"kms", region_name="us-east-1", aws_access_key_id="access", aws_secret_access_key="secret"
|
|
)
|
|
try:
|
|
capture_secret_manager(client, "aws_kms")
|
|
monkeypatch.setenv("AWS_REGION_NAME", "replacement-region")
|
|
|
|
captured: Final = native_secret_manager_config(client)
|
|
|
|
assert captured is not None
|
|
assert captured.system == "aws_kms"
|
|
assert dict(captured.environment)["AWS_REGION_NAME"] == "captured-region"
|
|
finally:
|
|
client.close()
|
|
|
|
|
|
def test_same_named_custom_client_is_not_captured() -> None:
|
|
class AWSSecretsManagerV2:
|
|
pass
|
|
|
|
client: Final = AWSSecretsManagerV2()
|
|
capture_secret_manager(client, "aws_secret_manager")
|
|
|
|
assert native_secret_manager_config(client) is None
|
|
|
|
|
|
@dataclass(slots=True)
|
|
class _RecordingRuntime:
|
|
system: str
|
|
result: str | None
|
|
calls: tuple[tuple[str, Mapping[str, object] | None], ...] = ()
|
|
|
|
def read_secret(self, name: str, settings: Mapping[str, object] | None = None) -> str | None:
|
|
self.calls = (*self.calls, (name, settings))
|
|
return self.result
|
|
|
|
|
|
@pytest.mark.parametrize("value", (None, " value\n"))
|
|
@pytest.mark.parametrize("settings", (None, KeyManagementSettings(primary_secret_name="primary")))
|
|
def test_native_dispatch_forwards_settings_and_preserves_missing_or_unmodified_values(
|
|
value: str | None, settings: KeyManagementSettings | None
|
|
) -> None:
|
|
client: Final = object()
|
|
runtime: Final = _RecordingRuntime("aws_secret_manager", value)
|
|
|
|
class Factory:
|
|
@staticmethod
|
|
def from_client(candidate: object) -> NativeSecretManagerRuntime:
|
|
assert candidate is client
|
|
return runtime
|
|
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(Factory)
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_REQUIRED, systems=frozenset({runtime.system})),)
|
|
|
|
result: Final = get_secret_from_manager(client, runtime.system, "KEY", settings, rules=rules, binding=binding)
|
|
|
|
assert result == value
|
|
assert runtime.calls == (("KEY", settings.model_dump(mode="json") if settings is not None else None),)
|
|
|
|
|
|
def test_native_system_mismatch_is_rejected_before_reading() -> None:
|
|
runtime: Final = _RecordingRuntime("hashicorp_vault", "wrong-provider")
|
|
|
|
class Factory:
|
|
@staticmethod
|
|
def from_client(client: object) -> NativeSecretManagerRuntime:
|
|
return runtime
|
|
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(Factory)
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_REQUIRED, systems=frozenset({"aws_secret_manager"})),)
|
|
|
|
with pytest.raises(ValueError, match="system does not match"):
|
|
get_secret_from_manager(object(), "aws_secret_manager", "KEY", rules=rules, binding=binding)
|
|
|
|
assert runtime.calls == ()
|
|
|
|
|
|
@pytest.mark.parametrize("system", ("custom", "local"))
|
|
def test_python_only_manager_types_never_construct_a_native_backend(system: str) -> None:
|
|
class ForbiddenFactory:
|
|
@staticmethod
|
|
def from_client(client: object) -> NativeSecretManagerRuntime:
|
|
raise AssertionError("custom and local clients cannot use native backends")
|
|
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(ForbiddenFactory)
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_REQUIRED, systems=frozenset({system})),)
|
|
|
|
assert resolve_native_secret_manager(object(), system, rules, binding=binding) is None
|
|
|
|
|
|
@pytest.mark.parametrize("factory", (None, SimpleNamespace(from_client="not callable")))
|
|
def test_invalid_native_factories_are_reported_as_unavailable(monkeypatch: pytest.MonkeyPatch, factory: object) -> None:
|
|
monkeypatch.setattr(bindings, "get_native_bridge", lambda: SimpleNamespace(_SecretManagerRuntime=factory))
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_REQUIRED, systems=frozenset({"aws_secret_manager"})),)
|
|
|
|
with pytest.raises(RuntimeError, match="runtime is unavailable"):
|
|
resolve_native_secret_manager(object(), "aws_secret_manager", rules)
|
|
|
|
|
|
def test_native_binding_accepts_a_callable_factory(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
runtime: Final = _RecordingRuntime("aws_secret_manager", "value")
|
|
|
|
class Factory:
|
|
@staticmethod
|
|
def from_client(client: object) -> NativeSecretManagerRuntime:
|
|
return runtime
|
|
|
|
monkeypatch.setattr(bindings, "get_native_bridge", lambda: SimpleNamespace(_SecretManagerRuntime=Factory))
|
|
rules: Final[Rules] = (SecretManagerRule(Rollout.RUST_REQUIRED, systems=frozenset({runtime.system})),)
|
|
|
|
assert resolve_native_secret_manager(object(), runtime.system, rules) is runtime
|
|
|
|
|
|
@pytest.mark.parametrize("value", ("text", "", True, False, 42, 2**100, [1, "two"], {"nested": True}, None))
|
|
async def test_aws_primary_values_match_python_handler(monkeypatch: pytest.MonkeyPatch, value: JsonValue) -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body={"SecretString": json.dumps({"KEY": value})})
|
|
server.expected_requests = 3
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "test-access")
|
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", server.base_url)
|
|
manager: Final = AWSSecretsManagerV2(aws_region_name="us-east-1")
|
|
settings: Final = KeyManagementSettings(primary_secret_name="primary")
|
|
reference: Final = get_secret_from_manager(
|
|
manager, "aws_secret_manager", "KEY", settings, rules=(SecretManagerRule(Rollout.PYTHON_ONLY),)
|
|
)
|
|
actual: Final = get_secret_from_manager(
|
|
manager, "aws_secret_manager", "KEY", settings, rules=(SecretManagerRule(Rollout.RUST_REQUIRED),)
|
|
)
|
|
handle: Final = native._SecretManagerRuntime.from_client(manager)
|
|
assert handle is not None
|
|
asynchronous: Final = await handle.read_secret_async("KEY", settings.model_dump(mode="json"))
|
|
assert type(actual) is type(reference) is type(value)
|
|
assert actual == reference == value
|
|
assert type(asynchronous) is type(reference)
|
|
assert asynchronous == reference
|
|
assert tuple(json.loads(request.raw_body) for request in server.requests) == ({"SecretId": "primary"},) * 3
|
|
|
|
|
|
@pytest.mark.parametrize("primary", (None, "primary"))
|
|
@pytest.mark.parametrize(
|
|
("status", "body"),
|
|
(
|
|
(400, {"__type": "ResourceNotFoundException"}),
|
|
(403, {"__type": "AccessDeniedException"}),
|
|
(500, {"__type": "InternalServiceError"}),
|
|
(200, {"Name": "without-string"}),
|
|
(200, {"SecretString": ""}),
|
|
),
|
|
)
|
|
def test_aws_absence_and_failed_reads_match_python_without_environment_fallback(
|
|
monkeypatch: pytest.MonkeyPatch, primary: str | None, status: int, body: dict[str, str]
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(status=status, body=body)
|
|
server.expected_requests = 2
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "test-access")
|
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", server.base_url)
|
|
monkeypatch.setenv("KEY", "must-not-fall-back")
|
|
manager: Final = AWSSecretsManagerV2(aws_region_name="us-east-1")
|
|
settings: Final = KeyManagementSettings(primary_secret_name=primary)
|
|
monkeypatch.setattr(litellm, "secret_manager_client", manager)
|
|
monkeypatch.setattr(litellm, "_key_management_system", KeyManagementSystem.AWS_SECRET_MANAGER)
|
|
monkeypatch.setattr(litellm, "_key_management_settings", settings)
|
|
main: Final = import_module("litellm.secret_managers.main")
|
|
monkeypatch.setattr(
|
|
main,
|
|
"get_secret_from_manager",
|
|
partial(get_secret_from_manager, rules=(SecretManagerRule(Rollout.PYTHON_ONLY),)),
|
|
)
|
|
reference: Final = litellm.get_secret("KEY", "must-not-default")
|
|
monkeypatch.setattr(
|
|
main,
|
|
"get_secret_from_manager",
|
|
partial(get_secret_from_manager, rules=(SecretManagerRule(Rollout.RUST_REQUIRED),)),
|
|
)
|
|
actual: Final = litellm.get_secret("KEY", "must-not-default")
|
|
assert actual == reference
|
|
assert actual == ("" if primary is None and body.get("SecretString") == "" else None)
|
|
|
|
|
|
@pytest.mark.parametrize("document", ("{", "not-json", "[1]", "null", "true", "42", '"text"'))
|
|
async def test_aws_primary_json_errors_preserve_python_exception_details(
|
|
monkeypatch: pytest.MonkeyPatch, document: str
|
|
) -> None:
|
|
native: Final = pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body={"SecretString": document})
|
|
server.expected_requests = 3
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "test-access")
|
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", server.base_url)
|
|
manager: Final = AWSSecretsManagerV2(aws_region_name="us-east-1")
|
|
settings: Final = KeyManagementSettings(primary_secret_name="primary")
|
|
with pytest.raises((json.JSONDecodeError, AttributeError)) as reference:
|
|
get_secret_from_manager(
|
|
manager, "aws_secret_manager", "KEY", settings, rules=(SecretManagerRule(Rollout.PYTHON_ONLY),)
|
|
)
|
|
with pytest.raises(type(reference.value)) as actual:
|
|
get_secret_from_manager(
|
|
manager, "aws_secret_manager", "KEY", settings, rules=(SecretManagerRule(Rollout.RUST_REQUIRED),)
|
|
)
|
|
assert actual.value.args == reference.value.args
|
|
if isinstance(reference.value, json.JSONDecodeError):
|
|
assert isinstance(actual.value, json.JSONDecodeError)
|
|
assert (actual.value.doc, actual.value.pos) == (reference.value.doc, reference.value.pos)
|
|
handle: Final = native._SecretManagerRuntime.from_client(manager)
|
|
assert handle is not None
|
|
with pytest.raises(type(reference.value)) as asynchronous:
|
|
await handle.read_secret_async("KEY", settings.model_dump(mode="json"))
|
|
assert asynchronous.value.args == reference.value.args
|
|
|
|
|
|
def _select_provider_reads(monkeypatch: pytest.MonkeyPatch, module_name: str, rollout: Rollout) -> None:
|
|
module: Final = import_module(module_name)
|
|
monkeypatch.setattr(
|
|
module,
|
|
"resolve_native_provider_reader",
|
|
partial(resolve_native_provider_reader, rules=(SecretManagerRule(rollout),)),
|
|
)
|
|
if rollout is Rollout.RUST_REQUIRED:
|
|
monkeypatch.setattr(module, "_get_httpx_client", _forbid_python_http)
|
|
monkeypatch.setattr(module, "get_async_httpx_client", _forbid_python_http)
|
|
|
|
|
|
def _forbid_python_http(*args: object, **kwargs: object) -> Never:
|
|
raise AssertionError("native reads must not construct a Python HTTP client")
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_aws_reads_preserve_coroutines_and_per_call_credentials(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as initial, recording_service() as selected:
|
|
initial.expected_requests = 0
|
|
selected.expected_requests = 2
|
|
selected.default_response = ResponseSpec(body={"SecretString": "value"})
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "environment-access")
|
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "environment-secret")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", initial.base_url)
|
|
manager: Final = AWSSecretsManagerV2(aws_region_name="us-east-1")
|
|
_select_provider_reads(monkeypatch, "litellm.secret_managers.aws_secret_manager_v2", rollout)
|
|
options: Final = {
|
|
"aws_region_name": "us-west-2",
|
|
"aws_bedrock_runtime_endpoint": selected.base_url,
|
|
"aws_access_key_id": "operation-access",
|
|
"aws_secret_access_key": "operation-secret",
|
|
"aws_session_token": "operation-session",
|
|
}
|
|
pending: Final = manager.async_read_secret(secret_name="KEY", optional_params=dict(options), timeout=2)
|
|
assert inspect.iscoroutine(pending)
|
|
assert selected.requests == []
|
|
assert await asyncio.create_task(pending) == "value"
|
|
assert manager.sync_read_secret("KEY", dict(options), 2) == "value"
|
|
assert tuple(json.loads(request.raw_body) for request in selected.requests) == ({"SecretId": "KEY"},) * 2
|
|
assert all(
|
|
"Credential=operation-access/" in request.headers["authorization"]
|
|
and "/us-west-2/" in request.headers["authorization"]
|
|
and request.headers["x-amz-security-token"] == "operation-session"
|
|
for request in selected.requests
|
|
)
|
|
for request in selected.requests:
|
|
signed_headers: Final = request.headers["authorization"].split("SignedHeaders=")[1].split(",")[0].split(";")
|
|
signed_request: Final = AWSRequest(
|
|
method=request.method,
|
|
url=selected.base_url + request.path,
|
|
data=request.raw_body,
|
|
headers={name: request.headers[name] for name in signed_headers},
|
|
)
|
|
signed_request.context["timestamp"] = request.headers["x-amz-date"]
|
|
signer: Final = SigV4Auth(
|
|
Credentials(
|
|
options["aws_access_key_id"], options["aws_secret_access_key"], options["aws_session_token"]
|
|
),
|
|
"secretsmanager",
|
|
options["aws_region_name"],
|
|
)
|
|
string_to_sign: Final = signer.string_to_sign(signed_request, signer.canonical_request(signed_request))
|
|
assert request.headers["authorization"].split("Signature=")[1] == signer.signature(
|
|
string_to_sign, signed_request
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_aws_primary_reads_ignore_operation_overrides_like_python(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server, recording_service() as unused:
|
|
server.default_response = ResponseSpec(body={"SecretString": '{"KEY":true}'})
|
|
server.expected_requests = 2
|
|
unused.expected_requests = 0
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "test-access")
|
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", server.base_url)
|
|
manager: Final = AWSSecretsManagerV2(aws_region_name="us-east-1")
|
|
_select_provider_reads(monkeypatch, "litellm.secret_managers.aws_secret_manager_v2", rollout)
|
|
options: Final = {"aws_bedrock_runtime_endpoint": unused.base_url}
|
|
assert manager.sync_read_secret("KEY", options, 0, "primary") is True
|
|
assert (
|
|
await manager.async_read_secret("KEY", optional_params=options, timeout=0, primary_secret_name="primary")
|
|
is True
|
|
)
|
|
assert tuple(json.loads(request.raw_body) for request in server.requests) == ({"SecretId": "primary"},) * 2
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_aws_bootstrap_names_only_bypass_sync_reads(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body={"SecretString": "remote-access"})
|
|
server.expected_requests = 1
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "environment-access")
|
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "environment-secret")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", server.base_url)
|
|
manager: Final = AWSSecretsManagerV2(aws_region_name="us-east-1")
|
|
_select_provider_reads(monkeypatch, "litellm.secret_managers.aws_secret_manager_v2", rollout)
|
|
assert manager.sync_read_secret("AWS_ACCESS_KEY_ID") == "environment-access"
|
|
assert server.requests == []
|
|
assert await manager.async_read_secret("AWS_ACCESS_KEY_ID") == "remote-access"
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("timeout", (0.05, httpx.Timeout(1, read=0.05)))
|
|
async def test_public_aws_read_timeouts_follow_the_python_http_handler(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout, timeout: float | httpx.Timeout
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body={"SecretString": "too-late"}, delay=0.25)
|
|
server.expected_requests = 2
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "test-access")
|
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", server.base_url)
|
|
manager: Final = AWSSecretsManagerV2(aws_region_name="us-east-1")
|
|
_select_provider_reads(monkeypatch, "litellm.secret_managers.aws_secret_manager_v2", rollout)
|
|
assert manager.sync_read_secret("KEY", timeout=timeout) is None
|
|
assert await manager.async_read_secret("KEY", timeout=timeout) is None
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_vault_reads_keep_overrides_cache_and_coroutines(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body=_vault_body("value"))
|
|
server.expected_requests = 2
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_provider_reads(monkeypatch, "litellm.secret_managers.hashicorp_secret_manager", rollout)
|
|
options: Final = {"secret_manager_settings": {"mount": "team", "path_prefix": "keys", "data": "key"}}
|
|
pending: Final = manager.async_read_secret("KEY", options)
|
|
assert inspect.iscoroutine(pending)
|
|
assert server.requests == []
|
|
assert await asyncio.create_task(pending) == "value"
|
|
assert manager.sync_read_secret(secret_name="KEY", optional_params=options) == "value"
|
|
assert manager.sync_read_secret("KEY") == "value"
|
|
assert urlsplit(server.requests[0].path).path == "/v1/team/data/keys/KEY"
|
|
assert urlsplit(server.requests[1].path).path == "/v1/secret/data/KEY"
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("status", (404, 403))
|
|
async def test_public_vault_failed_reads_return_none_without_replay(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout, status: int
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(status=status, body={"errors": ["unavailable"]})
|
|
server.expected_requests = 2
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_provider_reads(monkeypatch, "litellm.secret_managers.hashicorp_secret_manager", rollout)
|
|
assert manager.sync_read_secret("KEY") is None
|
|
assert await manager.async_read_secret("KEY") is None
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_cyberark_reads_reuse_authentication_and_cached_values(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
from litellm.proxy import proxy_server
|
|
from litellm.secret_managers.cyberark_secret_manager import CyberArkSecretManager
|
|
|
|
monkeypatch.setattr(proxy_server, "premium_user", True)
|
|
with recording_service() as server:
|
|
server.enqueue(ResponseSpec(body="authentication-token"))
|
|
server.default_response = ResponseSpec(body="secret-value")
|
|
server.expected_requests = 2
|
|
monkeypatch.setenv("CYBERARK_API_BASE", server.base_url)
|
|
monkeypatch.setenv("CYBERARK_API_KEY", "api-key")
|
|
monkeypatch.setenv("CYBERARK_ACCOUNT", "account")
|
|
monkeypatch.setenv("CYBERARK_USERNAME", "reader")
|
|
manager: Final = CyberArkSecretManager()
|
|
_select_provider_reads(monkeypatch, "litellm.secret_managers.cyberark_secret_manager", rollout)
|
|
pending: Final = manager.async_read_secret(secret_name="KEY", timeout=0)
|
|
assert inspect.iscoroutine(pending)
|
|
assert server.requests == []
|
|
assert await asyncio.create_task(pending) == '"secret-value"'
|
|
assert manager.sync_read_secret("KEY", timeout=0) == (
|
|
'"secret-value"' if rollout is Rollout.RUST_REQUIRED else "secret-value"
|
|
)
|
|
assert tuple(request.path for request in server.requests) == (
|
|
"/authn/account/reader/authenticate",
|
|
"/secrets/account/variable/KEY",
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_native_selection_and_missing_extension_keep_the_python_method(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout
|
|
) -> None:
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(None)
|
|
module: Final = import_module("litellm.secret_managers.aws_secret_manager_v2")
|
|
monkeypatch.setattr(
|
|
module,
|
|
"resolve_native_provider_reader",
|
|
partial(resolve_native_provider_reader, rules=(SecretManagerRule(rollout),), binding=binding),
|
|
)
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body={"SecretString": "python-value"})
|
|
server.expected_requests = 0 if rollout is Rollout.RUST_REQUIRED else 1
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "test-access")
|
|
monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
|
|
monkeypatch.setenv("AWS_BEDROCK_RUNTIME_ENDPOINT", server.base_url)
|
|
manager: Final = AWSSecretsManagerV2(aws_region_name="us-east-1")
|
|
pending: Final = manager.async_read_secret("KEY")
|
|
if rollout is Rollout.RUST_REQUIRED:
|
|
with pytest.raises(RuntimeError, match="runtime is unavailable"):
|
|
await pending
|
|
else:
|
|
assert await pending == "python-value"
|
|
|
|
|
|
def test_public_aws_bootstrap_read_does_not_initialize_a_backend(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
module: Final = import_module("litellm.secret_managers.aws_secret_manager_v2")
|
|
monkeypatch.setattr(module, "resolve_native_provider_reader", _forbid_python_http)
|
|
monkeypatch.setenv("AWS_ACCESS_KEY_ID", "bootstrap-value")
|
|
assert AWSSecretsManagerV2().sync_read_secret("AWS_ACCESS_KEY_ID") == "bootstrap-value"
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("override", ("", 42))
|
|
def test_public_vault_prefix_overrides_match_python_string_conversion(
|
|
monkeypatch: pytest.MonkeyPatch, rollout: Rollout, override: str | int
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
monkeypatch.setenv("HCP_VAULT_PATH_PREFIX", "default-prefix")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body=_vault_body("value"))
|
|
server.expected_requests = 1
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_provider_reads(monkeypatch, "litellm.secret_managers.hashicorp_secret_manager", rollout)
|
|
assert manager.sync_read_secret("KEY", {"path_prefix": override}) == "value"
|
|
assert urlsplit(server.requests[0].path).path == (
|
|
f"/v1/secret/data/{override}/KEY" if override else "/v1/secret/data/KEY"
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("value", ("native-value", None))
|
|
def test_public_google_reader_uses_the_selected_binding_without_replaying_python(
|
|
monkeypatch: pytest.MonkeyPatch, value: str | None
|
|
) -> None:
|
|
from litellm.proxy import proxy_server
|
|
from litellm.secret_managers.google_secret_manager import GoogleSecretManager
|
|
|
|
class Manager(GoogleSecretManager):
|
|
def sync_construct_request_headers(self) -> dict[str, str]:
|
|
raise AssertionError("selected native reads must not construct Python auth headers")
|
|
|
|
class Reader(_RecordingRuntime):
|
|
def sync_read_secret(
|
|
self,
|
|
secret_name: str,
|
|
optional_params: Mapping[str, object] | None = None,
|
|
timeout: float | httpx.Timeout | None = None,
|
|
) -> str | None:
|
|
return self.read_secret(secret_name)
|
|
|
|
async def async_read_secret(
|
|
self,
|
|
secret_name: str,
|
|
optional_params: Mapping[str, object] | None = None,
|
|
timeout: float | httpx.Timeout | None = None,
|
|
) -> str | None:
|
|
return self.sync_read_secret(secret_name)
|
|
|
|
monkeypatch.setattr(proxy_server, "premium_user", True)
|
|
monkeypatch.setenv("GOOGLE_SECRET_MANAGER_PROJECT_ID", "project")
|
|
manager: Final = Manager()
|
|
runtime: Final = Reader("google_secret_manager", value)
|
|
|
|
class Factory:
|
|
@staticmethod
|
|
def from_client(candidate: object) -> NativeSecretManagerRuntime:
|
|
assert candidate is manager
|
|
return runtime
|
|
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(Factory)
|
|
module: Final = import_module("litellm.secret_managers.google_secret_manager")
|
|
monkeypatch.setattr(
|
|
module,
|
|
"resolve_native_provider_reader",
|
|
partial(resolve_native_provider_reader, rules=(SecretManagerRule(Rollout.RUST_REQUIRED),), binding=binding),
|
|
)
|
|
assert manager.get_secret_from_google_secret_manager(secret_name="KEY") == value
|
|
assert runtime.calls == (("KEY", None),)
|
|
|
|
|
|
def _cyberark(monkeypatch: pytest.MonkeyPatch, address: str) -> CyberArkSecretManager:
|
|
from litellm.proxy import proxy_server
|
|
|
|
monkeypatch.setattr(proxy_server, "premium_user", True)
|
|
monkeypatch.setenv("CYBERARK_API_BASE", address)
|
|
monkeypatch.setenv("CYBERARK_API_KEY", "api-key")
|
|
monkeypatch.setenv("CYBERARK_ACCOUNT", "account")
|
|
monkeypatch.setenv("CYBERARK_USERNAME", "reader")
|
|
return CyberArkSecretManager()
|
|
|
|
|
|
def _select_cyberark_mutations(monkeypatch: pytest.MonkeyPatch, rollout: Rollout) -> None:
|
|
module: Final = import_module("litellm.secret_managers.cyberark_secret_manager")
|
|
_select_provider_reads(monkeypatch, module.__name__, rollout)
|
|
monkeypatch.setattr(
|
|
module,
|
|
"resolve_native_provider_writer",
|
|
partial(resolve_native_provider_writer, rules=(SecretManagerRule(rollout),)),
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_cyberark_writes_and_deletes_share_the_read_cache(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
for body in (b"token", b"old", {}, {}, b"provider-after-delete"):
|
|
server.enqueue(ResponseSpec(body=body))
|
|
server.expected_requests = 5
|
|
manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, rollout)
|
|
assert manager.sync_read_secret("KEY") == "old"
|
|
pending: Final = manager.async_write_secret(
|
|
"KEY",
|
|
"new-value",
|
|
"ignored",
|
|
{"ignored": object()},
|
|
0,
|
|
{"ignored": object()},
|
|
)
|
|
assert inspect.iscoroutine(pending)
|
|
assert len(server.requests) == 2
|
|
assert await asyncio.create_task(pending) == {
|
|
"status": "success",
|
|
"message": "Secret KEY written successfully",
|
|
}
|
|
assert manager.sync_read_secret("KEY") == "new-value"
|
|
assert await manager.async_read_secret("KEY") == "new-value"
|
|
assert len(server.requests) == 4
|
|
assert await manager.async_delete_secret(secret_name="KEY", recovery_window_in_days=None, timeout=0) == {
|
|
"status": "not_supported",
|
|
"message": "CyberArk Conjur does not support direct secret deletion. Use policy updates to remove variables.",
|
|
}
|
|
assert len(server.requests) == 4
|
|
assert manager.sync_read_secret("KEY") == "provider-after-delete"
|
|
assert tuple(request.path for request in server.requests) == (
|
|
"/authn/account/reader/authenticate",
|
|
"/secrets/account/variable/KEY",
|
|
"/policies/account/policy/root",
|
|
"/secrets/account/variable/KEY",
|
|
"/secrets/account/variable/KEY",
|
|
)
|
|
assert server.requests[3].raw_body == b"new-value"
|
|
|
|
|
|
@pytest.mark.parametrize("status", (401, 403, 500))
|
|
@pytest.mark.parametrize("authentication", (False, True))
|
|
async def test_public_cyberark_write_errors_match_python_without_http_retries(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
status: int,
|
|
authentication: bool,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
responses: Final = (
|
|
(ResponseSpec(status=status, body={}),) * 2
|
|
if authentication
|
|
else (
|
|
ResponseSpec(body=b"token"),
|
|
ResponseSpec(body={}),
|
|
ResponseSpec(status=status, body={}),
|
|
)
|
|
)
|
|
for response in responses * 2:
|
|
server.enqueue(response)
|
|
server.expected_requests = len(responses) * 2
|
|
reference_manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = await reference_manager.async_write_secret("KEY", "value")
|
|
native_manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = await native_manager.async_write_secret("KEY", "value")
|
|
assert actual == reference
|
|
assert tuple(actual) == tuple(reference)
|
|
assert actual["status"] == "error"
|
|
assert str(status) in actual["message"]
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_cyberark_write_recovers_from_initial_policy_authentication_failure(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.enqueue(ResponseSpec(status=401, body={}))
|
|
server.enqueue(ResponseSpec(body=b"token"))
|
|
server.enqueue(ResponseSpec(body={}))
|
|
server.expected_requests = 3
|
|
manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, rollout)
|
|
assert await manager.async_write_secret("KEY", "value") == {
|
|
"status": "success",
|
|
"message": "Secret KEY written successfully",
|
|
}
|
|
assert tuple(request.path for request in server.requests) == (
|
|
"/authn/account/reader/authenticate",
|
|
"/authn/account/reader/authenticate",
|
|
"/secrets/account/variable/KEY",
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("name", ("../KEY", "line\nKEY", "a\u2028b"))
|
|
async def test_public_cyberark_write_rejects_unsafe_names_before_authentication(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
name: str,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.expected_requests = 0
|
|
manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, rollout)
|
|
assert await manager.async_write_secret(name, "value") == {
|
|
"status": "error",
|
|
"message": f"Invalid secret_name {name!r}",
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("same_name", (False, True))
|
|
async def test_public_cyberark_rotation_returns_the_write_response_and_retains_old_alias(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
same_name: bool,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
for body in (b"token", b"old-value", {}, {}):
|
|
server.enqueue(ResponseSpec(body=body))
|
|
if rollout is Rollout.RUST_REQUIRED:
|
|
server.enqueue(ResponseSpec(body=b"new-value"))
|
|
server.expected_requests = 5 if rollout is Rollout.RUST_REQUIRED else 4
|
|
manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, rollout)
|
|
new_name: Final = "OLD" if same_name else "NEW"
|
|
pending: Final = manager.async_rotate_secret("OLD", new_name, "new-value", {"ignored": object()}, 0)
|
|
assert inspect.iscoroutine(pending)
|
|
assert server.requests == []
|
|
assert await asyncio.create_task(pending) == {
|
|
"status": "success",
|
|
"message": f"Secret {new_name} written successfully",
|
|
}
|
|
assert tuple(request.method for request in server.requests) == (
|
|
("POST", "GET", "POST", "POST", "GET")
|
|
if rollout is Rollout.RUST_REQUIRED
|
|
else ("POST", "GET", "POST", "POST")
|
|
)
|
|
assert server.requests[3].raw_body == b"new-value"
|
|
|
|
|
|
@pytest.mark.parametrize("replacement", (None, b"wrong-value"))
|
|
async def test_public_cyberark_rotation_requires_a_fresh_matching_replacement(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
replacement: bytes | None,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
for body in (b"token", b"old-value", {}, {}):
|
|
server.enqueue(ResponseSpec(body=body))
|
|
server.enqueue(ResponseSpec(status=404 if replacement is None else 200, body=replacement))
|
|
server.expected_requests = 5
|
|
manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
message: Final = "Failed to verify new secret NEW" if replacement is None else "New secret value mismatch"
|
|
with pytest.raises(ValueError, match=message):
|
|
await manager.async_rotate_secret("OLD", "NEW", "new-value")
|
|
assert manager.sync_read_secret("OLD") == "old-value"
|
|
assert tuple(request.path for request in server.requests) == (
|
|
"/authn/account/reader/authenticate",
|
|
"/secrets/account/variable/OLD",
|
|
"/policies/account/policy/root",
|
|
"/secrets/account/variable/NEW",
|
|
"/secrets/account/variable/NEW",
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_cyberark_cached_authentication_does_not_retry_denied_reads(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.enqueue(ResponseSpec(body=b"token"))
|
|
server.enqueue(ResponseSpec(body=b"value"))
|
|
server.enqueue(ResponseSpec(status=401, body={}))
|
|
server.expected_requests = 3
|
|
manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, rollout)
|
|
assert manager.sync_read_secret("OLD") == "value"
|
|
assert await manager.async_read_secret("NEW") is None
|
|
|
|
|
|
async def test_cyberark_handler_errors_match_python_after_cached_authentication_is_denied(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
for response in (
|
|
ResponseSpec(body=b"token"),
|
|
ResponseSpec(body=b"value"),
|
|
ResponseSpec(status=401, body={}),
|
|
) * 2:
|
|
server.enqueue(response)
|
|
server.expected_requests = 6
|
|
reference_manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
python_rules: Final = (SecretManagerRule(Rollout.PYTHON_ONLY),)
|
|
native_rules: Final = (SecretManagerRule(Rollout.RUST_REQUIRED),)
|
|
assert get_secret_from_manager(reference_manager, "cyberark", "OLD", rules=python_rules) == "value"
|
|
with pytest.raises(ValueError, match="No secret found in CyberArk Secret Manager for NEW") as reference:
|
|
get_secret_from_manager(reference_manager, "cyberark", "NEW", rules=python_rules)
|
|
native_manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
assert get_secret_from_manager(native_manager, "cyberark", "OLD", rules=native_rules) == "value"
|
|
with pytest.raises(ValueError, match="No secret found in CyberArk Secret Manager for NEW") as actual:
|
|
get_secret_from_manager(native_manager, "cyberark", "NEW", rules=native_rules)
|
|
assert actual.value.args == reference.value.args
|
|
|
|
|
|
async def test_public_cyberark_connection_errors_match_python(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.expected_requests = 0
|
|
address: Final = server.base_url
|
|
reference_manager: Final = _cyberark(monkeypatch, address)
|
|
_select_cyberark_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = await reference_manager.async_write_secret("KEY", "value")
|
|
native_manager: Final = _cyberark(monkeypatch, address)
|
|
_select_cyberark_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = await native_manager.async_write_secret("KEY", "value")
|
|
assert actual == reference
|
|
assert actual["status"] == "error"
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("operation", ("write", "delete", "rotate"))
|
|
async def test_public_cyberark_mutations_preserve_missing_extension_selection(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
operation: str,
|
|
) -> None:
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(None)
|
|
module: Final = import_module("litellm.secret_managers.cyberark_secret_manager")
|
|
_select_provider_reads(monkeypatch, module.__name__, Rollout.PYTHON_ONLY)
|
|
monkeypatch.setattr(
|
|
module,
|
|
"resolve_native_provider_writer",
|
|
partial(resolve_native_provider_writer, rules=(SecretManagerRule(rollout),), binding=binding),
|
|
)
|
|
with recording_service() as server:
|
|
bodies: Final = (
|
|
()
|
|
if rollout is Rollout.RUST_REQUIRED or operation == "delete"
|
|
else ((b"token", b"old", {}, {}) if operation == "rotate" else (b"token", {}, {}))
|
|
)
|
|
for body in bodies:
|
|
server.enqueue(ResponseSpec(body=body))
|
|
server.expected_requests = len(bodies)
|
|
manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
call: Final = {
|
|
"write": partial(manager.async_write_secret, "KEY", "value"),
|
|
"delete": partial(manager.async_delete_secret, "KEY"),
|
|
"rotate": partial(manager.async_rotate_secret, "OLD", "NEW", "value"),
|
|
}[operation]
|
|
pending: Final = call()
|
|
assert inspect.iscoroutine(pending)
|
|
assert server.requests == []
|
|
if rollout is Rollout.RUST_REQUIRED:
|
|
with pytest.raises(RuntimeError, match="runtime is unavailable"):
|
|
await pending
|
|
else:
|
|
result: Final = await pending
|
|
assert result["status"] == ("not_supported" if operation == "delete" else "success")
|
|
|
|
|
|
async def test_public_cyberark_rotation_stops_after_a_failed_write(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
for body in (b"token", b"old-value", {}):
|
|
server.enqueue(ResponseSpec(body=body))
|
|
server.enqueue(ResponseSpec(status=401, body={}))
|
|
server.expected_requests = 4
|
|
manager: Final = _cyberark(monkeypatch, server.base_url)
|
|
_select_cyberark_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
response: Final = await manager.async_rotate_secret("OLD", "NEW", "new-value")
|
|
assert response["status"] == "error"
|
|
assert "401" in response["message"]
|
|
assert manager.sync_read_secret("OLD") == "old-value"
|
|
assert tuple(request.method for request in server.requests) == ("POST", "GET", "POST", "POST")
|
|
|
|
|
|
def _select_vault_mutations(monkeypatch: pytest.MonkeyPatch, rollout: Rollout) -> None:
|
|
module: Final = import_module("litellm.secret_managers.hashicorp_secret_manager")
|
|
_select_provider_reads(monkeypatch, module.__name__, rollout)
|
|
monkeypatch.setattr(
|
|
module,
|
|
"resolve_native_provider_writer",
|
|
partial(resolve_native_provider_writer, rules=(SecretManagerRule(rollout),)),
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("description", (None, "", "purpose"))
|
|
async def test_public_vault_writes_preserve_complete_responses_and_request_fields(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
description: str | None,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
response: Final = {
|
|
"request_id": "test-request",
|
|
"data": {"version": 2, "custom_metadata": {"large": 2**100}},
|
|
"warnings": ["test-warning"],
|
|
"unknown_field": {"nested": [None, True, ""]},
|
|
}
|
|
server.enqueue(ResponseSpec(body=response))
|
|
server.expected_requests = 1
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, rollout)
|
|
options: Final = {
|
|
"secret_manager_settings": {"namespace": "team", "mount": "kv", "path_prefix": "app", "data": "token"}
|
|
}
|
|
pending: Final = manager.async_write_secret("KEY", "value", description, options, 2, {"ignored": object()})
|
|
assert inspect.iscoroutine(pending)
|
|
assert server.requests == []
|
|
result: Final = await asyncio.create_task(pending)
|
|
assert result == response
|
|
assert tuple(result) == tuple(response)
|
|
request: Final = server.requests[0]
|
|
assert request.method == "POST"
|
|
assert request.headers["x-vault-token"] == "token"
|
|
namespace: Final = request.headers.get("x-vault-namespace")
|
|
assert request.path == ("/v1/kv/data/app/KEY" if namespace else "/v1/team/kv/data/app/KEY")
|
|
assert namespace in (None, "team")
|
|
assert json.loads(request.raw_body) == {
|
|
"data": {"token": "value", **({"description": description} if description else {})},
|
|
}
|
|
assert options == {
|
|
"secret_manager_settings": {"namespace": "team", "mount": "kv", "path_prefix": "app", "data": "token"}
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize("operation", ("write", "delete"))
|
|
@pytest.mark.parametrize("status", (400, 403, 500))
|
|
async def test_public_vault_mutation_http_errors_match_python_without_retry(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
operation: str,
|
|
status: int,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(status=status, body={"errors": ["denied"]})
|
|
server.expected_requests = 2
|
|
options: Final = {"namespace": "team", "mount": "kv", "path_prefix": "prefix"}
|
|
reference_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = (
|
|
await reference_manager.async_write_secret("KEY", "value", optional_params=options)
|
|
if operation == "write"
|
|
else await reference_manager.async_delete_secret("KEY", optional_params=options)
|
|
)
|
|
native_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = (
|
|
await native_manager.async_write_secret("KEY", "value", optional_params=options)
|
|
if operation == "write"
|
|
else await native_manager.async_delete_secret("KEY", optional_params=options)
|
|
)
|
|
assert actual == reference
|
|
assert tuple(actual) == tuple(reference)
|
|
assert actual["status"] == "error"
|
|
assert str(status) in actual["message"]
|
|
|
|
|
|
@pytest.mark.parametrize("body", (b"{", b"", b"null", b"[1,2]", b'{"large":1267650600228229401496703205376}'))
|
|
async def test_public_vault_write_response_conversion_matches_python(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
body: bytes,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body=body)
|
|
server.expected_requests = 2
|
|
reference_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = await reference_manager.async_write_secret("KEY", "value")
|
|
native_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = await native_manager.async_write_secret("KEY", "value")
|
|
assert type(actual) is type(reference)
|
|
assert actual == reference
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
async def test_public_vault_deletion_invalidates_cached_fields(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.enqueue(ResponseSpec(body=_vault_body("old")))
|
|
server.enqueue(ResponseSpec(status=204, body=b""))
|
|
server.enqueue(ResponseSpec(body=_vault_body("after-delete")))
|
|
server.expected_requests = 3
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, rollout)
|
|
assert manager.sync_read_secret("KEY") == "old"
|
|
pending: Final = manager.async_delete_secret("KEY", None, {"ignored": object()}, 2)
|
|
assert inspect.iscoroutine(pending)
|
|
assert len(server.requests) == 1
|
|
assert await asyncio.create_task(pending) == {"status": "success", "message": "Secret KEY deleted successfully"}
|
|
assert await manager.async_read_secret("KEY") == "after-delete"
|
|
assert tuple(request.method for request in server.requests) == ("GET", "DELETE", "GET")
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("same_name", (False, True))
|
|
@pytest.mark.parametrize("delete_status", (204, 403))
|
|
async def test_public_vault_rotation_preserves_response_and_best_effort_deletion(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
same_name: bool,
|
|
delete_status: int,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
response: Final = {"request_id": "write-id", "data": {"version": 3}, "extra": [1, 2]}
|
|
server.enqueue(ResponseSpec(body=b"current-existence-is-status-only"))
|
|
server.enqueue(ResponseSpec(body=response))
|
|
server.enqueue(ResponseSpec(body=_vault_body("replacement")))
|
|
if not same_name:
|
|
server.enqueue(ResponseSpec(status=delete_status, body=b""))
|
|
server.expected_requests = 3 if same_name else 4
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, rollout)
|
|
new_name: Final = "OLD" if same_name else "NEW"
|
|
pending: Final = manager.async_rotate_secret("OLD", new_name, "replacement", timeout=2)
|
|
assert inspect.iscoroutine(pending)
|
|
assert server.requests == []
|
|
assert await asyncio.create_task(pending) == response
|
|
assert tuple(request.method for request in server.requests) == (
|
|
("GET", "POST", "GET") if same_name else ("GET", "POST", "GET", "DELETE")
|
|
)
|
|
assert json.loads(server.requests[1].raw_body) == {
|
|
"data": {"key": "replacement", "description": "Rotated from OLD"},
|
|
}
|
|
assert urlsplit(server.requests[2].path).path == f"/v1/secret/data/{new_name}"
|
|
|
|
|
|
@pytest.mark.parametrize("stage", ("current", "write", "verify"))
|
|
@pytest.mark.parametrize("status", (404, 403, 500))
|
|
async def test_public_vault_rotation_failure_messages_and_request_counts_match_python(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
stage: str,
|
|
status: int,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
before: Final = (
|
|
()
|
|
if stage == "current"
|
|
else (
|
|
(ResponseSpec(body=_vault_body("old")),)
|
|
if stage == "write"
|
|
else (
|
|
ResponseSpec(body=_vault_body("old")),
|
|
ResponseSpec(body={"data": {"version": 2}}),
|
|
)
|
|
)
|
|
)
|
|
responses: Final = (*before, ResponseSpec(status=status, body={"errors": ["denied"]}))
|
|
for response in responses * 2:
|
|
server.enqueue(response)
|
|
server.expected_requests = len(responses) * 2
|
|
reference_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = await reference_manager.async_rotate_secret("OLD", "NEW", "value")
|
|
native_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = await native_manager.async_rotate_secret("OLD", "NEW", "value")
|
|
assert actual == reference
|
|
assert actual["status"] == "error"
|
|
expected_paths: Final = (
|
|
("/v1/secret/data/OLD",)
|
|
+ (("/v1/secret/data/NEW",) if stage != "current" else ())
|
|
+ (("/v1/secret/data/NEW",) if stage == "verify" else ())
|
|
)
|
|
assert tuple(urlsplit(request.path).path for request in server.requests) == expected_paths * 2
|
|
|
|
|
|
@pytest.mark.parametrize("value", (None, "different", True, 42, 2**100, [1, "two"], [2**100], {"nested": 2**100}))
|
|
async def test_public_vault_rotation_mismatches_do_not_delete_the_old_alias(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
value: JsonValue,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
responses: Final = (
|
|
ResponseSpec(body=_vault_body("old")),
|
|
ResponseSpec(body={"data": {"version": 2}}),
|
|
ResponseSpec(body={"data": {"data": {"key": value}}}),
|
|
)
|
|
for response in responses * 2:
|
|
server.enqueue(response)
|
|
server.expected_requests = 6
|
|
reference_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = await reference_manager.async_rotate_secret("OLD", "NEW", "value")
|
|
native_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = await native_manager.async_rotate_secret("OLD", "NEW", "value")
|
|
assert actual == reference
|
|
assert actual["status"] == "error"
|
|
assert all(request.method != "DELETE" for request in server.requests)
|
|
|
|
|
|
@pytest.mark.parametrize("operation", ("write", "delete", "rotate"))
|
|
async def test_public_vault_mutation_timeouts_match_python(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
operation: str,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body=_vault_body("value"), delay=0.25)
|
|
server.expected_requests = 2
|
|
reference_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = await {
|
|
"write": partial(reference_manager.async_write_secret, "KEY", "value"),
|
|
"delete": partial(reference_manager.async_delete_secret, "KEY"),
|
|
"rotate": partial(reference_manager.async_rotate_secret, "OLD", "NEW", "value"),
|
|
}[operation](timeout=0.05)
|
|
native_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = await {
|
|
"write": partial(native_manager.async_write_secret, "KEY", "value"),
|
|
"delete": partial(native_manager.async_delete_secret, "KEY"),
|
|
"rotate": partial(native_manager.async_rotate_secret, "OLD", "NEW", "value"),
|
|
}[operation](timeout=0.05)
|
|
if operation == "write":
|
|
assert isinstance(actual["message"], str)
|
|
assert isinstance(reference["message"], str)
|
|
pattern: Final = r"time taken=(\d+(?:\.\d+)?) seconds"
|
|
assert re.sub(pattern, "time taken=<elapsed> seconds", actual["message"]) == re.sub(
|
|
pattern,
|
|
"time taken=<elapsed> seconds",
|
|
reference["message"],
|
|
)
|
|
elapsed: Final = re.search(pattern, actual["message"])
|
|
assert elapsed is not None
|
|
assert float(elapsed[1]) >= 0.05
|
|
else:
|
|
assert actual == reference
|
|
assert actual["status"] == "error"
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("operation", ("write", "delete", "rotate"))
|
|
async def test_public_vault_unsafe_names_fail_before_authentication(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
operation: str,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.expected_requests = 0
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, rollout)
|
|
result: Final = await {
|
|
"write": partial(manager.async_write_secret, "../KEY", "value"),
|
|
"delete": partial(manager.async_delete_secret, "../KEY"),
|
|
"rotate": partial(manager.async_rotate_secret, "../KEY", "NEW", "value"),
|
|
}[operation]()
|
|
assert result == {"status": "error", "message": "Invalid secret_name '../KEY'"}
|
|
|
|
|
|
@pytest.mark.parametrize("operation", ("write", "delete", "rotate"))
|
|
async def test_public_vault_authentication_errors_match_python(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
operation: str,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
monkeypatch.setenv("HCP_VAULT_APPROLE_ROLE_ID", "role")
|
|
monkeypatch.setenv("HCP_VAULT_APPROLE_SECRET_ID", "secret-id")
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(status=403, body={"errors": ["denied"]})
|
|
server.expected_requests = 2
|
|
reference_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = await {
|
|
"write": partial(reference_manager.async_write_secret, "KEY", "value"),
|
|
"delete": partial(reference_manager.async_delete_secret, "KEY"),
|
|
"rotate": partial(reference_manager.async_rotate_secret, "OLD", "NEW", "value"),
|
|
}[operation]()
|
|
native_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = await {
|
|
"write": partial(native_manager.async_write_secret, "KEY", "value"),
|
|
"delete": partial(native_manager.async_delete_secret, "KEY"),
|
|
"rotate": partial(native_manager.async_rotate_secret, "OLD", "NEW", "value"),
|
|
}[operation]()
|
|
assert actual == reference
|
|
assert actual["status"] == "error"
|
|
assert tuple(request.path for request in server.requests) == ("/v1/auth/approle/login",) * 2
|
|
|
|
|
|
async def test_public_vault_rotation_stops_on_a_success_response_containing_an_error(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
result: Final = {"status": "error", "message": "write rejected", "extra": 2**100}
|
|
for response in (ResponseSpec(body=_vault_body("old")), ResponseSpec(body=result)) * 2:
|
|
server.enqueue(response)
|
|
server.expected_requests = 4
|
|
reference_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = await reference_manager.async_rotate_secret("OLD", "NEW", "value")
|
|
native_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = await native_manager.async_rotate_secret("OLD", "NEW", "value")
|
|
assert actual == reference == result
|
|
assert tuple(request.method for request in server.requests) == ("GET", "POST", "GET", "POST")
|
|
|
|
|
|
async def test_public_native_vault_write_invalidates_stale_cached_values(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.enqueue(ResponseSpec(body=_vault_body("old")))
|
|
server.enqueue(ResponseSpec(body={"data": {"version": 2}}))
|
|
server.enqueue(ResponseSpec(body=_vault_body("new")))
|
|
server.expected_requests = 3
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
assert manager.sync_read_secret("KEY") == "old"
|
|
assert await manager.async_write_secret("KEY", "new") == {"data": {"version": 2}}
|
|
assert manager.sync_read_secret("KEY") == "new"
|
|
assert tuple(request.method for request in server.requests) == ("GET", "POST", "GET")
|
|
|
|
|
|
async def test_public_native_vault_write_rejects_description_overwriting_the_secret(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
server.expected_requests = 0
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
assert await manager.async_write_secret("KEY", "value", "description", {"data": "description"}) == {
|
|
"status": "error",
|
|
"message": "HashiCorp Vault data key conflicts with description",
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize("rollout", (Rollout.PYTHON_ONLY, Rollout.RUST_REQUIRED))
|
|
@pytest.mark.parametrize("operation", ("write", "delete", "rotate"))
|
|
async def test_public_vault_mutations_preserve_missing_extension_selection(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
rollout: Rollout,
|
|
operation: str,
|
|
) -> None:
|
|
binding: Final[NativeBinding[NativeSecretManagerFactory]] = NativeBinding("unused", validate=lambda value: None)
|
|
binding.override(None)
|
|
module: Final = import_module("litellm.secret_managers.hashicorp_secret_manager")
|
|
_select_provider_reads(monkeypatch, module.__name__, Rollout.PYTHON_ONLY)
|
|
monkeypatch.setattr(
|
|
module,
|
|
"resolve_native_provider_writer",
|
|
partial(resolve_native_provider_writer, rules=(SecretManagerRule(rollout),), binding=binding),
|
|
)
|
|
with recording_service() as server:
|
|
server.default_response = ResponseSpec(body=_vault_body("value"))
|
|
server.expected_requests = 0 if rollout is Rollout.RUST_REQUIRED else (4 if operation == "rotate" else 1)
|
|
manager: Final = _vault(monkeypatch, server.base_url)
|
|
pending: Final = {
|
|
"write": partial(manager.async_write_secret, "KEY", "value"),
|
|
"delete": partial(manager.async_delete_secret, "KEY"),
|
|
"rotate": partial(manager.async_rotate_secret, "OLD", "NEW", "value"),
|
|
}[operation]()
|
|
assert inspect.iscoroutine(pending)
|
|
assert server.requests == []
|
|
if rollout is Rollout.RUST_REQUIRED:
|
|
with pytest.raises(RuntimeError, match="runtime is unavailable"):
|
|
await pending
|
|
else:
|
|
result: Final = await pending
|
|
assert result == (
|
|
{"status": "success", "message": "Secret KEY deleted successfully"}
|
|
if operation == "delete"
|
|
else _vault_body("value")
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"body", (None, [], 42, 2**100, {"data": 2**100}, {"data": None}, {"data": {"data": []}}, {}, {"data": {}})
|
|
)
|
|
async def test_public_vault_rotation_preserves_malformed_verification_errors(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
body: JsonValue,
|
|
) -> None:
|
|
pytest.importorskip("litellm.rust_bridge._native")
|
|
with recording_service() as server:
|
|
responses: Final = (
|
|
ResponseSpec(body=_vault_body("old")),
|
|
ResponseSpec(body={"data": {"version": 2}}),
|
|
ResponseSpec(body=body),
|
|
)
|
|
for response in responses * 2:
|
|
server.enqueue(response)
|
|
server.expected_requests = 6
|
|
reference_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.PYTHON_ONLY)
|
|
reference: Final = await reference_manager.async_rotate_secret("OLD", "NEW", "value")
|
|
native_manager: Final = _vault(monkeypatch, server.base_url)
|
|
_select_vault_mutations(monkeypatch, Rollout.RUST_REQUIRED)
|
|
actual: Final = await native_manager.async_rotate_secret("OLD", "NEW", "value")
|
|
assert actual == reference
|
|
assert actual["status"] == "error"
|
|
assert all(request.method != "DELETE" for request in server.requests)
|