litellm/tests/unit/integrations/test_prometheus_metrics_endpoint.py
yuneng-jiang cf491d1df9
test: move tests/test_litellm integrations and secret_managers into tests/unit (#43194)
* ci: run the unit_selection.sh shard files on every event instead of only fork pull requests

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* ci: rename fork-flag to unit-flag now that it applies on every event

* test: move tests/test_litellm root and small trees into tests/unit

Pure renames, no content changes. Follow-up commits in this PR fix
references, merge the three files that already existed in tests/unit,
keep live-provider tests in tests/test_litellm and wire CI.

* test: carry tests/test_litellm conftest isolation into tests/unit

Callback lists, routing fallbacks, cached HTTP clients, logger state, AWS,
proxy-URL and keychain env, and session-end client cleanup now reset for
unit tests too. The environment isolation owns its MonkeyPatch so a test's
own monkeypatch is undone before the model-cost teardown runs.

* test: merge, split and prune the moved root and small-tree tests

Merge batches/test_batch_utils.py and the chat_completions and messages
dispatch tests into the files that already existed in tests/unit. Keep
the live Gemini interactions tests, the async image-fetch format test and
the OpenAI embedding scorer test in tests/test_litellm since they need
real network or keys. Put test_router.py under tests/unit/test_router so
the existing package no longer shadows it. Delete eight tests the audit
found superseded by stronger ones kept in this move.

* ci: run the moved root and small-tree tests under their legacy flags

Add the misc and responses-caching-types flags to unit_selection.sh and
CircleCI, extend enterprise-routing and mcp-integration, and point the
legacy GHA shards, Makefile, redis-compat workflow, merge smoke manifest
and change classifier at the new paths.

* test: make the new tests/unit directories packages

tests/unit/test_package_layout.py requires every directory to carry an
__init__.py, and without one the moved and retained
test_litellm_responses_bridge.py modules collide on import.

* test: scope the unit socket block to tests/unit in shared sessions

The GHA shards collect the legacy test-path and the unit selection in one
pytest session. The unit conftest's loopback-only block leaked into legacy
modules that reach the network at import. The legacy conftest now lifts the
restriction at collect and setup time, and the unit conftest re-applies it
when collecting its own modules.

* test: move tests/test_litellm/llms into tests/unit/llms

Rename-only. Moves the provider tests and the fine-tuning fixtures they
load, mirroring the old paths. Follow-up commits merge, split and wire them.

* test: merge, split and prune the moved llms tests

Merges the Databricks chat transformation tests into the existing unit
file, keeps the tests that need real keys or the network in
tests/test_litellm, deletes the audited tests a stronger unit test
already covers, and points imports at tests.unit.llms.

* ci: run the moved llms tests under their legacy flags

The Vertex AI and All Other Providers shards keep their legacy test-path
for the retained files and add the llm-vertex-ai and llm-other-providers
unit selections. CircleCI gets matching unit jobs.

* test: make the tests/unit/llms directories packages

Adds __init__.py to the moved dirs and drops the legacy ones whose
directories no longer hold tests.

* test: drop script runners and path hacks the llms split left dangling

The __main__ runners in the split openai_like files and the Databricks e2e
runner called tests that now live in the other half of the split or were
deleted. The retained legacy halves also no longer need sys.path edits.

* test: give the shard-script tests their own GITHUB_OUTPUT

They only passed where the runner set it. The CircleCI unit job's env
allowlist drops it, so the script's redirect failed there.

* test: point the router and module-deletion checks at tests/unit

router_code_coverage and code_qa_check_tests only searched tests/test_litellm,
so the moved router tests no longer counted. The two silent-experiment tests
the audit deleted were the only direct callers of those methods; they are
replaced with tests that assert the forwarded shadow request and the
recursion guard.

* test: move tests/test_litellm integrations and secret_managers into tests/unit

Rename-only. Mirrors the old paths, including the directory conftests
and the prompt and JSON fixtures. Follow-up commits prune and wire them.

* test: prune and repoint the moved integrations tests

Deletes the 7 audited tests a stronger test in the same tree already
covers, imports the TLS sink helpers from their new conftest path, and
restores os.environ after each integrations test. Some presets write
OTEL_EXPORTER_OTLP_HEADERS straight into os.environ, and without the
legacy tree's test ordering that header leaked into the AgentOps tests.

* ci: run the moved integrations tests under their legacy flag

The integrations GHA shard and a new CircleCI job run the integrations
unit selection. secret_managers joins the misc selection.

* docs: point integrations and secret_managers references at tests/unit

* test: make the moved integrations directories packages

* test: keep the Databricks manual e2e runner and fix the SageMaker Nova run path

The Databricks e2e file is a manual script whose main() calls the tests
that were pruned, so pruning them broke the documented run. It is back to
its main version. The SageMaker Nova docstring now points at the file's
real location in tests/local_testing.

* test: keep the job's UNIT_FLAG out of the shard-script tests

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-09-25 12:57:07 -07:00

276 lines
9.9 KiB
Python

"""The /metrics app must render off the event loop, coalesce concurrent scrapes and stream chunks."""
from __future__ import annotations
import asyncio
import threading
import time
from collections.abc import Iterator, Mapping, Sequence
from typing import Final
import httpx
import pytest
from prometheus_client import CollectorRegistry, Gauge
from prometheus_client.metrics_core import GaugeMetricFamily
from prometheus_client.registry import Collector
from litellm.integrations.prometheus_metrics_endpoint import (
RESPONSE_CHUNK_SIZE_BYTES,
make_metrics_asgi_app,
)
_GATE_TIMEOUT_SECONDS: Final = 10.0
_SECOND_SCRAPE_SETTLE_SECONDS: Final = 0.2
class _SlowCollector(Collector):
"""Blocking collector standing in for a large registry render."""
def __init__(self, block_seconds: float, sample_count: int = 1) -> None:
self.block_seconds = block_seconds
self.sample_count = sample_count
self.collect_calls = 0
def collect(self) -> Iterator[GaugeMetricFamily]:
self.collect_calls += 1
time.sleep(self.block_seconds)
family: Final = GaugeMetricFamily("slow_metric", "slow", labels=("idx",))
for idx in range(self.sample_count):
family.add_metric((str(idx),), 1.0)
yield family
def _client(registry: CollectorRegistry) -> httpx.AsyncClient:
return httpx.AsyncClient(
transport=httpx.ASGITransport(app=make_metrics_asgi_app(registry)),
base_url="http://metrics.test",
)
def _registry_with(collector: Collector) -> CollectorRegistry:
registry: Final = CollectorRegistry()
registry.register(collector)
return registry
async def _scrape(client: httpx.AsyncClient, headers: Mapping[str, str] | None = None) -> httpx.Response:
return await client.get("/metrics", headers=headers)
@pytest.mark.asyncio
async def test_render_does_not_block_the_event_loop():
ticks: Final[list[float]] = [] # mutable-ok: records loop wakeups while the scrape is in flight
async def ticker() -> None:
while True:
await asyncio.sleep(0.01)
ticks.append(time.monotonic())
ticker_task: Final = asyncio.create_task(ticker())
async with _client(_registry_with(_SlowCollector(block_seconds=0.5))) as client:
try:
response: Final = await _scrape(client)
finally:
ticker_task.cancel()
assert b"slow_metric" in response.content
assert len(ticks) > 5, "event loop was blocked while the registry was rendered"
@pytest.mark.asyncio
async def test_concurrent_identical_scrapes_share_one_render():
collector: Final = _SlowCollector(block_seconds=0.2)
async with _client(_registry_with(collector)) as client:
responses: Final[Sequence[httpx.Response]] = await asyncio.gather(*(_scrape(client) for _ in range(5)))
assert collector.collect_calls == 1
for response in responses:
assert b"slow_metric" in response.content
@pytest.mark.asyncio
async def test_sequential_scrapes_are_rendered_fresh():
collector: Final = _SlowCollector(block_seconds=0.0)
async with _client(_registry_with(collector)) as client:
await _scrape(client)
await _scrape(client)
assert collector.collect_calls == 2
@pytest.mark.asyncio
async def test_gzip_is_used_when_the_scraper_accepts_it():
registry: Final = CollectorRegistry()
Gauge("plain_metric", "plain", registry=registry).set(1)
async with _client(registry) as client:
compressed: Final = await _scrape(client, headers={"accept-encoding": "gzip"})
plain: Final = await _scrape(client, headers={"accept-encoding": "identity"})
assert compressed.headers["content-encoding"] == "gzip"
assert "content-encoding" not in plain.headers
assert compressed.content == plain.content
assert b"plain_metric" in plain.content
@pytest.mark.asyncio
async def test_name_filter_restricts_the_rendered_registry():
registry: Final = CollectorRegistry()
Gauge("wanted_metric", "wanted", registry=registry).set(1)
Gauge("other_metric", "other", registry=registry).set(1)
async with _client(registry) as client:
response: Final = await client.get("/metrics", params={"name[]": "wanted_metric"})
assert b"wanted_metric" in response.content
assert b"other_metric" not in response.content
@pytest.mark.asyncio
async def test_large_payload_is_streamed_in_chunks():
registry: Final = _registry_with(_SlowCollector(block_seconds=0.0, sample_count=5000))
chunk_sizes: Final[list[int]] = [] # mutable-ok: records the ASGI body parts the app emitted
async def send(message: Mapping[str, object]) -> None:
if message["type"] == "http.response.body":
body = message["body"]
assert isinstance(body, bytes)
chunk_sizes.append(len(body))
incoming: Final = iter(({"type": "http.request", "body": b"", "more_body": False},))
async def receive() -> Mapping[str, object]:
request: Final = next(incoming, None)
if request is not None:
return request
await asyncio.Event().wait()
return {"type": "http.disconnect"}
app: Final = make_metrics_asgi_app(registry)
await app(
{
"type": "http",
"method": "GET",
"path": "/metrics",
"headers": (),
"query_string": b"",
},
receive,
send,
)
assert sum(chunk_sizes) > RESPONSE_CHUNK_SIZE_BYTES
assert len(chunk_sizes) > 2
assert max(chunk_sizes) <= RESPONSE_CHUNK_SIZE_BYTES
class _GatedCollector(Collector):
"""Blocking collector that parks in the worker thread until the test releases it."""
def __init__(self) -> None:
self.started = threading.Event()
self.release = threading.Event()
self._lock = threading.Lock()
self.collect_calls = 0
def collect(self) -> Iterator[GaugeMetricFamily]:
with self._lock:
self.collect_calls += 1
self.started.set()
self.release.wait(timeout=_GATE_TIMEOUT_SECONDS)
family: Final = GaugeMetricFamily("gated_metric", "gated")
family.add_metric((), 1.0)
yield family
async def _scrape_pair_concurrently(
registry: CollectorRegistry, collector: _GatedCollector, headers: Sequence[Mapping[str, str]]
) -> Sequence[httpx.Response]:
"""Issue the second scrape only once the first one's render is parked inside the worker thread."""
async with _client(registry) as client:
try:
first: Final = asyncio.create_task(_scrape(client, headers=headers[0]))
assert await asyncio.to_thread(collector.started.wait, _GATE_TIMEOUT_SECONDS), "first render never started"
second: Final = asyncio.create_task(_scrape(client, headers=headers[1]))
await asyncio.sleep(_SECOND_SCRAPE_SETTLE_SECONDS)
collector.release.set()
return await asyncio.gather(first, second)
finally:
collector.release.set()
@pytest.mark.parametrize("reverse", (False, True), ids=("as-listed", "reversed"))
@pytest.mark.parametrize(
"spellings",
(
({"accept-encoding": "gzip"}, {"accept-encoding": "gzip, deflate"}),
({"accept": "*/*"}, {"accept": "text/plain;version=0.0.4;q=0.5,*/*;q=0.1"}),
),
ids=("accept-encoding", "accept"),
)
@pytest.mark.asyncio
async def test_header_spellings_with_the_same_output_share_one_render(
spellings: Sequence[Mapping[str, str]], reverse: bool
):
collector: Final = _GatedCollector()
ordered: Final = tuple(reversed(spellings)) if reverse else spellings
responses: Final = await _scrape_pair_concurrently(_registry_with(collector), collector, ordered)
assert collector.collect_calls == 1, "the second scrape rendered the registry again instead of joining the first"
for response in responses:
assert b"gated_metric" in response.content
@pytest.mark.asyncio
async def test_different_output_formats_are_rendered_separately():
collector: Final = _GatedCollector()
responses: Final = await _scrape_pair_concurrently(
_registry_with(collector),
collector,
({"accept": "text/plain"}, {"accept": "application/openmetrics-text"}),
)
assert collector.collect_calls == 2, "scrapes wanting different exposition formats must not share a render"
assert responses[0].headers["content-type"] != responses[1].headers["content-type"]
@pytest.mark.asyncio
async def test_concurrent_gzip_and_plain_scrapes_each_get_their_own_encoding():
collector: Final = _GatedCollector()
responses: Final = await _scrape_pair_concurrently(
_registry_with(collector),
collector,
({"accept-encoding": "gzip"}, {"accept-encoding": "identity"}),
)
assert collector.collect_calls == 2, "scrapes wanting different content encodings must not share a render"
assert responses[0].headers["content-encoding"] == "gzip"
assert "content-encoding" not in responses[1].headers
for response in responses:
assert b"gated_metric" in response.content
@pytest.mark.asyncio
async def test_a_finishing_render_does_not_evict_another_that_is_still_in_flight():
collector: Final = _GatedCollector()
async with _client(_registry_with(collector)) as client:
try:
parked: Final = asyncio.create_task(_scrape(client))
assert await asyncio.to_thread(collector.started.wait, _GATE_TIMEOUT_SECONDS), "first render never started"
unrelated: Final = await client.get("/metrics", params={"name[]": "no_such_metric"})
assert unrelated.status_code == 200
joiner: Final = asyncio.create_task(_scrape(client))
await asyncio.sleep(_SECOND_SCRAPE_SETTLE_SECONDS)
collector.release.set()
responses: Final = await asyncio.gather(parked, joiner)
finally:
collector.release.set()
assert collector.collect_calls == 1, "an unrelated render finishing evicted the render still in flight"
for response in responses:
assert b"gated_metric" in response.content