mirror of
https://github.com/BerriAI/litellm.git
synced 2026-10-11 03:38:38 +00:00
* fix(tracing): use ClickHouse URL for reads by default * fix(tracing): unify ClickHouse storage configuration * fix(tracing): update dashboard setup copy for one URL * test(tracing): make tests/unit/tracing a package Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * refactor(config): drop legacy string tracing store variant Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix(tracing): own ClickHouse defaults in constants and reject unset env references Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * test(tracing): use raw regex patterns in config tests Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix(tracing): read ClickHouse env defaults when tracing config resolves Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix(ui): split audit log query guard to fit condition-chain budget Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
116 lines
4.6 KiB
Python
116 lines
4.6 KiB
Python
import pytest
|
|
|
|
from litellm import constants
|
|
from litellm.tracing.config import is_clickhouse_tracing_enabled, trace_storage_config
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("settings", "enabled"),
|
|
[
|
|
({"store": "clickhouse"}, False),
|
|
({"store": {"type": "clickhouse"}}, True),
|
|
({"store": {"type": "other"}}, False),
|
|
(None, False),
|
|
],
|
|
)
|
|
def test_clickhouse_tracing_enablement(settings: object, enabled: bool) -> None:
|
|
assert is_clickhouse_tracing_enabled(settings) is enabled
|
|
|
|
|
|
def test_yaml_values_override_defaults_and_resolve_nested_references() -> None:
|
|
config = trace_storage_config(
|
|
{
|
|
"store": {
|
|
"type": "clickhouse",
|
|
"url": "os.environ/TRACING_URL",
|
|
"database": "os.environ/TRACING_DATABASE",
|
|
"retention_days": "os.environ/TRACING_RETENTION_DAYS",
|
|
},
|
|
},
|
|
{
|
|
"TRACING_URL": "https://writer:password@clickhouse.example:8443",
|
|
"TRACING_DATABASE": "analytics",
|
|
"TRACING_RETENTION_DAYS": "7",
|
|
"CLICKHOUSE_URL": "https://other.example:8443",
|
|
},
|
|
)
|
|
assert config.url == "https://writer:password@clickhouse.example:8443"
|
|
assert config.database == "analytics"
|
|
assert config.retention_days == 7
|
|
assert "password" not in repr(config)
|
|
|
|
|
|
def test_omitted_fields_use_environment() -> None:
|
|
config = trace_storage_config(
|
|
{},
|
|
{
|
|
"CLICKHOUSE_URL": "http://localhost:8123",
|
|
"CLICKHOUSE_DATABASE": "env_database",
|
|
"AGENT_TRACING_RETENTION_DAYS": "11",
|
|
},
|
|
)
|
|
assert (config.url, config.database, config.retention_days) == ("http://localhost:8123", "env_database", 11)
|
|
|
|
|
|
def test_environment_is_read_when_config_is_resolved(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setenv("CLICKHOUSE_URL", "http://localhost:8123")
|
|
monkeypatch.setenv("CLICKHOUSE_DATABASE", "late_database")
|
|
monkeypatch.setenv("AGENT_TRACING_RETENTION_DAYS", "9")
|
|
config = trace_storage_config({})
|
|
assert (config.database, config.retention_days) == ("late_database", 9)
|
|
|
|
|
|
def test_omitted_fields_without_environment_use_constant_defaults() -> None:
|
|
config = trace_storage_config({}, {"CLICKHOUSE_URL": "http://localhost:8123"})
|
|
assert (config.database, config.retention_days) == (
|
|
constants.DEFAULT_CLICKHOUSE_DATABASE,
|
|
constants.DEFAULT_AGENT_TRACING_RETENTION_DAYS,
|
|
)
|
|
assert (config.database, config.retention_days) == ("litellm", 14)
|
|
|
|
|
|
@pytest.mark.parametrize("field", ["url", "database", "retention_days"])
|
|
def test_unset_environment_reference_does_not_fall_back(field: str) -> None:
|
|
store: dict[str, object] = {"type": "clickhouse", "url": "http://localhost:8123", field: "os.environ/MISSING"}
|
|
with pytest.raises(ValueError, match=rf"tracing.store.{field} is set but resolved to no value") as error:
|
|
trace_storage_config({"store": store}, {"CLICKHOUSE_URL": "http://fallback:8123"})
|
|
assert "MISSING" not in str(error.value)
|
|
|
|
|
|
@pytest.mark.parametrize("store", ["clickhouse", {"type": "other"}])
|
|
def test_non_clickhouse_store_is_rejected(store: object) -> None:
|
|
with pytest.raises(ValueError, match=r"tracing\.store\.type must be clickhouse"):
|
|
trace_storage_config({"store": store}, {"CLICKHOUSE_URL": "http://localhost:8123"})
|
|
|
|
|
|
def test_non_string_database_is_rejected() -> None:
|
|
with pytest.raises(ValueError, match=r"tracing\.store\.database must be a string"):
|
|
trace_storage_config({"store": {"type": "clickhouse", "url": "http://localhost:8123", "database": 1}}, {})
|
|
|
|
|
|
@pytest.mark.parametrize("value", [0, -1, True, "not-a-number", 2**32])
|
|
def test_invalid_retention_is_rejected(value: object) -> None:
|
|
with pytest.raises(ValueError, match=r"tracing.store.retention_days must be a positive integer"):
|
|
trace_storage_config(
|
|
{"store": {"type": "clickhouse", "url": "http://localhost:8123", "retention_days": value}}, {}
|
|
)
|
|
|
|
|
|
def test_missing_url_is_rejected() -> None:
|
|
with pytest.raises(ValueError, match=r"tracing.store.url or CLICKHOUSE_URL is required"):
|
|
trace_storage_config({"store": {"type": "clickhouse"}}, {})
|
|
|
|
|
|
def test_legacy_reader_and_split_retention_fields_are_rejected() -> None:
|
|
with pytest.raises(ValueError, match="reader_url, trace_retention_days"):
|
|
trace_storage_config(
|
|
{
|
|
"store": {
|
|
"type": "clickhouse",
|
|
"url": "http://localhost:8123",
|
|
"reader_url": "http://localhost:8124",
|
|
"trace_retention_days": 30,
|
|
}
|
|
},
|
|
{},
|
|
)
|