mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-22 00:31:44 +00:00
a1f0ef2a99
Address the Greptile concern that basic_messaging_streaming and basic_messaging_non_streaming used the same implementation, so a proxy that buffered the upstream stream would silently show green for the streaming row. The fix: - _basic_messaging.run_basic_messaging_cell accepts verify_streaming=True, which passes --include-partial-messages to the claude CLI. That flag causes the CLI to emit one stream_event record per upstream SSE event (message_start, content_block_delta, message_stop, ...). A buffering proxy collapses the stream to a single non-streaming response, so zero stream_event records are emitted. - The cell rejects any model whose stream_event count is below MIN_STREAM_DELTA_EVENTS (2) -- safely above the buffered case for any non-trivial reply. Same all-must-pass shape as the existing tool_use_streaming row. - All five basic_messaging_streaming/test_*.py per-provider cells now pass verify_streaming=True; the non-streaming variants are unchanged. - New unit tests cover the helper, the partial-messages flag wiring, the streamed/buffered branching, and the all-models-must-stream contract. Co-authored-by: Cursor Agent <cursoragent@cursor.com> |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| conftest.py | ||
| test_basic_messaging.py | ||
| test_cli_driver.py | ||
| test_compat_result.py | ||
| test_rate_limiter.py | ||