mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-14 23:21:35 +00:00
8b5913bd35
Bug 1: `triage_with_llm.py` and `close_low_quality_prs.py` each defined their own copies of `extract_greptile_score`, `parse_iso8601`, `GREPTILE_BOT_LOGINS`, `SCORE_PATTERN`, `GRACE_COMMENT_MARKER`, `GRACE_PERIOD_SECONDS`, `IMMEDIATE_CLOSE_LOGINS`, and `AGENT_SHIN_DEFAULT_BOT_LOGIN`. The comments explicitly said the two copies had to stay in sync, but nothing enforced it. A future change to one (e.g. extending `SCORE_PATTERN` for a new Greptile output format) would silently diverge from the other and the daily sweep and the LLM judge would disagree on which PRs have low scores. Extract these to `.github/scripts/agent_shin_shared.py` and re-export them from each script so the existing test attribute access (`triage_module.GRACE_COMMENT_MARKER`, etc.) keeps working without any test changes. Bug 2: `review_gate.yml` is a destructive workflow (close PRs, add/remove labels, post comments) with the same gating philosophy as the others (`AGENT_SHIN_ENABLED = "true"` + a per-run `CLOSE_FLAG = "true"`), but it was missing from `DESTRUCTIVE_GATE_ENV` in the guardrail tests. Add it so a future regression (e.g. flipping to `!= "false"`) is caught by the same parameterized invariants as every other workflow. Co-authored-by: Yassin Kortam <yassin@berri.ai>
79 lines
2.9 KiB
Python
79 lines
2.9 KiB
Python
"""Constants and helpers shared by Agent Shin's triage scripts.
|
|
|
|
Both `triage_with_llm.py` (the LLM-judge entrypoint) and
|
|
`close_low_quality_prs.py` (the daily Greptile-score sweep) need to
|
|
agree on the same notions of:
|
|
|
|
* What counts as a Greptile-authored review comment
|
|
(``GREPTILE_BOT_LOGINS``) and how to extract a confidence score from
|
|
its body (``SCORE_PATTERN`` / :func:`extract_greptile_score`).
|
|
* How long the 1-day grace window is (``GRACE_PERIOD_SECONDS``) and
|
|
the HTML marker stamped into a grace-warning comment so the *other*
|
|
script can see "Agent Shin already warned" and behave accordingly
|
|
(``GRACE_COMMENT_MARKER``).
|
|
* Who Agent Shin is on GitHub (``AGENT_SHIN_DEFAULT_BOT_LOGIN``) and
|
|
which login(s) bypass the grace window entirely
|
|
(``IMMEDIATE_CLOSE_LOGINS``).
|
|
* How GitHub-style ISO-8601 timestamps round-trip into timezone-aware
|
|
:class:`datetime.datetime` (:func:`parse_iso8601`).
|
|
|
|
Keeping these in one module means a future change (new Greptile output
|
|
format, a longer grace window, a new dogfood account) is a single edit
|
|
instead of two — the original split version had to call out in comments
|
|
that the two copies "must stay in sync" precisely because nothing
|
|
enforced it.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import datetime as dt
|
|
import re
|
|
from typing import Iterable
|
|
|
|
GREPTILE_BOT_LOGINS = frozenset({"greptile-apps", "greptile-apps[bot]"})
|
|
|
|
SCORE_PATTERN = re.compile(
|
|
r"confidence\s*score\s*[:\-]?\s*(\d+)\s*/\s*5",
|
|
re.IGNORECASE,
|
|
)
|
|
|
|
GRACE_COMMENT_MARKER = "<!-- agent-shin:grace-warning -->"
|
|
|
|
GRACE_PERIOD_SECONDS = 86400
|
|
|
|
AGENT_SHIN_DEFAULT_BOT_LOGIN = "github-actions[bot]"
|
|
|
|
IMMEDIATE_CLOSE_LOGINS = frozenset({"swiftwinds"})
|
|
|
|
|
|
def extract_greptile_score(comments: Iterable[dict]) -> tuple[int, dict] | None:
|
|
"""Return (score, comment) for the most recent Greptile-authored comment
|
|
that contains a "Confidence Score: X/5". Returns None if no such comment.
|
|
|
|
"Most recent" is determined by the comment's `updated_at` (falling back to
|
|
`created_at`), so re-reviews override earlier passes.
|
|
"""
|
|
candidates: list[tuple[str, int, dict]] = []
|
|
for comment in comments:
|
|
user = (comment.get("user") or {}).get("login", "")
|
|
if user not in GREPTILE_BOT_LOGINS:
|
|
continue
|
|
body = comment.get("body") or ""
|
|
match = SCORE_PATTERN.search(body)
|
|
if not match:
|
|
continue
|
|
score = int(match.group(1))
|
|
timestamp = comment.get("updated_at") or comment.get("created_at") or ""
|
|
candidates.append((timestamp, score, comment))
|
|
|
|
if not candidates:
|
|
return None
|
|
|
|
candidates.sort(key=lambda triple: triple[0])
|
|
_, score, comment = candidates[-1]
|
|
return score, comment
|
|
|
|
|
|
def parse_iso8601(value: str) -> dt.datetime:
|
|
"""Parse a GitHub ISO-8601 timestamp into a timezone-aware datetime."""
|
|
return dt.datetime.fromisoformat(value.replace("Z", "+00:00"))
|