mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-17 23:51:30 +00:00
810de556bd
* fix(streaming): map unknown finish_reason values to finish_reason_unspecified Some LLM providers return non-standard finish_reason values that are not in the OpenAIChatCompletionFinishReason Literal (e.g. ZhipuAI/GLM returns 'network_error' when a streaming error occurs mid-response). Previously map_finish_reason() fell through with return finish_reason, passing the unknown value directly to Choices.__init__() which calls Pydantic validation. This caused a ValidationError that was caught by stream_chunk_builder() and re-raised as the misleading: litellm.APIError: Error building chunks for logging/streaming usage calculation Fix: after all known provider-specific mappings, check if the value is in the valid set (stop, length, tool_calls, content_filter, function_call, guardrail_intervened, eos, finish_reason_unspecified, malformed_function_call). Any value not in this set is mapped to 'finish_reason_unspecified' instead of being returned as-is. This is consistent with how other unknown stop reasons (e.g. Vertex AI's FINISH_REASON_UNSPECIFIED) are already handled. * refactor: use get_args(OpenAIChatCompletionFinishReason) for valid set Per code review feedback: replace the hardcoded _valid_finish_reasons set with a module-level frozenset derived dynamically from the source-of-truth Literal type via typing.get_args(). This ensures the valid-reason check stays in sync automatically when new finish reasons are added to the Literal, and avoids recreating the set on every streaming chunk call. * test(map_finish_reason): add unit tests and warning log for unknown finish reasons - Add TestMapFinishReason class in test_core_helpers.py covering: - All known OpenAI-native values pass through unchanged (parametrized) - Provider-specific mappings: Anthropic, Cohere, Vertex AI - Unknown/provider-specific values map to 'finish_reason_unspecified' - Regression test for ZhipuAI/GLM-5 'network_error' case - Add verbose_logger.warning() in map_finish_reason() when an unknown finish_reason is encountered, so operators can track which providers return non-standard values |
||
|---|---|---|
| .. | ||
| agent_tests | ||
| audio_tests | ||
| basic_proxy_startup_tests | ||
| batches_tests | ||
| code_coverage_tests | ||
| documentation_tests | ||
| enterprise | ||
| guardrails_tests | ||
| image_gen_tests | ||
| litellm | ||
| litellm-proxy-extras | ||
| litellm_core_utils | ||
| litellm_utils_tests | ||
| llm_responses_api_testing | ||
| llm_translation | ||
| load_tests | ||
| local_testing | ||
| logging_callback_tests | ||
| mcp_tests | ||
| multi_instance_e2e_tests | ||
| ocr_tests | ||
| old_proxy_tests/tests | ||
| openai_endpoints_tests | ||
| otel_tests | ||
| pass_through_tests | ||
| pass_through_unit_tests | ||
| proxy_admin_ui_tests | ||
| proxy_e2e_anthropic_messages_tests | ||
| proxy_e2e_azure_batches_tests | ||
| proxy_security_tests | ||
| proxy_unit_tests | ||
| router_unit_tests | ||
| scim_tests | ||
| search_tests | ||
| spend_tracking_tests | ||
| store_model_in_db_tests | ||
| test_litellm | ||
| unified_google_tests | ||
| vector_store_tests | ||
| windows_tests | ||
| __init__.py | ||
| gettysburg.wav | ||
| large_text.py | ||
| openai_batch_completions.jsonl | ||
| README.MD | ||
| test_budget_management.py | ||
| test_callbacks_on_proxy.py | ||
| test_config.py | ||
| test_debug_warning.py | ||
| test_default_encoding_non_root.py | ||
| test_end_users.py | ||
| test_entrypoint.py | ||
| test_fallbacks.py | ||
| test_gpt5_azure_temperature_support.py | ||
| test_health.py | ||
| test_keys.py | ||
| test_litellm_proxy_responses_config.py | ||
| test_logging.conf | ||
| test_models.py | ||
| test_openai_endpoints.py | ||
| test_organizations.py | ||
| test_otel_thread_leak.py | ||
| test_passthrough_endpoints.py | ||
| test_presidio_latency.py | ||
| test_proxy_server_non_root.py | ||
| test_ratelimit.py | ||
| test_resource_cleanup.py | ||
| test_service_logger_otel.py | ||
| test_spend_logs.py | ||
| test_team.py | ||
| test_team_logging.py | ||
| test_team_members.py | ||
| test_users.py | ||
In total litellm runs 1000+ tests
[02/20/2025] Update:
To make it easier to contribute and map what behavior is tested,
we've started mapping the litellm directory in tests/test_litellm
This folder can only run mock tests.