litellm/tests/unit/proxy/proxy_server/test_routes_completions.py
Mateo Wang 636e707089
fix(proxy)!: stop answering with the literal string "None" as error type and param on the proxy-server, auth, spend, and key health routes (#39540)
* fix(proxy): stop answering with the literal string "None" on the proxy-server, auth, and health routes

The error objects these routes return defaulted `type` and `param` to the
four-character string "None", so a client's error handler matched no known
OpenAI type and fell into its generic branch.

Route them through the shared openai_error_payload helpers instead, so `type`
comes from the carried type or the HTTP status and `param` serializes as JSON
null.

* fix(proxy): stop answering with the literal string "None" on the spend and management routes

The error objects these routes return defaulted `type` and `param` to the
four-character string "None", so a client's error handler matched no known
OpenAI type and fell into its generic branch.

Route them through the shared openai_error_payload helpers instead, so `type`
comes from the carried type or the HTTP status and `param` serializes as JSON
null.

* test(proxy): pin the mid-stream failure frame and the DB outage body to a JSON null param

* fix(proxy): type upstream timeouts as timeout_error and update integration asserts for the null param

A 408 with no carried type now answers timeout_error instead of invalid_request_error, so a client branching on type keeps retrying it. Three integration suites still compared auth rejections against param="None".

* fix(proxy): keep a 408 on main's invalid_request_error type and pin the transcription file cap's 400

* fix(proxy): type a route failure by the status it answers with after the tag-routing and no-deployment remap

* fix(proxy): keep auth_error on proxy-raised 401/403 route failures and ban the string None as an error type or param

* fix(proxy): type a hook's 401 or 403 on completions, moderations and transcription by its status, as chat does

Only a status the proxy remapped into 401 or 403, such as a tag-routing denial, keeps auth_error.

* test(proxy): build the transcription file-cap test on a real router so it holds after the router refactor
2026-10-29 18:20:52 -07:00

164 lines
5.3 KiB
Python

"""Behavior pins for ``proxy_server.py`` text-completions routes.
Pins (PR2):
- POST /v1/completions
- POST /completions
- POST /engines/{model:path}/completions
- POST /openai/deployments/{model:path}/completions
"""
from __future__ import annotations
from unittest.mock import AsyncMock, MagicMock
import pytest
from fastapi import HTTPException
from litellm.proxy import common_request_processing, proxy_server
from litellm.types.router import RouterErrors
from .conftest import normalize # type: ignore[import-not-found]
HAPPY_RESPONSE = {
"id": "cmpl-test",
"object": "text_completion",
"created": 0,
"model": "gpt-3.5-turbo-instruct",
"choices": [
{
"index": 0,
"text": "Hello from mock",
"finish_reason": "stop",
"logprobs": None,
}
],
"usage": {"prompt_tokens": 2, "completion_tokens": 3, "total_tokens": 5},
}
@pytest.fixture
def patched_completion(monkeypatch):
monkeypatch.setattr(proxy_server, "llm_router", MagicMock())
monkeypatch.setattr(
proxy_server, "proxy_logging_obj", MagicMock(post_call_failure_hook=AsyncMock())
)
async def _fake_process(self, *args, **kwargs):
return dict(HAPPY_RESPONSE)
monkeypatch.setattr(
common_request_processing.ProxyBaseLLMRequestProcessing,
"base_process_llm_request",
_fake_process,
)
yield
@pytest.fixture
def completion_pipeline_raises(monkeypatch):
monkeypatch.setattr(proxy_server, "llm_router", MagicMock())
monkeypatch.setattr(
proxy_server, "proxy_logging_obj", MagicMock(post_call_failure_hook=AsyncMock())
)
async def _raise(self, *args, **kwargs):
raise ValueError("boom")
monkeypatch.setattr(
common_request_processing.ProxyBaseLLMRequestProcessing,
"base_process_llm_request",
_raise,
)
yield
_COMPLETION_PATHS = [
"/v1/completions",
"/completions",
"/engines/gpt-3.5-turbo-instruct/completions",
"/openai/deployments/gpt-3.5-turbo-instruct/completions",
]
@pytest.mark.parametrize("path", _COMPLETION_PATHS)
def test_completion_happy_path(client, auth_as, patched_completion, path):
"""Pins all four ``POST .../completions`` aliases (happy path).
Covers ``POST /v1/completions``, ``POST /completions``,
``POST /engines/{model:path}/completions``, and
``POST /openai/deployments/{model:path}/completions``.
"""
payload = {
"model": "gpt-3.5-turbo-instruct",
"prompt": "Once upon",
"max_tokens": 5,
}
with auth_as():
response = client.post(path, json=payload)
assert response.status_code == 200
assert normalize(response.json()) == {
"id": "<VOLATILE>",
"object": "text_completion",
"created": "<VOLATILE>",
"model": "gpt-3.5-turbo-instruct",
"choices": [
{
"index": 0,
"text": "Hello from mock",
"finish_reason": "stop",
"logprobs": None,
}
],
"usage": {"prompt_tokens": 2, "completion_tokens": 3, "total_tokens": 5},
}
@pytest.mark.parametrize("path", _COMPLETION_PATHS)
def test_completion_pipeline_error(client, auth_as, completion_pipeline_raises, path):
"""Pins all four ``POST .../completions`` aliases (error path).
Covers ``POST /v1/completions``, ``POST /completions``,
``POST /engines/{model:path}/completions``, and
``POST /openai/deployments/{model:path}/completions``.
"""
payload = {"model": "gpt-3.5-turbo-instruct", "prompt": "boom"}
with auth_as():
response = client.post(path, json=payload)
assert response.status_code == 500
assert response.headers.get("content-type", "").startswith("application/json")
@pytest.mark.parametrize(
("failure", "expected_status", "expected_type"),
[
pytest.param(ValueError("boom"), 500, "internal_server_error", id="unexpected_failure"),
pytest.param(
HTTPException(status_code=403, detail="Blocked by the content policy"),
403,
"permission_error",
id="hook_policy_block",
),
pytest.param(HTTPException(status_code=401, detail="key expired"), 401, "authentication_error", id="hook_401"),
pytest.param(
ValueError(f"{RouterErrors.no_deployments_with_tag_routing.value}. Passed model=gpt-4o and tags=['x']"),
401,
"auth_error",
id="tag_routing_denial",
),
],
)
def test_completion_failure_body_types_the_status_it_answers_with(
client, auth_as, monkeypatch, failure, expected_status, expected_type
):
monkeypatch.setattr(proxy_server, "llm_router", MagicMock())
monkeypatch.setattr(proxy_server, "proxy_logging_obj", MagicMock(post_call_failure_hook=AsyncMock()))
async def _raise(self, *args, **kwargs):
raise failure
monkeypatch.setattr(common_request_processing.ProxyBaseLLMRequestProcessing, "base_process_llm_request", _raise)
with auth_as():
response = client.post("/v1/completions", json={"model": "gpt-4o", "prompt": "hi"})
assert response.status_code == expected_status
error = response.json()["error"]
assert (error["type"], error["param"], error["code"]) == (expected_type, None, str(expected_status))