* fix(websearch): keep the provider prefix on the agentic follow-up model
The agentic follow-up rebuilt its model string with "a slash means it is already
qualified". Handlers are handed the provider-stripped model, and for a provider
that routes through a sub-path the remainder still holds a slash, so
bedrock/mantle/anthropic.claude-sonnet-5 arrived as mantle/anthropic.claude-sonnet-5
and stayed that way. The follow-up acompletion could not resolve a provider from it
and raised "LLM Provider NOT provided".
Prefix unless the model is already qualified with that same provider, in one shared
helper used by both the handler and the websearch patch builder, which carried
copies of the same heuristic. This also fixes openrouter, whose stripped model
keeps a slash for the same reason, and the old startswith test that read openai as
a prefix of openai_like.
Fixes#38829
* test(websearch): cover the agentic follow-up call site
The helper had unit tests but the call site did not, so the two changed lines in
_execute_chat_completion_agentic_plan were uncovered. Drive the real follow-up with
mock_response instead of patching litellm, which keeps the test on the behaviour:
against the old code the sub-path case raises "LLM Provider NOT provided", and the
ordinary-model case passes either way as a guard.
* refactor(websearch): trim the comments on the provider-qualify helper
* refactor(websearch): cut the helper and test docstrings to one line
* fix(websearch): leave a hook-qualified follow-up model on its own provider
A hook that patches in its own model owns that choice, so re-qualifying it sent a
cross-provider follow-up to the original request's provider instead. Only a bare
patched model and the request's provider-stripped model take the prefix now, and
the sibling agentic-loop path resolves the model the same way.
* fix(websearch): fall back to the request model when a patch carries no model
An empty patched model dispatched a provider-only name instead of falling back, and a
provider-stripped sub-path copied into the patch lost its prefix. A patched model now
keeps its own provider only when its leading segment names one.
* fix(websearch): keep the provider prefix on the responses follow-up model too
The responses patch builder still used the old "a slash means already qualified" test, so
a provider-stripped sub-path model reached the follow-up unqualified on that surface. It
now resolves the model the same way the chat completion builder does.
* fix(websearch): read custom_llm_provider without a member call on untyped kwargs
* fix(websearch): type the chat patch builder kwargs instead of working around them
* test(websearch): run the real search path and flatten the qualify helper tests
* fix(websearch): route a hook's model on a JSON-configured provider and keep the request provider on an echoed model
* fix(websearch): leave a follow-up model alone when its prefix already routes to the request provider
* fix(websearch): send the agentic follow-up to the model the caller requested
completion() and responses() record the caller's model before routing strips
it, and the chat and Responses follow-up builders prefer that model. This keeps
bedrock/converse_like/, bedrock/claude_platform/ and openrouter/openrouter/*
deployments on their own route for the follow-up.
* test(websearch): cover the recorded caller model in Headroom's retrieval follow-up
* test(websearch): cover the recorded caller model in Compresr's retrieval follow-up
Also merges the repeated provider-prefix check in core_helpers into one helper
and drops a test docstring
* test(websearch): drive the real search path through a mocked Perplexity HTTP route
* refactor(websearch): read the provider from kwargs inside _caller_model
* test(http-handler): type the agentic follow-up provider tests
* refactor(websearch): record agentic loop params through a Logging method
Moving the recording out of completion() keeps it under basedpyright's
code-flow complexity limit after the merge with main.
---------
Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com>
67ae3fb527