mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-27 01:22:18 +00:00
f6882246d4
* ci: run the unit_selection.sh shard files on every event instead of only fork pull requests Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * ci: rename fork-flag to unit-flag now that it applies on every event * test: move tests/test_litellm root and small trees into tests/unit Pure renames, no content changes. Follow-up commits in this PR fix references, merge the three files that already existed in tests/unit, keep live-provider tests in tests/test_litellm and wire CI. * test: carry tests/test_litellm conftest isolation into tests/unit Callback lists, routing fallbacks, cached HTTP clients, logger state, AWS, proxy-URL and keychain env, and session-end client cleanup now reset for unit tests too. The environment isolation owns its MonkeyPatch so a test's own monkeypatch is undone before the model-cost teardown runs. * test: merge, split and prune the moved root and small-tree tests Merge batches/test_batch_utils.py and the chat_completions and messages dispatch tests into the files that already existed in tests/unit. Keep the live Gemini interactions tests, the async image-fetch format test and the OpenAI embedding scorer test in tests/test_litellm since they need real network or keys. Put test_router.py under tests/unit/test_router so the existing package no longer shadows it. Delete eight tests the audit found superseded by stronger ones kept in this move. * ci: run the moved root and small-tree tests under their legacy flags Add the misc and responses-caching-types flags to unit_selection.sh and CircleCI, extend enterprise-routing and mcp-integration, and point the legacy GHA shards, Makefile, redis-compat workflow, merge smoke manifest and change classifier at the new paths. * test: make the new tests/unit directories packages tests/unit/test_package_layout.py requires every directory to carry an __init__.py, and without one the moved and retained test_litellm_responses_bridge.py modules collide on import. * test: scope the unit socket block to tests/unit in shared sessions The GHA shards collect the legacy test-path and the unit selection in one pytest session. The unit conftest's loopback-only block leaked into legacy modules that reach the network at import. The legacy conftest now lifts the restriction at collect and setup time, and the unit conftest re-applies it when collecting its own modules. * test: give the shard-script tests their own GITHUB_OUTPUT They only passed where the runner set it. The CircleCI unit job's env allowlist drops it, so the script's redirect failed there. * test: point the router and module-deletion checks at tests/unit router_code_coverage and code_qa_check_tests only searched tests/test_litellm, so the moved router tests no longer counted. The two silent-experiment tests the audit deleted were the only direct callers of those methods; they are replaced with tests that assert the forwarded shadow request and the recursion guard. --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
92 lines
3.8 KiB
Python
92 lines
3.8 KiB
Python
"""
|
|
Test that LiteLLM_Params and GenericLiteLLMParams handle reserved keys gracefully.
|
|
|
|
This test verifies the fix for the bug where passing a dict containing 'self',
|
|
'params', or '__class__' keys to LiteLLM_Params() would cause:
|
|
TypeError: LiteLLM_Params.__init__() got multiple values for argument 'self'
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from litellm.types.router import GenericLiteLLMParams, LiteLLM_Params
|
|
|
|
|
|
class TestLiteLLMParamsReservedKeys:
|
|
"""Test that reserved keys in input data are filtered out gracefully."""
|
|
|
|
def test_litellm_params_with_self_key(self):
|
|
"""Test LiteLLM_Params handles 'self' key in input dict."""
|
|
params_dict = {"model": "gpt-4", "self": "some_value", "api_key": "test-key"}
|
|
params = LiteLLM_Params(**params_dict)
|
|
assert params.model == "gpt-4"
|
|
assert params.api_key == "test-key"
|
|
assert not hasattr(params, "self") or params.get("self") is None
|
|
|
|
def test_litellm_params_with_params_key(self):
|
|
"""Test LiteLLM_Params handles 'params' key in input dict."""
|
|
params_dict = {"model": "gpt-4", "params": "bad_value"}
|
|
params = LiteLLM_Params(**params_dict)
|
|
assert params.model == "gpt-4"
|
|
|
|
def test_litellm_params_with_class_key(self):
|
|
"""Test LiteLLM_Params handles '__class__' key in input dict."""
|
|
params_dict = {"model": "gpt-4", "__class__": "bad_value"}
|
|
params = LiteLLM_Params(**params_dict)
|
|
assert params.model == "gpt-4"
|
|
|
|
def test_generic_litellm_params_with_self_key(self):
|
|
"""Test GenericLiteLLMParams handles 'self' key in input dict."""
|
|
params_dict = {"self": "some_value", "api_key": "test-key"}
|
|
params = GenericLiteLLMParams(**params_dict)
|
|
assert params.api_key == "test-key"
|
|
|
|
def test_generic_litellm_params_with_params_key(self):
|
|
"""Test GenericLiteLLMParams handles 'params' key in input dict."""
|
|
params_dict = {"params": "bad_value", "api_key": "test-key"}
|
|
params = GenericLiteLLMParams(**params_dict)
|
|
assert params.api_key == "test-key"
|
|
|
|
def test_generic_litellm_params_with_class_key(self):
|
|
"""Test GenericLiteLLMParams handles '__class__' key in input dict."""
|
|
params_dict = {"__class__": "bad_value", "api_key": "test-key"}
|
|
params = GenericLiteLLMParams(**params_dict)
|
|
assert params.api_key == "test-key"
|
|
|
|
def test_max_retries_string_conversion(self):
|
|
"""Test that max_retries is converted from string to int."""
|
|
params = LiteLLM_Params(model="gpt-4", max_retries="5")
|
|
assert params.max_retries == 5
|
|
assert isinstance(params.max_retries, int)
|
|
|
|
def test_extra_fields_preserved(self):
|
|
"""Test that extra fields are preserved when reserved keys are filtered."""
|
|
params_dict = {
|
|
"model": "gpt-4",
|
|
"self": "ignored",
|
|
"custom_field": "custom_value",
|
|
}
|
|
params = LiteLLM_Params(**params_dict)
|
|
assert params.model == "gpt-4"
|
|
assert params.custom_field == "custom_value"
|
|
|
|
def test_normal_instantiation_still_works(self):
|
|
"""Test that normal instantiation without reserved keys works."""
|
|
params = LiteLLM_Params(
|
|
model="gpt-4", api_key="test-key", custom_llm_provider="openai"
|
|
)
|
|
assert params.model == "gpt-4"
|
|
assert params.api_key == "test-key"
|
|
assert params.custom_llm_provider == "openai"
|
|
|
|
def test_multiple_reserved_keys(self):
|
|
"""Test filtering multiple reserved keys at once."""
|
|
params_dict = {
|
|
"model": "gpt-4",
|
|
"self": "value1",
|
|
"params": "value2",
|
|
"__class__": "value3",
|
|
"api_key": "test-key",
|
|
}
|
|
params = LiteLLM_Params(**params_dict)
|
|
assert params.model == "gpt-4"
|
|
assert params.api_key == "test-key"
|