litellm/tests/unit/integrations/test_prometheus_overhead_with_guardrails.py
yuneng-jiang cf491d1df9
test: move tests/test_litellm integrations and secret_managers into tests/unit (#43194)
* ci: run the unit_selection.sh shard files on every event instead of only fork pull requests

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* ci: rename fork-flag to unit-flag now that it applies on every event

* test: move tests/test_litellm root and small trees into tests/unit

Pure renames, no content changes. Follow-up commits in this PR fix
references, merge the three files that already existed in tests/unit,
keep live-provider tests in tests/test_litellm and wire CI.

* test: carry tests/test_litellm conftest isolation into tests/unit

Callback lists, routing fallbacks, cached HTTP clients, logger state, AWS,
proxy-URL and keychain env, and session-end client cleanup now reset for
unit tests too. The environment isolation owns its MonkeyPatch so a test's
own monkeypatch is undone before the model-cost teardown runs.

* test: merge, split and prune the moved root and small-tree tests

Merge batches/test_batch_utils.py and the chat_completions and messages
dispatch tests into the files that already existed in tests/unit. Keep
the live Gemini interactions tests, the async image-fetch format test and
the OpenAI embedding scorer test in tests/test_litellm since they need
real network or keys. Put test_router.py under tests/unit/test_router so
the existing package no longer shadows it. Delete eight tests the audit
found superseded by stronger ones kept in this move.

* ci: run the moved root and small-tree tests under their legacy flags

Add the misc and responses-caching-types flags to unit_selection.sh and
CircleCI, extend enterprise-routing and mcp-integration, and point the
legacy GHA shards, Makefile, redis-compat workflow, merge smoke manifest
and change classifier at the new paths.

* test: make the new tests/unit directories packages

tests/unit/test_package_layout.py requires every directory to carry an
__init__.py, and without one the moved and retained
test_litellm_responses_bridge.py modules collide on import.

* test: scope the unit socket block to tests/unit in shared sessions

The GHA shards collect the legacy test-path and the unit selection in one
pytest session. The unit conftest's loopback-only block leaked into legacy
modules that reach the network at import. The legacy conftest now lifts the
restriction at collect and setup time, and the unit conftest re-applies it
when collecting its own modules.

* test: move tests/test_litellm/llms into tests/unit/llms

Rename-only. Moves the provider tests and the fine-tuning fixtures they
load, mirroring the old paths. Follow-up commits merge, split and wire them.

* test: merge, split and prune the moved llms tests

Merges the Databricks chat transformation tests into the existing unit
file, keeps the tests that need real keys or the network in
tests/test_litellm, deletes the audited tests a stronger unit test
already covers, and points imports at tests.unit.llms.

* ci: run the moved llms tests under their legacy flags

The Vertex AI and All Other Providers shards keep their legacy test-path
for the retained files and add the llm-vertex-ai and llm-other-providers
unit selections. CircleCI gets matching unit jobs.

* test: make the tests/unit/llms directories packages

Adds __init__.py to the moved dirs and drops the legacy ones whose
directories no longer hold tests.

* test: drop script runners and path hacks the llms split left dangling

The __main__ runners in the split openai_like files and the Databricks e2e
runner called tests that now live in the other half of the split or were
deleted. The retained legacy halves also no longer need sys.path edits.

* test: give the shard-script tests their own GITHUB_OUTPUT

They only passed where the runner set it. The CircleCI unit job's env
allowlist drops it, so the script's redirect failed there.

* test: point the router and module-deletion checks at tests/unit

router_code_coverage and code_qa_check_tests only searched tests/test_litellm,
so the moved router tests no longer counted. The two silent-experiment tests
the audit deleted were the only direct callers of those methods; they are
replaced with tests that assert the forwarded shadow request and the
recursion guard.

* test: move tests/test_litellm integrations and secret_managers into tests/unit

Rename-only. Mirrors the old paths, including the directory conftests
and the prompt and JSON fixtures. Follow-up commits prune and wire them.

* test: prune and repoint the moved integrations tests

Deletes the 7 audited tests a stronger test in the same tree already
covers, imports the TLS sink helpers from their new conftest path, and
restores os.environ after each integrations test. Some presets write
OTEL_EXPORTER_OTLP_HEADERS straight into os.environ, and without the
legacy tree's test ordering that header leaked into the AgentOps tests.

* ci: run the moved integrations tests under their legacy flag

The integrations GHA shard and a new CircleCI job run the integrations
unit selection. secret_managers joins the misc selection.

* docs: point integrations and secret_managers references at tests/unit

* test: make the moved integrations directories packages

* test: keep the Databricks manual e2e runner and fix the SageMaker Nova run path

The Databricks e2e file is a manual script whose main() calls the tests
that were pruned, so pruning them broke the documented run. It is back to
its main version. The SageMaker Nova docstring now points at the file's
real location in tests/local_testing.

* test: keep the job's UNIT_FLAG out of the shard-script tests

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-09-25 12:57:07 -07:00

238 lines
9.6 KiB
Python

"""
Unit tests for litellm_overhead_with_guardrails_latency_metric.
The metric reports total internal latency LiteLLM adds around the provider
call = SDK overhead (litellm_overhead_time_ms) + pre/post-call guardrail
durations. During-call (moderation) guardrails run concurrently with the LLM
call and are excluded so they don't inflate the overhead.
"""
from unittest.mock import MagicMock
import pytest
from prometheus_client import REGISTRY
from litellm.integrations.prometheus import PrometheusLogger
from litellm.types.guardrails import GuardrailEventHooks
from litellm.types.utils import StandardLoggingPayload
@pytest.fixture(autouse=True)
def cleanup_prometheus_registry():
"""Clean up prometheus registry before/after each test."""
for collector in list(REGISTRY._collector_to_names.keys()):
REGISTRY.unregister(collector)
yield
for collector in list(REGISTRY._collector_to_names.keys()):
REGISTRY.unregister(collector)
def test_get_guardrail_overhead_seconds_sums_pre_post_excludes_during():
"""Helper sums pre/post durations, excludes during_call, tolerates missing values."""
payload = StandardLoggingPayload(
guardrail_information=[
{"guardrail_mode": GuardrailEventHooks.pre_call, "duration": 0.1},
{"guardrail_mode": GuardrailEventHooks.during_call, "duration": 0.5},
{"guardrail_mode": GuardrailEventHooks.post_call, "duration": 0.25},
{"guardrail_mode": GuardrailEventHooks.post_call}, # no duration -> 0
],
)
# 0.1 (pre) + 0.25 (post) = 0.35; during_call 0.5 excluded; missing duration -> 0
assert abs(PrometheusLogger._get_guardrail_overhead_seconds(payload) - 0.35) < 1e-6
def test_get_guardrail_overhead_seconds_no_guardrails_is_zero():
"""No guardrail_information at all -> 0.0."""
assert (
PrometheusLogger._get_guardrail_overhead_seconds(
StandardLoggingPayload(model="gpt-4o")
)
== 0.0
)
def test_get_guardrail_overhead_seconds_accepts_plain_string_mode():
"""guardrail_mode may arrive as a plain string after serialization."""
payload = StandardLoggingPayload(
guardrail_information=[
{"guardrail_mode": "pre_call", "duration": 0.2},
{"guardrail_mode": "during_call", "duration": 0.9},
],
)
# only pre_call counts; during_call excluded
assert abs(PrometheusLogger._get_guardrail_overhead_seconds(payload) - 0.2) < 1e-6
def test_get_guardrail_overhead_seconds_excludes_list_mode_with_during_call():
"""A list-typed guardrail_mode containing during_call must be excluded.
guardrail_mode is typed Optional[Union[GuardrailEventHooks,
List[GuardrailEventHooks], GuardrailMode]]; a list mixing in during_call is
not additive (concurrent) overhead and must not be counted.
"""
payload = StandardLoggingPayload(
guardrail_information=[
{
"guardrail_mode": [
GuardrailEventHooks.pre_call,
GuardrailEventHooks.during_call,
],
"duration": 0.3,
},
{"guardrail_mode": GuardrailEventHooks.post_call, "duration": 0.05},
],
)
# the list entry mixes in during_call -> excluded; only the post_call counts
assert abs(PrometheusLogger._get_guardrail_overhead_seconds(payload) - 0.05) < 1e-6
def test_get_guardrail_overhead_seconds_counts_pure_pre_post_list_mode():
"""A list-typed mode containing only additive (pre/post) phases is counted."""
payload = StandardLoggingPayload(
guardrail_information=[
{"guardrail_mode": [GuardrailEventHooks.pre_call], "duration": 0.1},
{"guardrail_mode": ["post_call"], "duration": 0.2},
],
)
assert abs(PrometheusLogger._get_guardrail_overhead_seconds(payload) - 0.3) < 1e-6
def test_get_guardrail_overhead_seconds_excludes_logging_only_and_mcp():
"""logging_only and MCP-specific modes do not block the response -> excluded."""
payload = StandardLoggingPayload(
guardrail_information=[
{"guardrail_mode": GuardrailEventHooks.logging_only, "duration": 0.4},
{"guardrail_mode": GuardrailEventHooks.pre_mcp_call, "duration": 0.3},
{"guardrail_mode": GuardrailEventHooks.during_mcp_call, "duration": 0.2},
{"guardrail_mode": GuardrailEventHooks.post_call, "duration": 0.05},
],
)
# only the post_call guardrail is additive, user-visible overhead
assert abs(PrometheusLogger._get_guardrail_overhead_seconds(payload) - 0.05) < 1e-6
def test_get_guardrail_overhead_seconds_ignores_dict_mode_without_error():
"""guardrail_mode may be a GuardrailMode TypedDict (an unhashable dict at
runtime, from the enterprise Mode-hook path). It must not raise TypeError and
must not be counted (the phase can't be resolved to a blocking pre/post)."""
payload = StandardLoggingPayload(
guardrail_information=[
# GuardrailMode TypedDict -> plain dict at runtime
{"guardrail_mode": {"tags": {"default": ["pre_call"]}}, "duration": 0.3},
{"guardrail_mode": GuardrailEventHooks.post_call, "duration": 0.05},
],
)
# dict-typed mode is ignored (no TypeError); only the post_call entry counts
assert abs(PrometheusLogger._get_guardrail_overhead_seconds(payload) - 0.05) < 1e-6
def test_get_guardrail_overhead_seconds_ignores_dict_inside_list_mode():
"""A list-typed mode containing a dict must not raise and the dict is ignored."""
payload = StandardLoggingPayload(
guardrail_information=[
{"guardrail_mode": [GuardrailEventHooks.pre_call, {"k": "v"}], "duration": 0.1},
],
)
# the dict is ignored; remaining mode is pre_call -> counted
assert abs(PrometheusLogger._get_guardrail_overhead_seconds(payload) - 0.1) < 1e-6
def test_get_guardrail_overhead_seconds_handles_single_dict_payload():
"""guardrail_information may be a single dict (e.g. xecguard) rather than a
list. Iterating it would yield string keys and crash the success-metrics
block, so a lone dict must be evaluated as one entry, not raise."""
payload = StandardLoggingPayload(
guardrail_information={
"guardrail_mode": "logging_only",
"duration": 0.7,
"guardrail_name": "xecguard",
},
)
# the single dict is logging_only -> excluded, and must not raise
assert PrometheusLogger._get_guardrail_overhead_seconds(payload) == 0.0
def test_get_guardrail_overhead_seconds_counts_single_pre_call_dict():
"""A single pre/post-call dict (not wrapped in a list) is still counted."""
payload = StandardLoggingPayload(
guardrail_information={"guardrail_mode": "pre_call", "duration": 0.3},
)
assert abs(PrometheusLogger._get_guardrail_overhead_seconds(payload) - 0.3) < 1e-6
def _patch_label_factory(monkeypatch):
monkeypatch.setattr(
"litellm.integrations.prometheus.prometheus_label_factory",
lambda **kwargs: {},
)
def test_overhead_with_guardrails_recorded_when_only_guardrails_no_sdk_overhead(monkeypatch):
"""Guardrail-only overhead is recorded even when SDK overhead is absent."""
_patch_label_factory(monkeypatch)
logger = PrometheusLogger()
mock_metric = MagicMock()
logger.litellm_overhead_with_guardrails_latency_metric = mock_metric
payload = StandardLoggingPayload(
hidden_params={}, # no litellm_overhead_time_ms
guardrail_information=[
{"guardrail_mode": GuardrailEventHooks.post_call, "duration": 0.2}
],
)
logger._set_overhead_with_guardrails_metric(
payload, enum_values=MagicMock(), label_context=MagicMock()
)
mock_metric.labels.return_value.observe.assert_called_once()
observed = mock_metric.labels.return_value.observe.call_args[0][0]
assert abs(observed - 0.2) < 1e-6
def test_overhead_with_guardrails_recorded_when_sdk_overhead_is_zero(monkeypatch):
"""SDK overhead of exactly 0 (walrus-falsy) must not suppress the metric."""
_patch_label_factory(monkeypatch)
logger = PrometheusLogger()
mock_metric = MagicMock()
logger.litellm_overhead_with_guardrails_latency_metric = mock_metric
payload = StandardLoggingPayload(
hidden_params={"litellm_overhead_time_ms": 0.0},
guardrail_information=[
{"guardrail_mode": GuardrailEventHooks.pre_call, "duration": 0.1}
],
)
logger._set_overhead_with_guardrails_metric(
payload, enum_values=MagicMock(), label_context=MagicMock()
)
observed = mock_metric.labels.return_value.observe.call_args[0][0]
assert abs(observed - 0.1) < 1e-6
def test_overhead_with_guardrails_skipped_when_no_overhead_and_no_guardrails(monkeypatch):
"""Nothing to record -> the metric is not touched."""
_patch_label_factory(monkeypatch)
logger = PrometheusLogger()
mock_metric = MagicMock()
logger.litellm_overhead_with_guardrails_latency_metric = mock_metric
payload = StandardLoggingPayload(hidden_params={})
logger._set_overhead_with_guardrails_metric(
payload, enum_values=MagicMock(), label_context=MagicMock()
)
mock_metric.labels.assert_not_called()
def test_overhead_with_guardrails_metric_is_registered():
"""The overhead-with-guardrails histogram is defined and registered on logger init."""
logger = PrometheusLogger()
assert logger.litellm_overhead_with_guardrails_latency_metric is not None
registered = [
name
for name in REGISTRY._names_to_collectors
if name.startswith("litellm_overhead_with_guardrails_latency_metric")
]
assert registered, "litellm_overhead_with_guardrails_latency_metric not registered"