mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-29 01:42:19 +00:00
416d15d67a
`select_cost_metric_for_model` picked its metric by truthiness:
if model_info.get("input_cost_per_character"):
return "cost_per_character"
elif model_info.get("input_cost_per_token"):
return "cost_per_token"
else:
raise ValueError(f"Model {...} does not have ...")
A rate of 0 is a valid price -- it declares the model free -- but it is falsy,
so a free model fell through to the raise and reported that fields it had
explicitly set were missing:
{"key": "my-free-tts", "input_cost_per_character": 0}
-> ValueError: Model my-free-tts does not have 'input_cost_per_character'
or 'input_cost_per_token'
The single caller is the speech/aspeech branch of `completion_cost`
(cost_calculator.py), so a TTS model priced at 0 could not be costed at all,
and the error was indistinguishable from a genuinely unpriced model.
Selection now tests presence with `is not None`. This matches `tier_rate` in
this same package, which already documents the convention: "A rate that is
explicitly present wins over the fallback, an explicit zero included, so a tier
can declare a token type free."
Zero-cost models are a supported concept elsewhere in the codebase (the
router's `_zero_cost_cache`, the auth layer's zero-cost budget bypass), so a
free TTS model is a configuration users can reasonably expect to work.
Behaviour is unchanged for priced models, for a model with both fields set
(character pricing still wins), and for a model with neither -- which still
raises, as does one that sets both to an explicit None.
Adds tests/test_litellm/test_zero_cost_metric_selection.py: 9 tests, 4 of which
fail without this change.
|
||
|---|---|---|
| .. | ||
| agent_tests | ||
| audio_tests | ||
| base_sdk_tests | ||
| basic_proxy_startup_tests | ||
| batches_tests | ||
| benchmarks | ||
| code_coverage_tests | ||
| documentation_tests | ||
| e2e | ||
| enterprise | ||
| guardrails_tests | ||
| image_gen_tests | ||
| integration | ||
| litellm-proxy-extras | ||
| litellm_utils_tests | ||
| llm_responses_api_testing | ||
| llm_translation | ||
| load_tests | ||
| local_testing | ||
| logging_callback_tests | ||
| mcp_tests | ||
| multi_instance_e2e_tests | ||
| ocr_tests | ||
| openai_endpoints_tests | ||
| otel_tests | ||
| pass_through_tests | ||
| pass_through_unit_tests | ||
| proxy_admin_ui_tests | ||
| proxy_behavior | ||
| proxy_e2e_anthropic_messages_tests | ||
| proxy_migration_tests | ||
| proxy_security_tests | ||
| proxy_unit_tests | ||
| router_unit_tests | ||
| search_tests | ||
| spend_tracking_tests | ||
| store_model_in_db_tests | ||
| test_litellm | ||
| unified_google_tests | ||
| vector_store_tests | ||
| windows_tests | ||
| __init__.py | ||
| _fake_openai_endpoint_server.py | ||
| _flush_vcr_cache.py | ||
| _live_test_helpers.py | ||
| _openai_record_replay_proxy.py | ||
| _vcr_conftest_common.py | ||
| _vcr_redis_persister.py | ||
| _wait_helpers.py | ||
| _ws_vcr.py | ||
| eval_swe_bench.py | ||
| fake_openai_endpoint.py | ||
| gettysburg.wav | ||
| large_text.py | ||
| openai_batch_completions.jsonl | ||
| pyrightconfig.json | ||
| README.MD | ||
| test_anthropic_compaction_usage.py | ||
| test_budget_management.py | ||
| test_callbacks_on_proxy.py | ||
| test_debug_warning.py | ||
| test_default_encoding_non_root.py | ||
| test_end_users.py | ||
| test_fallbacks.py | ||
| test_gpt5_azure_temperature_support.py | ||
| test_health.py | ||
| test_keys.py | ||
| test_litellm_proxy_responses_config.py | ||
| test_logging.conf | ||
| test_models.py | ||
| test_new_vector_store_endpoints.py | ||
| test_openai_endpoints.py | ||
| test_organizations.py | ||
| test_otel_thread_leak.py | ||
| test_presidio_latency.py | ||
| test_proxy_server_non_root.py | ||
| test_ratelimit.py | ||
| test_resource_cleanup.py | ||
| test_service_logger_otel.py | ||
| test_spend_logs.py | ||
| test_team.py | ||
| test_team_logging.py | ||
| test_team_members.py | ||
| test_users.py | ||
In total litellm runs 1000+ tests
[02/20/2025] Update:
To make it easier to contribute and map what behavior is tested,
we've started mapping the litellm directory in tests/test_litellm
This folder can only run mock tests.