mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-28 01:32:17 +00:00
* ci: run the unit_selection.sh shard files on every event instead of only fork pull requests Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * ci: rename fork-flag to unit-flag now that it applies on every event * test: move tests/test_litellm root and small trees into tests/unit Pure renames, no content changes. Follow-up commits in this PR fix references, merge the three files that already existed in tests/unit, keep live-provider tests in tests/test_litellm and wire CI. * test: carry tests/test_litellm conftest isolation into tests/unit Callback lists, routing fallbacks, cached HTTP clients, logger state, AWS, proxy-URL and keychain env, and session-end client cleanup now reset for unit tests too. The environment isolation owns its MonkeyPatch so a test's own monkeypatch is undone before the model-cost teardown runs. * test: merge, split and prune the moved root and small-tree tests Merge batches/test_batch_utils.py and the chat_completions and messages dispatch tests into the files that already existed in tests/unit. Keep the live Gemini interactions tests, the async image-fetch format test and the OpenAI embedding scorer test in tests/test_litellm since they need real network or keys. Put test_router.py under tests/unit/test_router so the existing package no longer shadows it. Delete eight tests the audit found superseded by stronger ones kept in this move. * ci: run the moved root and small-tree tests under their legacy flags Add the misc and responses-caching-types flags to unit_selection.sh and CircleCI, extend enterprise-routing and mcp-integration, and point the legacy GHA shards, Makefile, redis-compat workflow, merge smoke manifest and change classifier at the new paths. * test: make the new tests/unit directories packages tests/unit/test_package_layout.py requires every directory to carry an __init__.py, and without one the moved and retained test_litellm_responses_bridge.py modules collide on import. * test: scope the unit socket block to tests/unit in shared sessions The GHA shards collect the legacy test-path and the unit selection in one pytest session. The unit conftest's loopback-only block leaked into legacy modules that reach the network at import. The legacy conftest now lifts the restriction at collect and setup time, and the unit conftest re-applies it when collecting its own modules. * test: move tests/test_litellm/llms into tests/unit/llms Rename-only. Moves the provider tests and the fine-tuning fixtures they load, mirroring the old paths. Follow-up commits merge, split and wire them. * test: merge, split and prune the moved llms tests Merges the Databricks chat transformation tests into the existing unit file, keeps the tests that need real keys or the network in tests/test_litellm, deletes the audited tests a stronger unit test already covers, and points imports at tests.unit.llms. * ci: run the moved llms tests under their legacy flags The Vertex AI and All Other Providers shards keep their legacy test-path for the retained files and add the llm-vertex-ai and llm-other-providers unit selections. CircleCI gets matching unit jobs. * test: make the tests/unit/llms directories packages Adds __init__.py to the moved dirs and drops the legacy ones whose directories no longer hold tests. * test: drop script runners and path hacks the llms split left dangling The __main__ runners in the split openai_like files and the Databricks e2e runner called tests that now live in the other half of the split or were deleted. The retained legacy halves also no longer need sys.path edits. * test: give the shard-script tests their own GITHUB_OUTPUT They only passed where the runner set it. The CircleCI unit job's env allowlist drops it, so the script's redirect failed there. * test: point the router and module-deletion checks at tests/unit router_code_coverage and code_qa_check_tests only searched tests/test_litellm, so the moved router tests no longer counted. The two silent-experiment tests the audit deleted were the only direct callers of those methods; they are replaced with tests that assert the forwarded shadow request and the recursion guard. * test: move tests/test_litellm integrations and secret_managers into tests/unit Rename-only. Mirrors the old paths, including the directory conftests and the prompt and JSON fixtures. Follow-up commits prune and wire them. * test: prune and repoint the moved integrations tests Deletes the 7 audited tests a stronger test in the same tree already covers, imports the TLS sink helpers from their new conftest path, and restores os.environ after each integrations test. Some presets write OTEL_EXPORTER_OTLP_HEADERS straight into os.environ, and without the legacy tree's test ordering that header leaked into the AgentOps tests. * ci: run the moved integrations tests under their legacy flag The integrations GHA shard and a new CircleCI job run the integrations unit selection. secret_managers joins the misc selection. * docs: point integrations and secret_managers references at tests/unit * test: make the moved integrations directories packages * test: keep the Databricks manual e2e runner and fix the SageMaker Nova run path The Databricks e2e file is a manual script whose main() calls the tests that were pruned, so pruning them broke the documented run. It is back to its main version. The SageMaker Nova docstring now points at the file's real location in tests/local_testing. * test: keep the job's UNIT_FLAG out of the shard-script tests --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
392 lines
13 KiB
Python
392 lines
13 KiB
Python
"""Tests for the Slack alerting model deprecation hook."""
|
|
|
|
import asyncio
|
|
from itertools import chain, repeat
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
import litellm
|
|
from litellm.constants import SLACK_MODEL_DEPRECATION_LOCK_ID
|
|
from litellm.integrations.SlackAlerting.slack_alerting import SlackAlerting
|
|
from litellm.proxy._types import AlertType
|
|
from litellm.types.integrations.slack_alerting import SlackAlertingCacheKeys
|
|
from litellm.types.proxy.model_deprecation import (
|
|
DEFAULT_DEPRECATION_CHECK_INTERVAL_SECONDS,
|
|
DEPRECATION_IDLE_POLL_SECONDS,
|
|
)
|
|
|
|
DEAD_MODEL_COST = {
|
|
"dead-model": {"deprecation_date": "2020-01-01", "litellm_provider": "openai"}
|
|
}
|
|
DEAD_ALIAS_DEPLOYMENT = {
|
|
"model_name": "dead-alias",
|
|
"litellm_params": {"model": "dead-model"},
|
|
"model_info": {"id": "1"},
|
|
}
|
|
|
|
|
|
def _make_router(deployments):
|
|
router = MagicMock()
|
|
router.get_model_list.return_value = deployments
|
|
return router
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_skip_when_alert_type_disabled():
|
|
alerting = SlackAlerting(
|
|
alerting=["slack"],
|
|
alert_types=[AlertType.llm_exceptions],
|
|
)
|
|
sent = await alerting.send_model_deprecation_alert(llm_router=MagicMock())
|
|
assert sent is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_skip_when_no_alerting_configured():
|
|
alerting = SlackAlerting(
|
|
alerting=None,
|
|
alert_types=[AlertType.model_deprecation_warnings],
|
|
)
|
|
sent = await alerting.send_model_deprecation_alert(llm_router=MagicMock())
|
|
assert sent is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_skip_when_no_deprecations_found(monkeypatch):
|
|
monkeypatch.setattr(litellm, "model_cost", {})
|
|
alerting = SlackAlerting(
|
|
alerting=["slack"],
|
|
alert_types=[AlertType.model_deprecation_warnings],
|
|
)
|
|
router = _make_router(
|
|
[
|
|
{
|
|
"model_name": "fresh",
|
|
"litellm_params": {"model": "openai/gpt-4o"},
|
|
"model_info": {"id": "x"},
|
|
}
|
|
]
|
|
)
|
|
sent = await alerting.send_model_deprecation_alert(llm_router=router)
|
|
assert sent is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_dispatch_high_severity_when_deprecated(monkeypatch):
|
|
monkeypatch.setattr(
|
|
litellm,
|
|
"model_cost",
|
|
{
|
|
"dead-model": {
|
|
"deprecation_date": "2020-01-01",
|
|
"litellm_provider": "openai",
|
|
}
|
|
},
|
|
)
|
|
alerting = SlackAlerting(
|
|
alerting=["slack"],
|
|
alert_types=[AlertType.model_deprecation_warnings],
|
|
)
|
|
router = _make_router(
|
|
[
|
|
{
|
|
"model_name": "dead-alias",
|
|
"litellm_params": {"model": "dead-model"},
|
|
"model_info": {"id": "1"},
|
|
}
|
|
]
|
|
)
|
|
|
|
with patch.object(
|
|
alerting, "send_alert", new_callable=AsyncMock
|
|
) as mock_send_alert:
|
|
sent = await alerting.send_model_deprecation_alert(llm_router=router)
|
|
|
|
assert sent is True
|
|
mock_send_alert.assert_awaited_once()
|
|
call_kwargs = mock_send_alert.await_args.kwargs
|
|
assert call_kwargs["alert_type"] == AlertType.model_deprecation_warnings
|
|
assert call_kwargs["level"] == "High"
|
|
assert call_kwargs["alerting_metadata"]["deprecated_count"] == 1
|
|
assert call_kwargs["alerting_metadata"]["imminent_count"] == 0
|
|
assert "dead-alias" in call_kwargs["message"]
|
|
assert isinstance(
|
|
await alerting.internal_usage_cache.async_get_cache(
|
|
key=SlackAlertingCacheKeys.deprecation_alert_sent_key.value
|
|
),
|
|
float,
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_alert_once_the_alert_type_and_router_arrive_after_startup(
|
|
monkeypatch,
|
|
):
|
|
"""The loop starts before config reload, so a disabled pass must not cost a day of alerts"""
|
|
monkeypatch.setattr(
|
|
litellm,
|
|
"model_cost",
|
|
{"dead-model": {"deprecation_date": "2020-01-01", "litellm_provider": "openai"}},
|
|
)
|
|
alerting = SlackAlerting(alerting=["slack"], alert_types=[AlertType.llm_exceptions])
|
|
router = _make_router(
|
|
[
|
|
{
|
|
"model_name": "dead-alias",
|
|
"litellm_params": {"model": "dead-model"},
|
|
"model_info": {"id": "1"},
|
|
}
|
|
]
|
|
)
|
|
|
|
slept: list[float] = []
|
|
|
|
async def stop_after_third_pass(seconds):
|
|
slept.append(seconds)
|
|
if alerting.alert_types == [AlertType.llm_exceptions]:
|
|
alerting.update_values(
|
|
alert_types=[AlertType.model_deprecation_warnings]
|
|
) # simulates a config reload enabling the alert
|
|
if len(slept) == 3:
|
|
raise asyncio.CancelledError
|
|
|
|
with (
|
|
patch.object(alerting, "send_alert", new_callable=AsyncMock) as mock_send_alert,
|
|
patch(
|
|
"litellm.integrations.SlackAlerting.slack_alerting.asyncio.sleep",
|
|
side_effect=stop_after_third_pass,
|
|
),
|
|
pytest.raises(asyncio.CancelledError),
|
|
):
|
|
await alerting.run_scheduled_deprecation_check(get_llm_router=lambda: router)
|
|
|
|
assert slept == [DEPRECATION_IDLE_POLL_SECONDS] * 3
|
|
mock_send_alert.assert_awaited_once()
|
|
assert "dead-alias" in mock_send_alert.await_args.kwargs["message"]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_wait_for_the_router_instead_of_sleeping_a_full_day(monkeypatch):
|
|
"""Config load can start the loop before the router exists, which must not cost a day of alerts"""
|
|
monkeypatch.setattr(
|
|
litellm,
|
|
"model_cost",
|
|
{"dead-model": {"deprecation_date": "2020-01-01", "litellm_provider": "openai"}},
|
|
)
|
|
alerting = SlackAlerting(
|
|
alerting=["slack"], alert_types=[AlertType.model_deprecation_warnings]
|
|
)
|
|
router = _make_router(
|
|
[
|
|
{
|
|
"model_name": "dead-alias",
|
|
"litellm_params": {"model": "dead-model"},
|
|
"model_info": {"id": "1"},
|
|
}
|
|
]
|
|
)
|
|
router_absent_passes = 100
|
|
routers = chain(repeat(None, router_absent_passes), repeat(router))
|
|
slept: list[float] = []
|
|
|
|
async def record_sleep(seconds):
|
|
slept.append(seconds)
|
|
if len(slept) > router_absent_passes:
|
|
raise asyncio.CancelledError
|
|
|
|
with (
|
|
patch.object(alerting, "send_alert", new_callable=AsyncMock) as mock_send_alert,
|
|
patch(
|
|
"litellm.integrations.SlackAlerting.slack_alerting.asyncio.sleep",
|
|
side_effect=record_sleep,
|
|
),
|
|
pytest.raises(asyncio.CancelledError),
|
|
):
|
|
await alerting.run_scheduled_deprecation_check(
|
|
get_llm_router=lambda: next(routers)
|
|
)
|
|
|
|
assert slept == [DEPRECATION_IDLE_POLL_SECONDS] * (router_absent_passes + 1)
|
|
mock_send_alert.assert_awaited_once()
|
|
assert "dead-alias" in mock_send_alert.await_args.kwargs["message"]
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"lock_acquired, expect_alert",
|
|
[(True, True), (None, True), (False, False)],
|
|
ids=["lock won", "no redis lock", "another pod holds the lock"],
|
|
)
|
|
@pytest.mark.asyncio
|
|
async def test_should_alert_only_from_the_pod_holding_the_daily_lock(
|
|
monkeypatch, lock_acquired, expect_alert
|
|
):
|
|
"""Every pod runs the loop, so a fleet must not send one identical alert per replica"""
|
|
monkeypatch.setattr(
|
|
litellm,
|
|
"model_cost",
|
|
{"dead-model": {"deprecation_date": "2020-01-01", "litellm_provider": "openai"}},
|
|
)
|
|
alerting = SlackAlerting(
|
|
alerting=["slack"], alert_types=[AlertType.model_deprecation_warnings]
|
|
)
|
|
router = _make_router(
|
|
[
|
|
{
|
|
"model_name": "dead-alias",
|
|
"litellm_params": {"model": "dead-model"},
|
|
"model_info": {"id": "1"},
|
|
}
|
|
]
|
|
)
|
|
pod_lock_manager = MagicMock()
|
|
pod_lock_manager.acquire_lock = AsyncMock(return_value=lock_acquired)
|
|
|
|
with (
|
|
patch.object(alerting, "send_alert", new_callable=AsyncMock) as mock_send_alert,
|
|
patch(
|
|
"litellm.integrations.SlackAlerting.slack_alerting.asyncio.sleep",
|
|
side_effect=asyncio.CancelledError,
|
|
),
|
|
pytest.raises(asyncio.CancelledError),
|
|
):
|
|
await alerting.run_scheduled_deprecation_check(
|
|
get_llm_router=lambda: router, pod_lock_manager=pod_lock_manager
|
|
)
|
|
|
|
assert mock_send_alert.await_count == int(expect_alert)
|
|
assert pod_lock_manager.acquire_lock.await_args.kwargs == {
|
|
"cronjob_id": SLACK_MODEL_DEPRECATION_LOCK_ID,
|
|
"ttl": DEFAULT_DEPRECATION_CHECK_INTERVAL_SECONDS,
|
|
"allow_reentrant": False,
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_retry_on_the_next_poll_when_the_lock_claim_fails(monkeypatch):
|
|
"""A redis blip at claim time returns False like a held lock, and must not cost every pod a day of alerts"""
|
|
monkeypatch.setattr(litellm, "model_cost", DEAD_MODEL_COST)
|
|
alerting = SlackAlerting(
|
|
alerting=["slack"], alert_types=[AlertType.model_deprecation_warnings]
|
|
)
|
|
router = _make_router([DEAD_ALIAS_DEPLOYMENT])
|
|
pod_lock_manager = MagicMock()
|
|
pod_lock_manager.acquire_lock = AsyncMock(side_effect=[False, True])
|
|
slept: list[float] = []
|
|
|
|
async def stop_after_second_pass(seconds):
|
|
slept.append(seconds)
|
|
if len(slept) == 2:
|
|
raise asyncio.CancelledError
|
|
|
|
with (
|
|
patch.object(alerting, "send_alert", new_callable=AsyncMock) as mock_send_alert,
|
|
patch(
|
|
"litellm.integrations.SlackAlerting.slack_alerting.asyncio.sleep",
|
|
side_effect=stop_after_second_pass,
|
|
),
|
|
pytest.raises(asyncio.CancelledError),
|
|
):
|
|
await alerting.run_scheduled_deprecation_check(
|
|
get_llm_router=lambda: router, pod_lock_manager=pod_lock_manager
|
|
)
|
|
|
|
assert slept == [DEPRECATION_IDLE_POLL_SECONDS] * 2
|
|
assert pod_lock_manager.acquire_lock.await_count == 2
|
|
mock_send_alert.assert_awaited_once()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_not_claim_the_lock_when_there_is_nothing_to_report(monkeypatch):
|
|
"""An empty pass must not hold the daily lock, or a sunset added later waits out the whole window"""
|
|
monkeypatch.setattr(litellm, "model_cost", {})
|
|
alerting = SlackAlerting(
|
|
alerting=["slack"], alert_types=[AlertType.model_deprecation_warnings]
|
|
)
|
|
router = _make_router(
|
|
[
|
|
{
|
|
"model_name": "fresh",
|
|
"litellm_params": {"model": "openai/gpt-4o"},
|
|
"model_info": {"id": "x"},
|
|
}
|
|
]
|
|
)
|
|
pod_lock_manager = MagicMock()
|
|
pod_lock_manager.acquire_lock = AsyncMock(return_value=True)
|
|
|
|
with patch.object(alerting, "send_alert", new_callable=AsyncMock) as mock_send_alert:
|
|
sent = await alerting.send_model_deprecation_alert(
|
|
llm_router=router, pod_lock_manager=pod_lock_manager
|
|
)
|
|
|
|
assert sent is False
|
|
pod_lock_manager.acquire_lock.assert_not_awaited()
|
|
mock_send_alert.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_not_alert_or_claim_the_lock_within_a_day_of_a_sent_alert(monkeypatch):
|
|
"""The shared sent stamp keeps sibling pods and restarts from re-alerting or re-asking redis for a day"""
|
|
monkeypatch.setattr(litellm, "model_cost", DEAD_MODEL_COST)
|
|
alerting = SlackAlerting(
|
|
alerting=["slack"], alert_types=[AlertType.model_deprecation_warnings]
|
|
)
|
|
await alerting.internal_usage_cache.async_set_cache(
|
|
key=SlackAlertingCacheKeys.deprecation_alert_sent_key.value,
|
|
value=1.0,
|
|
ttl=DEFAULT_DEPRECATION_CHECK_INTERVAL_SECONDS,
|
|
)
|
|
router = _make_router([DEAD_ALIAS_DEPLOYMENT])
|
|
pod_lock_manager = MagicMock()
|
|
pod_lock_manager.acquire_lock = AsyncMock(return_value=True)
|
|
|
|
with (
|
|
patch.object(alerting, "send_alert", new_callable=AsyncMock) as mock_send_alert,
|
|
patch(
|
|
"litellm.integrations.SlackAlerting.slack_alerting.asyncio.sleep",
|
|
side_effect=asyncio.CancelledError,
|
|
),
|
|
pytest.raises(asyncio.CancelledError),
|
|
):
|
|
await alerting.run_scheduled_deprecation_check(
|
|
get_llm_router=lambda: router, pod_lock_manager=pod_lock_manager
|
|
)
|
|
|
|
pod_lock_manager.acquire_lock.assert_not_awaited()
|
|
mock_send_alert.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_should_back_off_a_full_day_after_a_pass_raises(monkeypatch):
|
|
"""A misconfigured webhook raises on every send, which must log once a day rather than every poll"""
|
|
monkeypatch.setattr(litellm, "model_cost", DEAD_MODEL_COST)
|
|
alerting = SlackAlerting(
|
|
alerting=["slack"], alert_types=[AlertType.model_deprecation_warnings]
|
|
)
|
|
router = _make_router([DEAD_ALIAS_DEPLOYMENT])
|
|
slept: list[float] = []
|
|
|
|
async def stop_after_second_pass(seconds):
|
|
slept.append(seconds)
|
|
if len(slept) == 2:
|
|
raise asyncio.CancelledError
|
|
|
|
with (
|
|
patch.object(
|
|
alerting,
|
|
"send_alert",
|
|
new_callable=AsyncMock,
|
|
side_effect=ValueError("Missing SLACK_WEBHOOK_URL from environment"),
|
|
) as mock_send_alert,
|
|
patch(
|
|
"litellm.integrations.SlackAlerting.slack_alerting.asyncio.sleep",
|
|
side_effect=stop_after_second_pass,
|
|
),
|
|
pytest.raises(asyncio.CancelledError),
|
|
):
|
|
await alerting.run_scheduled_deprecation_check(get_llm_router=lambda: router)
|
|
|
|
assert slept == [DEFAULT_DEPRECATION_CHECK_INTERVAL_SECONDS] * 2
|
|
assert mock_send_alert.await_count == 2
|