mirror of
https://github.com/BerriAI/litellm.git
synced 2026-10-29 06:33:28 +00:00
34c10829b1
* test: cover request ids with URL special characters in log detail fetches Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix(ui): percent-encode request id in spend log detail URL Co-authored-by: Charlie Freeman <243496084+cf3901646@users.noreply.github.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Charlie Freeman <243496084+cf3901646@users.noreply.github.com>
249 lines
9.2 KiB
Python
249 lines
9.2 KiB
Python
import json
|
|
import os
|
|
import re
|
|
import time
|
|
from urllib.parse import unquote
|
|
|
|
import pytest
|
|
import requests
|
|
import responses
|
|
from click.testing import CliRunner
|
|
|
|
from litellm.proxy.client.cli import cli
|
|
from litellm.proxy.client.cli.commands import debug as debug_module
|
|
from litellm.proxy.client.cli.commands.debug import (
|
|
SLASH_COMMAND_NAME,
|
|
detect_claude_session_id,
|
|
install_slash_command,
|
|
)
|
|
|
|
SESSION = "e96634a3-fa28-4083-b354-55542e2dca01"
|
|
|
|
OK_ROW = {
|
|
"request_id": "req-ok",
|
|
"startTime": "2026-09-02T10:00:00",
|
|
"endTime": "2026-09-02T10:00:02",
|
|
"model": "claude-opus-4-1",
|
|
"custom_llm_provider": "anthropic",
|
|
"status": "success",
|
|
"spend": 0.0125,
|
|
"prompt_tokens": 100,
|
|
"completion_tokens": 20,
|
|
"metadata": {"status": "success"},
|
|
}
|
|
FAILED_ROW = {
|
|
"request_id": "req-failed",
|
|
"startTime": "2026-09-02T10:01:00",
|
|
"endTime": "2026-09-02T10:01:01",
|
|
"model": "claude-opus-4-1",
|
|
"custom_llm_provider": "anthropic",
|
|
"status": "failure",
|
|
"spend": 0.0,
|
|
"prompt_tokens": 0,
|
|
"completion_tokens": 0,
|
|
"metadata": json.dumps(
|
|
{
|
|
"status": "failure",
|
|
"error_information": {
|
|
"error_code": "400",
|
|
"error_class": "BadRequestError",
|
|
"error_message": "`prompt` is required when `stop` is not true.",
|
|
},
|
|
}
|
|
),
|
|
}
|
|
|
|
|
|
PROXY = "http://localhost:4000"
|
|
|
|
|
|
def _mock_proxy(rows, payloads):
|
|
responses.get(
|
|
f"{PROXY}/spend/logs/session/ui",
|
|
json={"data": rows, "total": len(rows), "page": 1, "page_size": 100, "total_pages": 1},
|
|
match=[responses.matchers.query_param_matcher({"session_id": SESSION}, strict_match=False)],
|
|
)
|
|
for request_id, payload in payloads.items():
|
|
responses.get(f"{PROXY}/spend/logs/ui/{request_id}", json=payload)
|
|
|
|
|
|
def _called_paths():
|
|
return [c.request.path_url.split("?")[0] for c in responses.calls]
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def env(monkeypatch, tmp_path):
|
|
monkeypatch.setenv("LITELLM_PROXY_URL", PROXY)
|
|
monkeypatch.setenv("LITELLM_PROXY_API_KEY", "sk-test")
|
|
monkeypatch.setattr(debug_module, "REPORT_DIR", tmp_path / "reports")
|
|
monkeypatch.setattr(debug_module, "CLAUDE_DIR", tmp_path / "claude")
|
|
|
|
|
|
@responses.activate
|
|
def test_report_includes_spend_error_and_bodies_for_failed_turn(tmp_path):
|
|
payloads = {
|
|
"req-failed": {
|
|
"proxy_server_request": {"body": {"model": "claude-opus-4-1", "messages": [{"role": "user"}]}},
|
|
"response": {"error": {"message": "`prompt` is required"}},
|
|
},
|
|
"req-ok": {"proxy_server_request": {"body": {"model": "claude-opus-4-1"}}, "response": {"id": "msg_1"}},
|
|
}
|
|
_mock_proxy([FAILED_ROW, OK_ROW], payloads)
|
|
result = CliRunner().invoke(cli, ["debug", "claude", "--session-id", SESSION, "--recent-bodies", "0"])
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert "turns: 2, failed: 1" in result.output
|
|
assert "total spend: $0.012500" in result.output
|
|
assert "### 1. ok claude-opus-4-1" in result.output
|
|
assert "### 2. FAILED claude-opus-4-1" in result.output
|
|
assert "`400` BadRequestError" in result.output
|
|
assert "`prompt` is required when `stop` is not true." in result.output
|
|
assert '"messages"' in result.output
|
|
assert "msg_1" not in result.output
|
|
assert _called_paths() == ["/spend/logs/session/ui", "/spend/logs/ui/req-failed"]
|
|
saved = tmp_path / "reports" / f"claude-{SESSION}.md"
|
|
assert result.stdout.startswith(saved.read_text())
|
|
assert "### 2. FAILED" in saved.read_text()
|
|
|
|
|
|
@responses.activate
|
|
def test_recent_bodies_fetches_latest_turns_even_when_successful():
|
|
_mock_proxy([OK_ROW], {"req-ok": {"proxy_server_request": {"body": {"x": 1}}, "response": {"id": "msg_1"}}})
|
|
result = CliRunner().invoke(cli, ["debug", "claude", "--session-id", SESSION, "--no-save"])
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert "msg_1" in result.output
|
|
assert _called_paths() == ["/spend/logs/session/ui", "/spend/logs/ui/req-ok"]
|
|
|
|
|
|
@pytest.mark.parametrize("request_id", ["req#a1", "req?a=1", "req%41b", "req a&b"])
|
|
@responses.activate
|
|
def test_bodies_are_fetched_for_request_ids_with_url_special_characters(request_id):
|
|
def payload_for_stored_id(request):
|
|
stored_id = unquote(request.path_url.split("?")[0].removeprefix("/spend/logs/ui/"))
|
|
found = stored_id == request_id
|
|
return 200, {}, json.dumps({"response": {"id": "msg_special"}} if found else None)
|
|
|
|
_mock_proxy([{**OK_ROW, "request_id": request_id}], {})
|
|
responses.add_callback(responses.GET, re.compile(f"{PROXY}/spend/logs/ui/.*"), callback=payload_for_stored_id)
|
|
result = CliRunner().invoke(cli, ["debug", "claude", "--session-id", SESSION, "--no-save"])
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert "msg_special" in result.output
|
|
|
|
|
|
@responses.activate
|
|
def test_bodies_are_truncated_to_max_chars():
|
|
_mock_proxy([OK_ROW], {"req-ok": {"proxy_server_request": {"body": "a" * 5000}, "response": None}})
|
|
result = CliRunner().invoke(
|
|
cli, ["debug", "claude", "--session-id", SESSION, "--no-save", "--max-body-chars", "200"]
|
|
)
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert "truncated" in result.output
|
|
assert "a" * 300 not in result.output
|
|
|
|
|
|
@responses.activate
|
|
def test_no_rows_is_a_clear_error():
|
|
_mock_proxy([], {})
|
|
result = CliRunner().invoke(cli, ["debug", "claude", "--session-id", SESSION])
|
|
|
|
assert result.exit_code != 0
|
|
assert "No spend logs found for session" in result.output
|
|
|
|
|
|
def test_no_session_id_anywhere_is_a_clear_error(monkeypatch):
|
|
monkeypatch.delenv("CLAUDE_CODE_SESSION_ID", raising=False)
|
|
result = CliRunner().invoke(cli, ["debug", "claude"])
|
|
assert result.exit_code != 0
|
|
assert "Could not find a Claude Code session" in result.output
|
|
|
|
|
|
OLD_SESSION = "0f3c2b1a-1111-4222-8333-444455556666"
|
|
NEW_SESSION = "2d79c54d-4644-4708-b03e-95395ef9ecbd"
|
|
|
|
|
|
def test_detect_session_id_prefers_env_then_newest_session_transcript(tmp_path):
|
|
project = tmp_path / "projects" / "-Users-me-repo"
|
|
project.mkdir(parents=True)
|
|
old = project / f"{OLD_SESSION}.jsonl"
|
|
new = project / f"{NEW_SESSION}.jsonl"
|
|
subagent = project / "agent-a1b2c3d4.jsonl"
|
|
old.write_text("{}")
|
|
new.write_text("{}")
|
|
subagent.write_text("{}")
|
|
now = time.time()
|
|
os.utime(old, (now - 100, now - 100))
|
|
os.utime(new, (now - 50, now - 50))
|
|
os.utime(subagent, (now, now))
|
|
|
|
assert detect_claude_session_id({}, tmp_path) == NEW_SESSION
|
|
assert detect_claude_session_id({"CLAUDE_CODE_SESSION_ID": "from-env"}, tmp_path) == "from-env"
|
|
assert detect_claude_session_id({"CLAUDE_SESSION_ID": "stale-name"}, tmp_path) == NEW_SESSION
|
|
assert detect_claude_session_id({}, tmp_path / "missing") is None
|
|
|
|
|
|
def test_install_slash_command_writes_runnable_command_file(tmp_path):
|
|
path = install_slash_command(tmp_path)
|
|
assert path == tmp_path / "commands" / f"{SLASH_COMMAND_NAME}.md"
|
|
body = path.read_text()
|
|
assert body.startswith("---\n")
|
|
assert "allowed-tools: Bash(lite debug claude:*)" in body
|
|
assert "!`lite debug claude $ARGUMENTS`" in body
|
|
|
|
result = CliRunner().invoke(cli, ["debug", "install-claude-command"])
|
|
assert result.exit_code == 0, result.output
|
|
assert "/debug-lite" in result.output
|
|
|
|
|
|
@responses.activate
|
|
def test_rejected_key_is_a_clear_error_not_a_traceback():
|
|
responses.get(
|
|
f"{PROXY}/spend/logs/session/ui",
|
|
status=401,
|
|
json={"error": {"message": "Authentication Error, Invalid proxy server token passed", "code": "401"}},
|
|
)
|
|
result = CliRunner().invoke(cli, ["debug", "claude", "--session-id", SESSION])
|
|
|
|
assert isinstance(result.exception, SystemExit), result.exception
|
|
assert result.exit_code == 1
|
|
assert "401" in result.output
|
|
assert "Invalid proxy server token passed" in result.output
|
|
|
|
|
|
@responses.activate
|
|
def test_unreachable_proxy_is_a_clear_error_not_a_traceback():
|
|
responses.get(f"{PROXY}/spend/logs/session/ui", body=requests.ConnectionError("Connection refused"))
|
|
result = CliRunner().invoke(cli, ["debug", "claude", "--session-id", SESSION])
|
|
|
|
assert isinstance(result.exception, SystemExit), result.exception
|
|
assert result.exit_code == 1
|
|
assert "Connection refused" in result.output
|
|
|
|
|
|
@responses.activate
|
|
def test_non_json_proxy_response_is_a_clear_error_not_a_traceback():
|
|
responses.get(f"{PROXY}/spend/logs/session/ui", body="<html>502 Bad Gateway</html>")
|
|
result = CliRunner().invoke(cli, ["debug", "claude", "--session-id", SESSION])
|
|
|
|
assert isinstance(result.exception, SystemExit), result.exception
|
|
assert result.exit_code == 1
|
|
assert "/spend/logs/session/ui failed" in result.output
|
|
|
|
|
|
@responses.activate
|
|
def test_logged_content_with_code_fences_stays_inside_its_fence():
|
|
fenced_error_row = {
|
|
**FAILED_ROW,
|
|
"metadata": {
|
|
"status": "failure",
|
|
"error_information": {"error_code": "400", "error_message": "bad\n```\nrequest"},
|
|
},
|
|
}
|
|
_mock_proxy([fenced_error_row], {"req-failed": {"proxy_server_request": None, "response": "x\n````\ny"}})
|
|
result = CliRunner().invoke(cli, ["debug", "claude", "--session-id", SESSION, "--no-save"])
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert "````\nbad\n```\nrequest\n````\n" in result.output
|
|
assert "`````json\nx\n````\ny\n`````\n" in result.output
|