mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-26 01:12:21 +00:00
28ba9f7c6b
Address two related concerns raised in PR review on the reconsider flow: 1. **Dry-run support for --reconsider** (P1, greptile-apps): The previous --reconsider branch unconditionally called post_comment + reopen_* regardless of --close. The docstring claimed 'close is forced True implicitly', but the workflow's only kill switch was AGENT_SHIN_ENABLED — invoking the script directly without --close was still destructive, the opposite of the conventional dry-run expectation. triage() now honors close=False in reconsider mode: a passing verdict returns action='would-reopen' (with the comment body it WOULD post in result['comment']) and a failing verdict returns action='would-leave-closed-still-failing'. The reconsider workflow now appends --close iff AGENT_SHIN_ENABLED == 'true', mirroring the pattern used by close_low_quality_prs.yml. 2. **Provenance gate for reopen** (P2, both greptile-apps and veria-ai): The reconsider flow could be used to silently override a maintainer's close decision — an external author edits the closed PR to include a closing keyword, comments '@agent-shin reconsider', and the bot reopens it. There was no check that Agent Shin was the actor that originally closed it. triage() now requires was_auto_closed_by_agent_shin() to be true before any reopen path can fire. The check looks for a bot-authored comment (login ends with '[bot]') containing the auto-close marker 'I'm **Agent Shin**'. Filtering by bot author makes the marker unspoofable: a contributor pasting the phrase into a manual comment cannot satisfy the check. When the provenance gate fails, triage returns action='skip-not-bot-closed' without burning LLM tokens or posting anything. Unit tests cover both behaviors plus the failure modes of was_auto_closed_by_agent_shin (no comments, non-bot author with marker, bot comment without marker, marker found anywhere in the comment list). Co-authored-by: Mateo Wang <mateo-berri@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| _test-unit-base.yml | ||
| _test-unit-services-base.yml | ||
| auto_update_price_and_context_window.yml | ||
| auto_update_price_and_context_window_file.py | ||
| check-schema-sync.yml | ||
| check_duplicate_issues.yml | ||
| close_low_quality_prs.yml | ||
| codeql.yml | ||
| codspeed.yml | ||
| create-release-branch.yml | ||
| create-release.yml | ||
| create_daily_staging_branch.yml | ||
| guard-fork-dependencies.yml | ||
| guard-main-branch.yml | ||
| helm_unit_test.yml | ||
| issue-keyword-labeler.yml | ||
| label-component.yml | ||
| mutation-test.yml | ||
| run_llm_translation_tests.py | ||
| scorecard.yml | ||
| stale.yml | ||
| sync-schema.yml | ||
| test-code-quality.yml | ||
| test-linting.yml | ||
| test-litellm-ui-build.yml | ||
| test-mcp.yml | ||
| test-model-map.yaml | ||
| test-semgrep.yml | ||
| test-unit-core-utils.yml | ||
| test-unit-documentation.yml | ||
| test-unit-enterprise-routing.yml | ||
| test-unit-integrations.yml | ||
| test-unit-llm-providers.yml | ||
| test-unit-misc.yml | ||
| test-unit-proxy-auth.yml | ||
| test-unit-proxy-db.yml | ||
| test-unit-proxy-endpoints.yml | ||
| test-unit-proxy-infra.yml | ||
| test-unit-proxy-legacy.yml | ||
| test-unit-responses-caching-types.yml | ||
| test-unit-security.yml | ||
| test_server_root_path.yml | ||
| triage_issue_with_llm.yml | ||
| triage_pr_with_llm.yml | ||
| triage_reconsider.yml | ||
| zizmor.yml | ||