mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-06 08:16:43 +00:00
3ebf09464a
`requests` has no default timeout, so a host that accepts the connection and never answers blocks the calling thread forever. The one on the request path is the HiddenLayer guardrail's `_get_jwt`. It runs synchronously inside `_call_hiddenlayer` whenever the hour-long JWT expires and the API answers 401, so a stalled auth host parked the worker's whole event loop, not just the guarded request. The other eight are the teams and users CLI clients, which pin the operator's terminal instead. `TeamsManagementClient` and `UsersManagementClient` now take the same `timeout: int = 30` their `HTTPClient` sibling already had, and `Client` threads its own timeout down to teams. `_poll_for_ready_data` already passed a timeout through a TypedDict that ruff could not see into; passing the argument directly retires both the TypedDict and the suppression it would have needed. Graduate S113 into ruff.toml so the next `requests` call without a timeout fails the lint step.
100 lines
2.9 KiB
Python
100 lines
2.9 KiB
Python
import time
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
import requests
|
|
|
|
|
|
|
|
from litellm.proxy.client.users import (
|
|
NotFoundError,
|
|
UnauthorizedError,
|
|
UsersManagementClient,
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def client():
|
|
return UsersManagementClient(base_url="http://localhost:4000", api_key="sk-test")
|
|
|
|
|
|
@patch("requests.get")
|
|
def test_list_users_success(mock_get, client):
|
|
mock_get.return_value.status_code = 200
|
|
mock_get.return_value.json.return_value = {"users": [{"user_id": "u1"}]}
|
|
users = client.list_users()
|
|
assert users == [{"user_id": "u1"}]
|
|
mock_get.assert_called_once()
|
|
|
|
|
|
@patch("requests.get")
|
|
def test_list_users_unauthorized(mock_get, client):
|
|
mock_get.return_value.status_code = 401
|
|
mock_get.return_value.text = "unauthorized"
|
|
with pytest.raises(UnauthorizedError):
|
|
client.list_users()
|
|
|
|
|
|
@patch("requests.get")
|
|
def test_get_user_success(mock_get, client):
|
|
mock_get.return_value.status_code = 200
|
|
mock_get.return_value.json.return_value = {"user_id": "u1"}
|
|
user = client.get_user(user_id="u1")
|
|
assert user["user_id"] == "u1"
|
|
mock_get.assert_called_once()
|
|
|
|
|
|
@patch("requests.get")
|
|
def test_get_user_404(mock_get, client):
|
|
mock_get.return_value.status_code = 404
|
|
mock_get.return_value.text = "not found"
|
|
with pytest.raises(NotFoundError):
|
|
client.get_user(user_id="u1")
|
|
|
|
|
|
@patch("requests.post")
|
|
def test_create_user_success(mock_post, client):
|
|
mock_post.return_value.status_code = 200
|
|
mock_post.return_value.json.return_value = {"user_id": "u1"}
|
|
user = client.create_user({"user_email": "a@b.com"})
|
|
assert user["user_id"] == "u1"
|
|
mock_post.assert_called_once()
|
|
|
|
|
|
@patch("requests.post")
|
|
def test_create_user_unauthorized(mock_post, client):
|
|
mock_post.return_value.status_code = 401
|
|
mock_post.return_value.text = "unauthorized"
|
|
with pytest.raises(UnauthorizedError):
|
|
client.create_user({"user_email": "a@b.com"})
|
|
|
|
|
|
@patch("requests.post")
|
|
def test_delete_user_success(mock_post, client):
|
|
mock_post.return_value.status_code = 200
|
|
mock_post.return_value.json.return_value = {"deleted": 1}
|
|
result = client.delete_user(["u1"])
|
|
assert result["deleted"] == 1
|
|
mock_post.assert_called_once()
|
|
|
|
|
|
@patch("requests.post")
|
|
def test_delete_user_unauthorized(mock_post, client):
|
|
mock_post.return_value.status_code = 401
|
|
mock_post.return_value.text = "unauthorized"
|
|
with pytest.raises(UnauthorizedError):
|
|
client.delete_user(["u1"])
|
|
|
|
|
|
def test_delete_user_gives_up_at_the_timeout_instead_of_hanging(hanging_server):
|
|
"""
|
|
A proxy that accepts the connection but never answers used to pin the caller's
|
|
process forever, since the request carried no timeout at all.
|
|
"""
|
|
client = UsersManagementClient(base_url=hanging_server, api_key="sk-test", timeout=1)
|
|
|
|
started = time.monotonic()
|
|
with pytest.raises(requests.exceptions.Timeout):
|
|
client.delete_user(["u1"])
|
|
|
|
assert time.monotonic() - started < 10
|