litellm/test-quality-budget.json at 092d97708d816c159f0fce8d7793ec0d05c5b261 - scriptoriumadmin/litellm - Forgejo: Beyond coding. We forge.

scriptoriumadmin/litellm

mirror of https://github.com/BerriAI/litellm.git synced 2026-08-28 05:25:59 +00:00

yuneng-jiang 092d97708d

test(s3): stop the logger tests leaking s3_callback_params on failure (#37831 )

Ten tests set litellm.s3_callback_params by hand. Four of them reset it to None
on the last line of the test body, which only runs when the test passes; the
other six wrap the body in try/finally to put the old value back. Raising inside
test_s3_verify_false_handling on the current file leaves the whole callback
config, bucket, endpoint and keys, set in the process for whatever runs next.

monkeypatch.setattr covers both shapes and restores on failure, so the 28 TQ005
violations and the try/finally scaffolding come out together.

51 tests pass, and the wider tests/test_litellm/integrations tree is unchanged.
The five TQ002 mock-echo tests in this file are left alone; those need a
judgement about what S3 logging should assert, not a mechanical sweep.

2026-08-21 22:21:29 -07:00

23 lines

249 B

JSON

Raw Blame History

 {
   "TQ001": {
     "limit": 744
   },
   "TQ002": {
     "limit": 742
   },
   "TQ003": {
     "limit": 1068
   },
   "TQ004": {
     "limit": 469
   },
   "TQ005": {
     "limit": 2514
   },
   "TQ006": {
     "limit": 34
   },
   "TQ007": {
     "limit": 117
   }
 }