mirror of
https://github.com/BerriAI/litellm.git
synced 2026-10-09 03:18:44 +00:00
a5f9410681
key_edit_view opened a select and then clicked the option it found by title text or by raw text. Both queries match the moment the option enters the DOM, which is one render before the popup finishes entering. Until then the positioner still carries an inline pointer-events: none, and user-event refuses to click through it. That is a race, and a fast machine loses it. Five of the file's 84 tests failed on every local run while CI stayed green, which is the worst shape for a test to have: it is only ever red on the machine of whoever is trying to change the code. tests/test-utils.tsx already ships chooseSelectOption for exactly this. It finds the option by role and waits for the positioner to release pointer events before clicking. The five call sites now use it, and the helper takes the direct user-event API as well as a setup() instance so callers do not have to restructure to use it. Five consecutive full-file runs pass where every previous run failed. Also finishes this file's screen queries, which brings prefer-screen-queries to its target of 18. |
||
|---|---|---|
| .. | ||
| estimatedOutputTokens.test.ts | ||
| estimatedOutputTokens.ts | ||
| key_edit_view.test.tsx | ||
| key_edit_view.tsx | ||
| key_info_view.budget_display.test.tsx | ||
| key_info_view.test.tsx | ||
| key_info_view.tsx | ||
| keyEditFieldNormalizers.ts | ||
| keyEditFormValues.test.ts | ||
| keyEditFormValues.ts | ||
| KeyEditViewControls.tsx | ||
| KeyInfoHeader.test.tsx | ||
| KeyInfoHeader.tsx | ||
| KeyInfoView.handleKeyUpdate.test.tsx | ||
| KeySavingsTab.integration.test.tsx | ||
| KeySavingsTab.tsx | ||