mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-13 23:11:40 +00:00
7ed25de120
* fix(ui): allow any git host on the skills add form (LIT-4053)
The skills add form only accepted GitHub URLs: its URL parser bailed on
any host that did not start with github.com, so GitLab, Bitbucket, and
self-hosted repos (and any repo subfolder on them) were rejected before a
request was ever sent. The backend already accepts arbitrary git hosts
via its url and git-subdir sources, with no host allowlist, so this was a
client-side restriction only.
Generalize the parser into an exported, host-agnostic parseSkillSource:
GitHub URLs keep their github / git-subdir shorthand, every other host is
treated as a raw repo url, and an optional Subfolder path field turns any
repo into a git-subdir source (url + path). When a pasted GitHub
tree/blob URL already encodes a subfolder, the field is cleared and
disabled so a contradictory source can never be submitted.
The parser is hardened to match the backend contract: query strings and
fragments are stripped, the host match is case-insensitive and drops a
leading www., the extracted and field-entered subfolder paths are both
validated against the same regex the server uses, a real file-extension
allowlist (not "any dot") decides whether a trailing blob segment is a
file, a branch-only tree URL falls back to the repo, non-GitHub URLs
require at least an org/repo, and the suggested skill name is kebab-cased
so it satisfies the name field's own rule.
The git-subdir source is now handled in the display helpers
(getSourceDisplayText, getSourceLink, formatInstallCommand), which
previously showed it as "Unknown source" with no link. The submit path
is fully typed (RegisterPluginRequest plus an AddPluginFormValues
interface), removing the two prior any usages; as a result an
author with an email but no name is dropped rather than sent, since the
backend requires the author name.
No backend changes. Tests cover the full host/subfolder matrix at the
parser level plus form-submit assertions on the exact source payload.
* refactor(ui): sync skill register types to the generated OpenAPI schema, surface backend errors
Replace the hand-maintained, already-drifted API types for the skills add
flow with the generated ones from schema.d.ts: PluginAuthor now aliases
components["schemas"]["PluginAuthor"], the registration payload is a new
SkillRegisterRequest (the generated RegisterPluginRequest envelope with
source narrowed to our PluginSource union, since the backend types source
as a loose string map, and version kept optional since the backend
defaults it), and the dead, mismatched RegisterPluginResponse is deleted.
registerClaudeCodePlugin's inline payload type (which was missing the
git-subdir path field entirely) is replaced with SkillRegisterRequest, so
the networking layer and the form can no longer drift from the backend.
Error handling: the add-skill form swallowed the real failure and always
showed "Failed to register skill". registerClaudeCodePlugin already
derives the backend message and throws it, so the form now surfaces it
("Failed to register skill: <reason>"), and the networking helper falls
back to the raw body / status when the error response is not JSON instead
of throwing a JSON parse error. A regression test asserts the backend
message reaches the user.
* fix(ui): reject credentialed git URLs on the skills form
A repo URL with embedded user-info (user:token@host) passed the raw-host
parser and was stored verbatim as the skill source, which is served on
the unauthenticated /public/skill_hub and marketplace.json feeds, leaking
the credentials. Reject any host segment containing '@'.
* fix(ui): validate skill repo URLs through one WHATWG URL gate
Replace the ad-hoc string parsing (stripScheme / splitHost / manual
scheme, @, ?# checks) with a single parseRepoUrl gate built on the URL
parser, so every malformed/unsafe class is handled in one place and the
URL stored on the public skill feeds is always canonical. It enforces
https (rejecting http/ssh/git/file/javascript/data and protocol-relative
//host), rejects embedded credentials (user:token@host, including
userinfo-confusion like github.com@evil.com), rejects IP-literal hosts
(loopback/private/metadata and obfuscated/IPv6 forms), and rebuilds the
stored url from origin+pathname so query strings, fragments, and trailing
slashes can never be published. The GitHub org/repo shorthand is now
charset-validated like the other paths, so junk can't reach the stored
repo. Closes both Veria findings (credentialed and http sources) plus the
adversarial-review follow-ups, with regression tests for each class.
|
||
|---|---|---|
| .. | ||
| add_model | ||
| agent_management | ||
| agents | ||
| AIHub | ||
| alerting | ||
| atoms | ||
| chat_ui | ||
| claude_code_plugins | ||
| CloudZeroCostTracking | ||
| common_components | ||
| DeletedKeysPage | ||
| DeletedTeamsPage | ||
| edit_auto_router | ||
| email_events | ||
| EntityUsageExport | ||
| guardrails | ||
| GuardrailsMonitor | ||
| key_team_helpers | ||
| KeyAliasSelect/PaginatedKeyAliasSelect | ||
| llm_calls | ||
| mcp_server_management | ||
| mcp_tools | ||
| model_add | ||
| model_dashboard | ||
| ModelSelect | ||
| molecules | ||
| Navbar | ||
| organisms | ||
| organization | ||
| permissions | ||
| policies | ||
| router_settings | ||
| routing_groups | ||
| search_tools | ||
| Settings | ||
| shared | ||
| tag_management | ||
| team | ||
| templates | ||
| ToolPolicies | ||
| ui | ||
| UsagePage | ||
| vector_store_management | ||
| view_logs | ||
| view_model | ||
| view_users | ||
| VirtualKeysPage | ||
| activity_metrics.test.tsx | ||
| activity_metrics.tsx | ||
| add_pass_through.tsx | ||
| AdminPanel.test.tsx | ||
| AdminPanel.tsx | ||
| agents.test.tsx | ||
| agents.tsx | ||
| bulk_create_users_button.test.tsx | ||
| bulk_create_users_button.tsx | ||
| BulkEditUsers.test.tsx | ||
| BulkEditUsers.tsx | ||
| callback_info_helpers.tsx | ||
| claude_code_plugins.tsx | ||
| cloudzero_export_modal.tsx | ||
| constants.tsx | ||
| CreateUserButton.test.tsx | ||
| CreateUserButton.tsx | ||
| DebugWarningBanner.test.tsx | ||
| DebugWarningBanner.tsx | ||
| DefaultUserSettings.test.tsx | ||
| DefaultUserSettings.tsx | ||
| edit_user.tsx | ||
| email_settings.tsx | ||
| general_settings.tsx | ||
| guardrails.test.tsx | ||
| guardrails.tsx | ||
| GuardrailSettingsView.tsx | ||
| HelpLink.test.tsx | ||
| HelpLink.tsx | ||
| key_info_utils.test.tsx | ||
| key_info_utils.tsx | ||
| key_value_input.tsx | ||
| leftnav.test.tsx | ||
| leftnav.tsx | ||
| logging_settings_view.tsx | ||
| mcp_hub_table_columns.test.tsx | ||
| mcp_hub_table_columns.tsx | ||
| model_filters.tsx | ||
| model_group_alias_settings.tsx | ||
| model_hub_table_columns.tsx | ||
| model_info_view.test.tsx | ||
| model_info_view.tsx | ||
| navbar.test.tsx | ||
| navbar.tsx | ||
| networking.test.ts | ||
| networking.tsx | ||
| object_permissions_view.tsx | ||
| OldTeams.test.tsx | ||
| OldTeams.tsx | ||
| onboarding_link.tsx | ||
| organizations.test.tsx | ||
| organizations.tsx | ||
| page_metadata.ts | ||
| page_utils.test.ts | ||
| page_utils.ts | ||
| pass_through_info.tsx | ||
| pass_through_settings.tsx | ||
| per_user_usage.tsx | ||
| price_data_reload.tsx | ||
| provider_info_helpers.test.tsx | ||
| provider_info_helpers.tsx | ||
| public_model_hub.test.tsx | ||
| public_model_hub.tsx | ||
| query_param_input.tsx | ||
| route_preview.tsx | ||
| SCIM.tsx | ||
| settings.test.tsx | ||
| settings.tsx | ||
| skill_hub_table_columns.tsx | ||
| SSOModals.test.tsx | ||
| SSOModals.tsx | ||
| TeamSSOSettings.test.tsx | ||
| TeamSSOSettings.tsx | ||
| ToolDetail.tsx | ||
| ToolPolicies.tsx | ||
| ToolPoliciesView.test.tsx | ||
| ToolPoliciesView.tsx | ||
| UIAccessControlForm.tsx | ||
| UIAccessControlForm.unit.test.tsx | ||
| usage.tsx | ||
| UsageIndicator.test.tsx | ||
| UsageIndicator.tsx | ||
| user_agent_activity.test.tsx | ||
| user_agent_activity.tsx | ||
| user_dashboard.test.tsx | ||
| user_dashboard.tsx | ||
| user_edit_view.test.tsx | ||
| user_edit_view.tsx | ||
| vector_store_providers.tsx | ||
| view_user_spend.tsx | ||
| view_users.test.tsx | ||
| view_users.tsx | ||