mirror of
https://github.com/BerriAI/litellm.git
synced 2026-08-28 05:25:59 +00:00
6a0d03914c
* test: drop the cwd-relative sys.path.insert calls from the test suite
TQ003 stands at 1,077 across 1,058 files, and 1,015 of them are the same shape:
sys.path.insert(0, os.path.abspath("../..")) and its deeper siblings. The
argument resolves against the working directory rather than the file, so from
the repo root, where every job runs pytest, it inserts the directory two levels
above the checkout. It has never pointed at litellm. The package is installed
into the environment anyway, which is what actually makes the import work, and
what the rule's message has said all along.
Removing them leaves 1,634 imports of sys and os with no remaining reference,
and those go too, except where another test module imports the name back out of
the file. The rest of TQ003 is 62 call sites that resolve against __file__ or a
variable, which are a different question and are left alone.
Collection is identical either way: 45,871 tests and the same 51 pre-existing
collection errors before and after, and ruff reports no new undefined name.
* test: drop the duplicate imports the sys.path sweep exposed to F811
* test(pre-call-utils): restore the os import the new bedrock tests need
52 lines
1.6 KiB
Python
52 lines
1.6 KiB
Python
import os
|
|
|
|
|
|
import httpx
|
|
import pytest
|
|
|
|
from litellm.proxy.proxy_server import app
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_favicon_default():
|
|
"""Test that get_favicon returns the default favicon when no URL set."""
|
|
os.environ.pop("LITELLM_FAVICON_URL", None)
|
|
|
|
async with httpx.AsyncClient(
|
|
transport=httpx.ASGITransport(app=app), base_url="http://testserver"
|
|
) as ac:
|
|
response = await ac.get("/get_favicon")
|
|
|
|
assert response.status_code in [200, 404]
|
|
if response.status_code == 200:
|
|
assert response.headers["content-type"] == "image/x-icon"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_favicon_with_custom_url(monkeypatch):
|
|
"""Test that get_favicon redirects browser-loaded custom URLs."""
|
|
monkeypatch.setenv("LITELLM_FAVICON_URL", "https://example.com/favicon.ico")
|
|
|
|
async with httpx.AsyncClient(
|
|
transport=httpx.ASGITransport(app=app),
|
|
base_url="http://testserver",
|
|
) as ac:
|
|
response = await ac.get("/get_favicon")
|
|
|
|
assert response.status_code == 307
|
|
assert response.headers["location"] == "https://example.com/favicon.ico"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_favicon_remote_url_is_not_server_fetched(monkeypatch):
|
|
"""Test that get_favicon does not validate remote URLs server-side."""
|
|
monkeypatch.setenv("LITELLM_FAVICON_URL", "https://invalid.com/favicon.ico")
|
|
|
|
async with httpx.AsyncClient(
|
|
transport=httpx.ASGITransport(app=app),
|
|
base_url="http://testserver",
|
|
) as ac:
|
|
response = await ac.get("/get_favicon")
|
|
|
|
assert response.status_code == 307
|
|
assert response.headers["location"] == "https://invalid.com/favicon.ico"
|