litellm

mirror of https://github.com/BerriAI/litellm.git synced 2026-09-15 23:31:29 +00:00

History

Yassin Kortam c6b2f111a6 fix(team): make team member add atomic to prevent concurrent-add member loss (#34185 ) _add_team_members_to_team reconciled membership by reading the complete_team_data snapshot captured at the start of team_member_add, appending in memory, and writing the whole members_with_roles array back. Two concurrent /team/member_add calls for the same team read the same snapshot, so the last write wins and one member is silently lost. This affects every concurrent team member add, including the SCIM group PATCH op:add path that routes through team_member_add Reconcile members_with_roles inside a transaction that locks the team row with SELECT ... FOR UPDATE before re-reading the current membership, so concurrent writers serialize on the row lock and each appends onto the other's committed result. The interactive transaction is exposed through a thin PrismaClient.tx() passthrough and the locked read is encapsulated in TeamRepository.get_members_with_roles_locked, and the SCIM group PATCH applies membership as deltas so concurrent adds are not clobbered	2026-07-22 21:47:22 +00:00
..
test_repositories.py	fix(team): make team member add atomic to prevent concurrent-add member loss (#34185 )	2026-07-22 21:47:22 +00:00

fix(team): make team member add atomic to prevent concurrent-add member loss (#34185 )

_add_team_members_to_team reconciled membership by reading the complete_team_data
snapshot captured at the start of team_member_add, appending in memory, and
writing the whole members_with_roles array back. Two concurrent /team/member_add
calls for the same team read the same snapshot, so the last write wins and one
member is silently lost. This affects every concurrent team member add, including
the SCIM group PATCH op:add path that routes through team_member_add

Reconcile members_with_roles inside a transaction that locks the team row with
SELECT ... FOR UPDATE before re-reading the current membership, so concurrent
writers serialize on the row lock and each appends onto the other's committed
result. The interactive transaction is exposed through a thin PrismaClient.tx()
passthrough and the locked read is encapsulated in
TeamRepository.get_members_with_roles_locked, and the SCIM group PATCH applies
membership as deltas so concurrent adds are not clobbered

2026-07-22 21:47:22 +00:00

test_repositories.py

fix(team): make team member add atomic to prevent concurrent-add member loss (#34185 )

2026-07-22 21:47:22 +00:00