mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-10 22:41:41 +00:00
* test: drop the cwd-relative sys.path.insert calls from the test suite
TQ003 stands at 1,077 across 1,058 files, and 1,015 of them are the same shape:
sys.path.insert(0, os.path.abspath("../..")) and its deeper siblings. The
argument resolves against the working directory rather than the file, so from
the repo root, where every job runs pytest, it inserts the directory two levels
above the checkout. It has never pointed at litellm. The package is installed
into the environment anyway, which is what actually makes the import work, and
what the rule's message has said all along.
Removing them leaves 1,634 imports of sys and os with no remaining reference,
and those go too, except where another test module imports the name back out of
the file. The rest of TQ003 is 62 call sites that resolve against __file__ or a
variable, which are a different question and are left alone.
Collection is identical either way: 45,871 tests and the same 51 pre-existing
collection errors before and after, and ruff reports no new undefined name.
* test: drop the duplicate imports the sys.path sweep exposed to F811
* test(pre-call-utils): restore the os import the new bedrock tests need
182 lines
6.4 KiB
Python
182 lines
6.4 KiB
Python
"""
|
|
Test A2A model routing in proxy.
|
|
|
|
Maps to: litellm/proxy/agent_endpoints/a2a_routing.py
|
|
"""
|
|
|
|
|
|
|
|
from unittest.mock import AsyncMock, Mock, patch
|
|
|
|
import pytest
|
|
|
|
from litellm.proxy.agent_endpoints.a2a_routing import route_a2a_agent_request
|
|
from litellm.proxy.route_llm_request import route_request
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_route_a2a_model_bypasses_router():
|
|
"""Test that a2a/ prefixed models bypass router and go directly to litellm with api_base"""
|
|
|
|
# Mock data for chat completion with a2a model
|
|
data = {
|
|
"model": "a2a/test-agent",
|
|
"messages": [{"role": "user", "content": "Hello"}],
|
|
}
|
|
|
|
# Mock router that doesn't have the a2a model
|
|
mock_router = Mock()
|
|
mock_router.model_names = ["gpt-4", "gpt-3.5-turbo"]
|
|
mock_router.deployment_names = []
|
|
mock_router.has_model_id = Mock(return_value=False)
|
|
mock_router.is_recognized_model = Mock(return_value=False)
|
|
mock_router.model_group_alias = None
|
|
mock_router.router_general_settings = Mock(pass_through_all_models=False)
|
|
mock_router.default_deployment = None
|
|
mock_router.pattern_router = Mock(patterns=[])
|
|
mock_router.map_team_model = Mock(return_value=None)
|
|
|
|
# Mock agent in registry
|
|
from litellm.types.agents import AgentResponse
|
|
|
|
mock_agent = AgentResponse(
|
|
agent_id="test-agent-id",
|
|
agent_name="test-agent",
|
|
agent_card_params={"url": "http://agent.example.com"},
|
|
litellm_params=None,
|
|
)
|
|
|
|
mock_registry = Mock()
|
|
mock_registry.get_agent_by_id = Mock(return_value=None)
|
|
mock_registry.get_agent_by_name = Mock(return_value=mock_agent)
|
|
|
|
# Mock litellm.acompletion to verify it's called
|
|
mock_acompletion = AsyncMock(return_value={"id": "test-response"})
|
|
|
|
with patch("litellm.acompletion", mock_acompletion):
|
|
with patch(
|
|
"litellm.proxy.agent_endpoints.agent_registry.global_agent_registry",
|
|
mock_registry,
|
|
):
|
|
result = await route_request(
|
|
data=data,
|
|
llm_router=mock_router,
|
|
user_model=None,
|
|
route_type="acompletion",
|
|
)
|
|
|
|
# Verify litellm.acompletion was called with api_base injected
|
|
mock_acompletion.assert_called_once()
|
|
call_kwargs = mock_acompletion.call_args.kwargs
|
|
assert call_kwargs["model"] == "a2a/test-agent"
|
|
assert call_kwargs["api_base"] == "http://agent.example.com"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_route_non_a2a_model_raises_error_if_not_in_router():
|
|
"""Test that non-a2a models that aren't in router raise an error"""
|
|
|
|
# Mock data for chat completion with model not in router
|
|
data = {
|
|
"model": "unknown-model",
|
|
"messages": [{"role": "user", "content": "Hello"}],
|
|
}
|
|
|
|
# Mock router without the model
|
|
mock_router = Mock()
|
|
mock_router.model_names = ["gpt-4", "gpt-3.5-turbo"]
|
|
mock_router.deployment_names = []
|
|
mock_router.has_model_id = Mock(return_value=False)
|
|
mock_router.is_recognized_model = Mock(return_value=False)
|
|
mock_router.model_group_alias = None
|
|
mock_router.router_general_settings = Mock(pass_through_all_models=False)
|
|
mock_router.default_deployment = None
|
|
mock_router.pattern_router = Mock(patterns=[])
|
|
mock_router.map_team_model = Mock(return_value=None)
|
|
|
|
# Should raise ProxyModelNotFoundError
|
|
from litellm.proxy.route_llm_request import ProxyModelNotFoundError
|
|
|
|
with pytest.raises(ProxyModelNotFoundError):
|
|
await route_request(
|
|
data=data,
|
|
llm_router=mock_router,
|
|
user_model=None,
|
|
route_type="acompletion",
|
|
)
|
|
|
|
|
|
class _DbAgentRow:
|
|
def __init__(self, agent_id: str, agent_name: str) -> None:
|
|
self.agent_id = agent_id
|
|
self.agent_name = agent_name
|
|
self.object_permission = None
|
|
self.spend = 0.0
|
|
|
|
def model_dump(self):
|
|
return {
|
|
"agent_id": self.agent_id,
|
|
"agent_name": self.agent_name,
|
|
"agent_card_params": {"name": self.agent_name, "url": "http://sibling-db-agent.example.com"},
|
|
"litellm_params": {},
|
|
"object_permission": None,
|
|
"spend": self.spend,
|
|
}
|
|
|
|
|
|
def _router_without_models():
|
|
mock_router = Mock()
|
|
mock_router.model_names = []
|
|
mock_router.deployment_names = []
|
|
mock_router.has_model_id = Mock(return_value=False)
|
|
mock_router.model_group_alias = None
|
|
mock_router.router_general_settings = Mock(pass_through_all_models=False)
|
|
mock_router.default_deployment = None
|
|
mock_router.pattern_router = Mock(patterns=[])
|
|
mock_router.map_team_model = Mock(return_value=None)
|
|
mock_router.is_recognized_model = Mock(return_value=False)
|
|
mock_router.team_public_model_names = []
|
|
return mock_router
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_route_a2a_model_read_through_recovers_agent_created_on_sibling_replica(monkeypatch):
|
|
import litellm.proxy.proxy_server as proxy_server
|
|
from litellm.proxy.agent_endpoints.agent_registry import global_agent_registry
|
|
|
|
agent_name = "a2a-sibling-replica-agent"
|
|
prisma_client = Mock()
|
|
prisma_client.db.litellm_agentstable.find_unique = AsyncMock(
|
|
side_effect=[None, _DbAgentRow("a2a-sibling-replica-agent-id", agent_name)]
|
|
)
|
|
monkeypatch.setattr(proxy_server, "prisma_client", prisma_client)
|
|
monkeypatch.setattr(proxy_server, "store_model_in_db", True)
|
|
|
|
original_agents = list(global_agent_registry.agent_list)
|
|
original_config_agents = getattr(global_agent_registry, "config_agents", ())
|
|
global_agent_registry.agent_list = []
|
|
global_agent_registry.config_agents = ()
|
|
|
|
data = {
|
|
"model": f"a2a/{agent_name}",
|
|
"messages": [{"role": "user", "content": "Hello"}],
|
|
}
|
|
mock_acompletion = AsyncMock(return_value={"id": "read-through-response"})
|
|
|
|
try:
|
|
with patch("litellm.acompletion", mock_acompletion):
|
|
await route_request(
|
|
data=data,
|
|
llm_router=_router_without_models(),
|
|
user_model=None,
|
|
route_type="acompletion",
|
|
)
|
|
finally:
|
|
global_agent_registry.agent_list = original_agents
|
|
global_agent_registry.config_agents = original_config_agents
|
|
|
|
mock_acompletion.assert_called_once()
|
|
call_kwargs = mock_acompletion.call_args.kwargs
|
|
assert call_kwargs["model"] == f"a2a/{agent_name}"
|
|
assert call_kwargs["api_base"] == "http://sibling-db-agent.example.com"
|
|
prisma_client.db.litellm_agentstable.find_unique.assert_awaited()
|