3 commits

Author	SHA1	Message	Date
yuneng-jiang	44d99475a5	test(integration): stop GET /__observations from draining the upstream log (#47256) ... * test(integration): stop GET /__observations from draining the upstream log GET /__observations used to empty the queue, so a second read in a test saw nothing and a "never reached upstream" check could pass whether or not the request was forwarded. GET now returns every request since the last reset and DELETE /__observations is the reset. An autouse fixture resets the worker upstream before each test, which also covers tests that read without the gateway fixture. Discarded reads used as resets become DELETEs, helpers that accumulated drained reads now read one snapshot, and tests with several phases reset between them. The three vacuous negative checks (rag allowlist, guardrail opt-out chaos, xAI batch output) now assert the absence on the same read that shows a request which did reach the upstream. * style(integration): space the observations unit test like its neighbours	2026-10-18 09:58:05 +00:00
yuneng-jiang	fc27dfdc7d	test(integration): give each owned proxy a private database and Redis by default (#47213) ... * test(integration): give each owned proxy a private database and Redis by default owned_proxy and owned_proxy_process now boot on a scratch database and a per-proxy redis-server unless the caller opts into the worker's state with state=OwnedState.SHARED_WITH_WORKER, passes its own DATABASE_URL, or strips DATABASE_URL. Under the replica profile the private database gets the writer and reader roles so the reader path stays covered. Gateway carries the database_url its proxy writes to, and the Scenario cleanup checks and delete_key_if_present read from it, so they keep checking something on a private database. The 189 test files with owned proxy sites that depend on the worker's database or Redis opt in with a shares_worker_state module marker, which a module-scoped conftest fixture turns into the shared state. The 7 helper modules with such sites opt in per call, since conftest fixtures and other test files reach them. * test(integration): reach session fixtures with the shared marker and keep the worker retry default The module-scoped fixture that applied shares_worker_state ran after session-scoped fixtures, so proxies those booted went private in marked files. The marker is now applied around each marked item's setup, call and teardown, which covers fixtures of every scope. Owned proxies on the worker database inherited the worker gateway's router_settings.num_retries of 0 from it. A private proxy now gets the same default in its config copy unless the config sets num_retries itself. Five providers files read the owned proxy's spend rows or response cache through the worker's database or Redis and opt into sharing.	2026-10-18 03:37:41 +00:00
yucheng-berri	784581bace	fix(proxy)!: return provider-matching 4xx for the LIT-8062 status code follow-ups (#45537) ... * fix(proxy): return provider-matching 4xx for the LIT-8062 status code follow-ups - OCR multipart errors are 400 invalid_request_error on the file param - a missing model is a 400 on chat, responses and messages even with a wildcard deployment - responses max_output_tokens <= 0 reaches the provider instead of being raised to 16 - daily activity rejects end_date before start_date with a 400 - vector store file attributes are sent in full so the provider enforces its key limit - router-wide defaults no longer satisfy a param the Router takes positionally, or a model the router does not serve - a JSON null user_config is treated as absent * chore: keep the type gates at their merge-base counts * fix(proxy): keep fixed-target wildcards serving a missing model and close router-default gaps - a missing model is rejected only when the wildcard would forward it into the target - moderation only counts router defaults for models get_model_list lists - user_config defaults and deployment params never satisfy a positionally bound param * test(integration): pin the fixed-target wildcard path and no provider call on positional-param 400s * chore: validate pattern-matched deployments instead of reading untyped dicts * fix(proxy): keep router defaults counting for a2a agent models * test: drop the signature-walk test and type the new test helpers * test(integration): audit matrix for the status-code follow-ups Drives every mode the fix branches on through a real proxy, Postgres, Redis and the scripted upstream: positional params against router, deployment and user_config defaults; moderation listed vs unlisted; unknown and a2a models; every user_config shape on chat, responses and messages, streaming and SDK clients; forwarding vs fixed-target wildcards for missing, null and empty models; Responses max_output_tokens edges; OCR parse errors; vector store file attributes; every daily activity route; and a provider outage mid burst plus a killed worker on a two-worker proxy. Product gaps found are skipped as BUG. * style: ruff format the audit test files * test: name the auth pre-check as the source of the JSON array 500 * test: build the audit helpers without mutation and share one sentinel * test: build every audit request body as one literal * fix(proxy): keep router defaults and model-less dispatch for requests a fallback chain serves * fix(proxy): count request, key and team fallbacks when an unlisted model inherits router defaults * fix(proxy): skip key and team fallbacks on the client-credential dispatch path * fix(proxy): keep router defaults when the router's own * fallback serves an unlisted model * fix(proxy): count client-style fallbacks, forward an empty model, report invalid usage chat dates - The router-default pre-check now treats client-style request, key and team fallbacks ([{"model": ...}]) as serving an unlisted model, as the router does - The forwarding-wildcard gate only rejects a missing or null model; an empty model reaches the provider as before (vLLM serves its loaded model for it) - The /usage/ai/chat tools hand the model the date-range error instead of an empty dataset or a generic fetch error * test(usage): type the invalid-date tool test * fix(proxy): keep rejecting an empty model behind a forwarding wildcard Key and team model checks skip an empty model, so forwarding it let a key restricted to another model reach a server's default model (vLLM serves its loaded model for ""). Pin that with a restricted-key integration cell. * fix(usage): report the query layer's date 400 to the usage chat model Checking dates before the fetch refused formats the global usage tool's query accepts (2026/10/01 returned spend on main). Catch the daily activity query's own 400 instead, so each tool rejects exactly what it rejected before and only the message changes. * fix(proxy): restore three model-less and unlisted-model paths main served An empty model is looked up as sent, so next to a forwarding */* wildcard it still reaches the fixed * deployment it matches. A null model with a prompt_id is left to the prompt manager, which may pick the model. A Claude Code subagent turn on a session-bound auto/complexity router counts as served, so the router default max_tokens still applies. * fix(proxy): only skip the model check for a prompt_id when a prompt manager is registered Without a callback prompt manager nothing can pick the model, so a null model with a prompt_id behind a forwarding wildcard gets the same 400 as any other null model. * fix(proxy): leave a model-less Claude Code subagent turn to its session router A subagent turn on a session bound to an auto, complexity, adaptive or quality router is answered by that router whatever model it names, so a null or missing model behind a forwarding wildcard is no longer rejected. An empty model stays rejected. * fix(proxy): skip the wildcard model check only for a bound Claude Code session Read the session's router binding, as the router does, instead of only checking that the request could resume one, so a subagent turn without a model on an unbound session is still rejected before a forwarding wildcard sends it upstream. * refactor(proxy): stop predicting routing in the proxy pre-checks - drop the wildcard missing-model gate: a model-less request behind a forwarding wildcard goes to the router and gets the provider's own status, as on main - drop the "model the router serves" check: router defaults count for any named model again, except moderation, where the Router merges them only for listed models - keep the positional-param, moderation and null user_config fixes * test(ocr): cover the form, size, empty body, invalid JSON and file-document 400s --------- Co-authored-by: yucheng-berri <293926326+yucheng-berri@users.noreply.github.com>	2026-10-13 11:42:39 -07:00