Commit graph

16 commits

Author SHA1 Message Date
mateo-berri
aef209963a fix(s3_vectors): embed registered-store ingests with the store's embedding model
The S3 Vectors ingestion embedded every chunk with the request's
embedding.model or the default, never the embedding_model the store was
registered with, while search on the same store embeds with the
registered model. A registered store uploaded to by id alone therefore
embedded with the wrong model and AWS rejected the vectors on the
dimension mismatch. The store's embedding model now wins for S3 Vectors
ingestion through a helper next to the one search already uses
2026-09-19 04:31:15 -07:00
mateo-berri
e74a5e0c21 test(rag): drop the docstrings from the registered-store ingest tests 2026-09-19 04:10:49 -07:00
mateo-berri
e4d01d1d78 fix(s3_vectors): reject a store id with an empty bucket or index part
A "bucket:" or ":index" id split into an empty name, so ingestion silently
generated a fresh index and search sent the empty name to AWS. Both sides now
raise the existing format error through the shared helper.
2026-09-19 03:52:48 -07:00
mateo-berri
e2d118aaf8 fix(rag): read a registered S3 Vectors store's bucket and index from its id
A registered S3 Vectors store usually carries only its "bucket:index" id,
and the previous commit stopped forwarding the caller's bucket and index for
a managed store, so ingesting into one raised KeyError 'vector_bucket_name'.
The ingestion now derives both from vector_store_id with the rule the search
side already uses, explicit keys still winning. The caller's
litellm_credential_name is dropped for a managed store too, since it expands
into api_key and api_base, and max_embedding_requests_per_min joins the
per-upload options a caller may still set.
2026-09-19 03:38:20 -07:00
mateo-berri
f22c7d274a Merge remote-tracking branch 'origin/main' into litellm_bedrock_rag_retrieval_filter
Some checks failed
ai-gateway image / ai-gateway release image (push) Has been cancelled
LiteLLM Rust / rust-lint (push) Has been cancelled
LiteLLM Rust / rust-test (push) Has been cancelled
Terraform Modules / fmt, validate, test (aws) (push) Has been cancelled
Terraform Modules / fmt, validate, test (gcp) (push) Has been cancelled
Terraform Provider / gofmt, vet, build, test (push) Has been cancelled
Terraform Provider / Provider endpoints vs proxy OpenAPI schema (push) Has been cancelled
# Conflicts:
#	litellm/rag/main.py
#	tests/test_litellm/rag/test_main.py
2026-09-15 15:21:57 -07:00
mateo-berri
c15f4e066f fix(rag): let the managed store's params win over caller kwargs on the search call 2026-09-02 18:59:28 -07:00
mateo-berri
91061675ae test(rag): wrap the store-forwarding patches so every new line fits in 120 chars 2026-09-02 18:04:52 -07:00
mateo-berri
8ed1da40de fix(rag): forward the managed vector store's params to the search call
/v1/rag/query folded the registry store's litellm_params into retrieval_config,
where the caller allowlist dropped api_key, api_base, and provider extras such
as Milvus outputFields and milvus_text_field, so a managed Milvus store 500'd
with MILVUS_API_KEY is not set while the direct search endpoint worked. The
store's params now travel as a trusted vector_store_params argument straight to
the search call, never through the completion kwargs, and the caller allowlist
stays in place.
2026-09-02 17:55:02 -07:00
mateo-berri
babe7816ad fix(rag): store-wins merge, single lookup, allowlisted search params
rag_query reuses the store resolved during authorization instead of a
second registry lookup, merges registry data store-wins so callers
cannot override a managed store's provider or credentials, and logs ids
instead of the merged config, which can carry resolved credentials.
aquery forwards only allowlisted retrieval_config keys to vector store
search, keeping caller-supplied connection overrides like api_base and
api_key away from the search call
2026-09-01 12:52:45 -07:00
mateo-berri
753f3705d0 Merge litellm_internal_staging (4c3ef9ae0a) into litellm_fix_s3_vectors_search 2026-09-01 12:27:23 -07:00
Devin AI
cb70941660 fix(tests): drain the global logging worker in RAG aquery billing tests instead of polling
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-08-28 09:58:22 +00:00
milan
d2c574608a test(rag): validate retrieval filters at HTTP boundary
Some checks failed
LiteLLM Rust / rustfmt, clippy, test (push) Has been cancelled
Terraform Modules / fmt, validate, test (aws) (push) Has been cancelled
Terraform Provider / gofmt, vet, build, test (push) Has been cancelled
Terraform Provider / Provider endpoints vs proxy OpenAPI schema (push) Has been cancelled
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-08-25 14:56:22 +00:00
michelligabriele
a1514efa21
fix(vector_stores): S3 Vectors search router bypass + rag query config drop + UI error swallow 2026-07-27 17:07:58 +02:00
milan
232b9e8e78 fix(rag): consume top-level filters kwarg to avoid duplicate keyword in search
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-07-23 21:04:42 +00:00
milan
8a9ff04b4d fix(rag): forward retrieval_filter from retrieval_config to Bedrock KB search
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-07-23 20:48:01 +00:00
Yassin Kortam
215ce9f7c1
fix(rag): track LLM completion usage and spend for /v1/rag/query (#32438) 2026-07-17 17:45:27 +00:00