Commit graph

6 commits

Author SHA1 Message Date
Aman Sachan
036c3cd2c5
fix(tests): remove misleading env vars from langfuse None-guard tests
The env vars in the regression tests had no effect — the functions under
test operate only on the params dict and don't read from env vars.
Clean up the test setup to avoid misleading future maintainers.

Greptile feedback: P2
2026-05-16 02:48:01 +00:00
Aman Sachan
77d712d138
fix(langfuse): fix TypedDict attribute access in regression test
TypedDict does not support attribute access (config.attr), must use
dict-style access (config['key']). Fix the regression test that was
failing after the None-guard fix was applied.
2026-05-16 00:52:53 +00:00
Aman Sachan
ccb3afb3e2
fix(langfuse): guard against None standard_callback_dynamic_params
Fix AttributeError: 'NoneType' object has no attribute 'get' when Langfuse
is configured via environment variables (no per-request dynamic params).

In _dynamic_langfuse_credentials_are_passed() and
get_dynamic_langfuse_logging_config(), standard_callback_dynamic_params can
be None (not {}). Calling .get() directly on None raises AttributeError.

Fix: use params = standard_callback_dynamic_params or {} before calling .get().

Added regression tests for both functions to ensure None is handled correctly.

Fixes: BerriAI/litellm#25940
2026-05-14 00:30:42 +00:00
user
bb6d7c9715 fix(callbacks): preserve langfuse secret alias 2026-04-30 14:36:51 -07:00
user
258edac727 test(callbacks): cover upstream langfuse debug env 2026-04-30 14:34:39 -07:00
user
15d4d51453 chore(callbacks): guard dynamic integration hosts 2026-04-30 14:27:19 -07:00