5 commits

Author	SHA1	Message	Date
yuneng-jiang	93c1461074	fix(ui): restore hover feedback and dark-mode variants lost in the token migration (#37579) ... * fix(ui): restore hover feedback and dark-mode variants lost in the token migration PR #37576 mapped hardcoded Tailwind palette classes onto semantic tokens. Two-tone hover pairs collapsed onto a single token, so 116 hover utilities across 49 files became identical to their base class and produced no visible feedback, and in seven files a dark: variant was dropped while its hardcoded light partner survived, leaving those elements stuck light in dark mode. Hover states now follow the alpha-step idiom the shadcn primitives already use (hover:bg-primary/80, hover:bg-success/20): a duplicated hover:text-X or hover:bg-X becomes /80, hover:border-border becomes hover:border-ring, and a duplicate is dropped where another hover utility on the element already carries the change. One transition-colors that no longer animated anything is removed. For the dark-mode gaps, indigo maps onto info and amber onto warning. There is no purple token in globals.css, so the purple sites keep their palette classes and get their dark: partner back. * fix(ui): add an eslint rule that fails a hover: utility identical to its base The token migration collapsed two-tone hover pairs by hand, so nothing catches the next one. `local/no-noop-hover-variant` reads every string literal and template chunk and errors when a `hover:X` sits alongside a bare `X`, which is exactly the shape that renders no hover feedback. It ships at error with no suppression baseline, so the eleven sites that already carried a dead hover before the migration are fixed here too. The rule reads one class string at a time, so a base class supplied by a different ternary branch than its hover partner is left alone: a selected row whose resting colour already matches its hover colour is deliberate, not a bug.	2026-08-19 22:52:36 -07:00
ryan-crabbe-berri	7b574b9df6	chore(ui): drop the antd dependency and its leftovers (#37574) ... Nothing in the dashboard renders antd any more, so the package and the scaffolding around it can go. This removes `antd` and `@ant-design/cssinjs` from package.json, deletes the global StyleProvider the root layout wrapped every page in, drops the `antd` cascade layer and the z-index override that lifted Base UI popups over an antd Modal, and retires the lint rules that policed antd imports and antd class selectors in tests. Fifteen test files still carried `vi.mock("antd", ...)` factories for components that stopped importing antd during the migration. They were inert, and they resolve the real module, so they would have broken the moment the package left node_modules. The compatibility shims keep their behaviour and lose the antd name: `antdRules`/`antdRequired` become `validatorRules`/`requiredRule`, `isAntdUrl` becomes `isValidUrl`, and `ABOVE_ANTD_MODAL` becomes `NESTED_DIALOG_LAYER`. Comments that explain why a contract looks the way it does still name antd, because that history is the reason.	2026-08-19 20:44:27 -07:00
Yuneng Jiang	7d15c5b6da	test(ui): query antd controls accessibly instead of by internal CSS class ... Dashboard tests located controls through antd's own class names (.ant-form-item, .ant-select-selector, .ant-select-item-option). Those break when a page moves to shadcn without any behaviour changing, and they miss regressions a user would notice. Replace them with role, label, title and accessible icon-name queries where antd exposes one, and add local/no-antd-class-selectors to keep them out. The rule is enabled as an error at zero violations, so there is no budget file and no suppressions baseline. It found eight more sites a '.ant-' search missed, written as bare class names. Eleven couplings remain and carry an inline suppression naming why: antd puts role="option" only on a hidden mirror list, so the visible options have no role, no aria-disabled and a tooltip in title; Skeleton and the modal mask expose nothing at all; and one assertion's whole purpose is that no antd modal renders. 7231 tests passed before, 7233 pass after: one conflated ModelSelector case became three focused ones.	2026-08-15 01:41:24 -07:00
ryan-crabbe-berri	67fce87b16	chore(ui): add filename, size, JSX-handler, prefer-const, and antd lint rules (#34341) ... * chore(ui): add filename, size, JSX-handler, prefer-const, and antd lint rules Wires up five error-level ESLint rules on the dashboard, grandfathering every current offender into eslint-suppressions.json so the gate only bites new code and ratchets down as files are fixed - local/filename-pascal-case: new local rule requiring PascalCase .tsx names, exempting Next.js reserved files (page, layout, route, ...) and test/spec files (239 grandfathered) - max-lines: 800 lines over src/**, excluding tests, src/data, and generated schema.d.ts (20 grandfathered) - local/no-complex-jsx-arrow: new local rule flagging inline JSX arrow handlers with block bodies over two statements; each failure is a small extract-to-named -handler refactor (65 grandfathered) - prefer-const: flipped from off to error (103 grandfathered) - no-restricted-imports: added antd to the phase-out ban alongside tremor, and pointed both messages at shadcn/ui primitives (405 antd import sites grandfathered) Both new local rules ship with RuleTester coverage * fix(ui): preserve secondary extensions in filename-pascal-case suggestion The suggestion text built the rename from only the head segment, so a multi-dot file like my-component.utils.tsx was told to become MyComponent.tsx instead of MyComponent.utils.tsx. Rebuild it from the PascalCased head plus the untouched remaining segments, and add tests covering multi-dot filenames and the hyphenated Next.js reserved names (global-error, apple-icon, opengraph-image, twitter-image)	2026-07-22 19:34:35 -07:00
ryan-crabbe-berri	5973d9fd2b	feat(ui): add eslint rules for nested ternaries, large inline object args, and long condition chains (#32415) ... * feat(ui): add eslint rules for nested ternaries, large inline object args, and long condition chains Adds three dashboard lint rules to keep new code readable. Nested ternaries are banned outright via the built-in no-nested-ternary, with the 265 existing occurrences grandfathered in eslint-suppressions.json so only new ones fail. Two custom rules ship as a small local plugin under scripts/eslint-rules: no-large-inline-object-arg flags object literals with 4+ properties passed straight into a call, nudging toward a named variable, and no-long-condition-chain flags boolean expressions that combine 4+ conditions, nudging toward a named boolean. Both are warnings tracked on the existing budget ratchet (eslint-budgets.json + eslint-metrics.json) with headroom above the current counts, so they ratchet down over time rather than freezing a baseline. Both thresholds are configurable rule options and covered by RuleTester unit tests. * fix(ui): scope no-long-condition-chain to boolean operators, not nullish Greptile flagged that the rule counted nullish-coalescing chains the same as &&/|| chains, so a 4-part `a ?? b ?? c ?? d` fallback surfaced "Boolean expression combines 4 conditions", which is inaccurate since a `??` fallback is value defaulting, not a condition. Restrict the visitor to && / || nodes so `??` chains are treated as leaves, while a boolean chain nested inside a `??` is still caught. Drops 6 miscounted occurrences (240 -> 234). * chore(ui): sync lint metrics and suppressions with staging Merge advanced the base branch, adding one no-large-inline-object-arg occurrence (508 -> 509) and making one grandfathered react-hooks suppression stale. Regenerate eslint-metrics.json and prune the suppression so the budget/drift gate passes. * chore(ui): sync lint metrics with staging Merge advanced the base, adding four no-large-inline-object-arg occurrences (509 -> 513). Regenerate eslint-metrics.json so the drift gate passes.	2026-07-08 21:32:16 +00:00