mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-21 00:21:49 +00:00
Address Greptile review feedback on migration startup
- Fix bare `raise` → `raise e` in unreachable else branch of _resolve_failed_migration for correctness and clarity - Remove _mark_all_migrations_applied from P3005 path — it was marking ALL migrations (including new ones) as applied, causing new migration SQL to never run. Now baseline creation is followed directly by _deploy_with_idempotent_resolution which actually runs pending migrations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
parent
be4ba42647
commit
fdd8a706ba
1 changed files with 3 additions and 9 deletions
|
|
@ -339,7 +339,7 @@ class ProxyExtrasDBManager:
|
|||
) from e
|
||||
migration_name = migration_match.group(1)
|
||||
else:
|
||||
raise # Not a P3009/P3018 — let outer handler deal with it
|
||||
raise e # Not a P3009/P3018 — let outer handler deal with it
|
||||
|
||||
# Check if idempotent — if not, fail fast
|
||||
if not ProxyExtrasDBManager._is_idempotent_error(stderr):
|
||||
|
|
@ -450,14 +450,8 @@ class ProxyExtrasDBManager:
|
|||
)
|
||||
ProxyExtrasDBManager._create_baseline_migration(schema_path)
|
||||
logger.info(
|
||||
"Baseline migration created, marking all existing migrations as applied"
|
||||
)
|
||||
ProxyExtrasDBManager._mark_all_migrations_applied(
|
||||
migrations_dir
|
||||
)
|
||||
# Now run deploy with resolution for any pending migrations
|
||||
logger.info(
|
||||
"Running prisma migrate deploy for any pending migrations..."
|
||||
"Baseline migration created, running deploy with idempotent resolution "
|
||||
"to apply remaining migrations..."
|
||||
)
|
||||
ProxyExtrasDBManager._deploy_with_idempotent_resolution()
|
||||
logger.info("✅ All migrations applied.")
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue