scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-26 06:03:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 35

style: single-assignment candidate resolution in bare-name dispatch (LIT010)

Browse source 
Generated-by: termag
This commit is contained in:
Jack Danger 2026-10-18 09:23:36 +00:00
parent 4850de6bfa
commit fc456d4ff9
1 changed files with 13 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
litellm/proxy/_experimental/mcp_server/mcp_server_manager.py
View file

@ -7134,14 +7134,15 @@ class MCPServerManager:
if tool_name in self.tool_name_to_mcp_server_name_mapping:
server_name: Final = self.tool_name_to_mcp_server_name_mapping[tool_name]
normalised_lookup: Final = normalize_server_name(server_name)
candidate: MCPServer | None = None
if normalised_lookup in prefix_to_server:
candidate = prefix_to_server[normalised_lookup]
else:
for server in registry_servers:
if normalize_server_name(server.name) == normalised_lookup:
candidate = server
break
registry_prefix_hit: Final = prefix_to_server.get(normalised_lookup)
registry_candidate: Final = (
registry_prefix_hit
if registry_prefix_hit is not None
else next(
(server for server in registry_servers if normalize_server_name(server.name) == normalised_lookup),
None,
)
)
# The bare-name mapping is keyed off each server's own tool
# names, so any server may claim an arbitrary bare-name key. A
# name that carries a prefix-qualified wire form of a *different*
@ -7149,16 +7150,14 @@ class MCPServerManager:
# branch: an attacker server advertising e.g. "github-delete_repo"
# otherwise shadows the prefix-qualified github tool (and bypasses
# its per-tool ACL) (R2-23).
if candidate is not None:
if registry_candidate is not None:
foreign_prefixes: Final = tuple(
known_prefix
for known_prefix, mapped_server in prefix_to_server.items()
if mapped_server is not candidate
if mapped_server is not registry_candidate
)
if match_known_server_prefix(tool_name, foreign_prefixes) is not None:
candidate = None
if candidate is not None:
return candidate
if match_known_server_prefix(tool_name, foreign_prefixes) is None:
return registry_candidate
# If not found and tool name is prefixed, extract the prefix and
# match against any known form.