test(otel): cover tool-call parts and streamed finish-reason aggregation

Regression tests for #45796: - `_transform_messages_to_otel_semantic_conventions` emits GenAI `{"type": "tool_call", id/name/arguments}` parts for both dict and pydantic messages (previously dropped for non-dict objects and never emitted as parts at all). - `ChunkProcessor.build_base_response` aggregates a stream whose chunks carried tool-call deltas but no explicit finish_reason to "tool_calls" instead of the default "stop". Signed-off-by: apex-mochen <2756823972@qq.com>
2026-10-24 05:45:11 +00:00 · 2026-10-11 11:53:50 +08:00 · 2026-10-11 11:53:50 +08:00 · f8de7a7312
commit f8de7a7312
parent 0440a334f4
1 changed files with 93 additions and 0 deletions
--- a/tests/unit/integrations/test_otel_tool_call_parts.py
+++ b/tests/unit/integrations/test_otel_tool_call_parts.py
@ -0,0 +1,93 @@
+# -*- coding: utf-8 -*-
+"""Regression tests for #45796: OTEL tool-call parts + streamed finish reason.
+
+Covered behavior:
+- ``_transform_messages_to_otel_semantic_conventions`` emits GenAI
+  ``{"type": "tool_call", "id", "name", "arguments"}`` parts for assistant
+  messages carrying ``tool_calls`` — for plain dicts and for Pydantic
+  message objects (which used to be skipped because ``"tool_calls" in msg``
+  is False for non-dict objects).
+- Plain string ``content`` still emits a text part (no regression).
+- ``ChunkProcessor.build_base_response`` aggregates a stream whose chunks
+  carried tool-call deltas but no explicit ``finish_reason`` to
+  ``"tool_calls"`` instead of the default ``"stop"``.
+"""
+from pydantic import BaseModel
+
+from litellm.integrations.opentelemetry import OpenTelemetry
+from litellm.litellm_core_utils.streaming_chunk_builder_utils import ChunkProcessor
+
+
+class _FakeAssistantMessage(BaseModel):
+    role: str = "assistant"
+    content: str | None = None
+    tool_calls: list | None = None
+
+
+class TestOtelToolCallParts:
+    def test_dict_message_with_tool_calls_emits_genai_tool_call_parts(self):
+        msg = {
+            "role": "assistant",
+            "content": None,
+            "tool_calls": [
+                {
+                    "id": "call_1",
+                    "type": "function",
+                    "function": {"name": "get_weather", "arguments": '{"city": "SF"}'},
+                }
+            ],
+        }
+        out = OpenTelemetry()._transform_messages_to_otel_semantic_conventions([msg])[0]
+        assert out["parts"] == [
+            {"type": "tool_call", "id": "call_1", "name": "get_weather", "arguments": '{"city": "SF"}'}
+        ]
+        assert "tool_calls" not in out
+
+    def test_pydantic_message_with_tool_calls_emits_genai_tool_call_parts(self):
+        msg = _FakeAssistantMessage(
+            tool_calls=[
+                {
+                    "id": "call_2",
+                    "type": "function",
+                    "function": {"name": "lookup", "arguments": "{}"},
+                }
+            ]
+        )
+        out = OpenTelemetry()._transform_messages_to_otel_semantic_conventions([msg])[0]
+        assert out["parts"] == [
+            {"type": "tool_call", "id": "call_2", "name": "lookup", "arguments": "{}"}
+        ]
+
+    def test_string_content_still_emits_text_part(self):
+        out = OpenTelemetry()._transform_messages_to_otel_semantic_conventions(
+            [{"role": "assistant", "content": "hello"}]
+        )[0]
+        assert out["parts"] == [{"type": "text", "content": "hello"}]
+
+    def test_streamed_tool_call_without_explicit_finish_reason_aggregates_to_tool_calls(self):
+        chunks = [
+            {
+                "object": "chat.completion.chunk",
+                "created": 0,
+                "model": "mock",
+                "choices": [{"index": 0, "delta": {"role": "assistant", "content": None}}],
+            },
+            {
+                "choices": [
+                    {
+                        "index": 0,
+                        "delta": {
+                            "tool_calls": [
+                                {
+                                    "id": "c1",
+                                    "type": "function",
+                                    "function": {"name": "f", "arguments": "{}"},
+                                }
+                            ]
+                        },
+                    }
+                ]
+            },
+        ]
+        resp = ChunkProcessor(chunks).build_base_response(chunks)
+        assert resp.choices[0].finish_reason == "tool_calls"