scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-03 02:22:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 80

fix(agent_endpoints): call assert_caller_can_mutate on every write endpoint

Browse source 
Block PROXY_ADMIN_VIEW_ONLY from create_agent / update_agent /
delete_agent. Reads (GET) still pass through is_proxy_admin_read
so view-only admins keep cross-tenant visibility for the support UI.

Greptile P1 SECURITY follow-up (view-only admin write bypass).
This commit is contained in:
Ishaan Jaffer 2026-05-06 15:37:12 -07:00
parent 303f9a5d80
commit f893105116
No known key found for this signature in database
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
litellm/proxy/agent_session_endpoints/agent_endpoints.py
View file

@ -23,6 +23,7 @@ from litellm._logging import verbose_proxy_logger
from litellm.proxy._types import UserAPIKeyAuth
from litellm.proxy.agent_session_endpoints.ids import new_agent_id
from litellm.proxy.agent_session_endpoints.ownership import (
assert_caller_can_mutate,
assert_caller_owns_agent,
caller_api_key_hash,
owner_filter_for_caller,
@ -106,6 +107,7 @@ async def create_agent(
body: AgentCreate,
user_api_key_dict: UserAPIKeyAuth = Depends(user_api_key_auth),
):
assert_caller_can_mutate(user_api_key_dict)
prisma_client = await _get_prisma_client_or_503()
payload = _agent_create_payload(body, user_api_key_dict)
row = await prisma_client.db.litellm_agent.create(data=payload)
@ -144,6 +146,7 @@ async def update_agent(
body: AgentUpdate,
user_api_key_dict: UserAPIKeyAuth = Depends(user_api_key_auth),
):
assert_caller_can_mutate(user_api_key_dict)
prisma_client = await _get_prisma_client_or_503()
existing = await prisma_client.db.litellm_agent.find_unique(where={"id": agent_id})
assert_caller_owns_agent(user_api_key_dict, existing)
@ -189,6 +192,7 @@ async def delete_agent(
agent_id: str,
user_api_key_dict: UserAPIKeyAuth = Depends(user_api_key_auth),
):
assert_caller_can_mutate(user_api_key_dict)
prisma_client = await _get_prisma_client_or_503()
existing = await prisma_client.db.litellm_agent.find_unique(where={"id": agent_id})
assert_caller_owns_agent(user_api_key_dict, existing)