scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-09 03:18:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 109

address greptile review feedback (greploop iteration 33)

Browse source
This commit is contained in:
Ishaan Jaffer 2026-03-06 11:00:01 -08:00
parent 06f12e0ddf
commit f85229a393
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tests/test_litellm/proxy/management_endpoints/test_ui_sso.py
View file

@ -3791,16 +3791,16 @@ class TestPKCEFunctionality:
mock_request = MagicMock(spec=Request)
mock_request.query_params = {"state": "missing_state_non_strict"}
# PKCE_STRICT_CACHE_MISS not set (default false) — should NOT raise
# PKCE_STRICT_CACHE_MISS explicitly set to false — should NOT raise.
# Use patch.dict with the key set to "false" rather than os.environ.pop()
# to avoid permanently mutating the test process environment.
with patch("litellm.proxy.proxy_server.redis_usage_cache", None), patch(
"litellm.proxy.proxy_server.user_api_key_cache", mock_cache
), patch.dict(
os.environ,
{"GENERIC_CLIENT_USE_PKCE": "true"},
{"GENERIC_CLIENT_USE_PKCE": "true", "PKCE_STRICT_CACHE_MISS": "false"},
clear=False,
):
# Remove PKCE_STRICT_CACHE_MISS if set in environment
os.environ.pop("PKCE_STRICT_CACHE_MISS", None)
result = await SSOAuthenticationHandler.prepare_token_exchange_parameters(
request=mock_request, generic_include_client_id=False
)
@ -3863,15 +3863,16 @@ class TestPKCEFunctionality:
mock_request = MagicMock(spec=Request)
mock_request.query_params = {"state": "bad_format_non_strict"}
# Non-strict mode: should log a warning and continue, not raise
# Non-strict mode: should log a warning and continue, not raise.
# Use patch.dict with PKCE_STRICT_CACHE_MISS="false" to avoid permanently
# mutating the test process environment with os.environ.pop().
with patch("litellm.proxy.proxy_server.redis_usage_cache", None), patch(
"litellm.proxy.proxy_server.user_api_key_cache", mock_cache
), patch.dict(
os.environ,
{"GENERIC_CLIENT_USE_PKCE": "true"},
{"GENERIC_CLIENT_USE_PKCE": "true", "PKCE_STRICT_CACHE_MISS": "false"},
clear=False,
):
os.environ.pop("PKCE_STRICT_CACHE_MISS", None)
result = await SSOAuthenticationHandler.prepare_token_exchange_parameters(
request=mock_request, generic_include_client_id=False
)