From f2d430643301a23bb56cfe880de49fcb57881f74 Mon Sep 17 00:00:00 2001 From: JingHao-Leon <102573344+JingHao-Leon@users.noreply.github.com> Date: Sun, 11 Oct 2026 19:12:15 +0800 Subject: [PATCH] type_check_gate: keep the response_format check at its baseline count The guard read `value.get("type")` inline, where `value` arrives as `object` and `isinstance(value, Mapping)` narrows it to a bare `Mapping`, so `get()` came back partially unknown and put the file one `reportUnknownMemberType` over its merge-base ceiling. Extracting it into `_is_supported_response_format` puts the narrowing on one `object`-typed local, so the single unavoidable suppression sits there instead of on the branch. Checked against the original expression over a json_schema with a schema, text, an empty dict, json_object, a bogus type, a string, and None, and the results match in every case --- litellm/llms/gigachat/chat/transformation.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/litellm/llms/gigachat/chat/transformation.py b/litellm/llms/gigachat/chat/transformation.py index f3e4b8b22cf..6f80b890b0c 100644 --- a/litellm/llms/gigachat/chat/transformation.py +++ b/litellm/llms/gigachat/chat/transformation.py @@ -52,6 +52,13 @@ class GigaChatError(BaseLLMException): """GigaChat API error.""" +def _is_supported_response_format(value: object) -> bool: + if not isinstance(value, Mapping): + return False + response_format_type: Final = value.get("type") # pyright: ignore[reportUnknownMemberType] # bare Mapping + return response_format_type in (None, "text", "json_schema") + + class GigaChatConfig(BaseConfig): """ Configuration class for GigaChat API. @@ -209,7 +216,7 @@ class GigaChatConfig(BaseConfig): ] optional_params["function_call"] = {"name": schema_name} optional_params["_structured_output"] = True - elif not (isinstance(value, Mapping) and (value.get("type") in (None, "text", "json_schema"))): + elif not _is_supported_response_format(value): from litellm.utils import UnsupportedParamsError if litellm.drop_params is not True and drop_params is not True: