From f1b567f1bc69209971af21159bdb7baba0ebcd93 Mon Sep 17 00:00:00 2001
From: ryan-crabbe-berri <ryan@berri.ai>
Date: Tue, 21 Jul 2026 18:16:01 -0700
Subject: [PATCH] test(e2e): catch key-delete and credential-edit specs up with
 dropdown UI

The key info header moved Delete Key into the More key actions menu
(#34116) and the credentials table moved row actions into a dropdown with
data-testids (shared DataTable migration), so both specs timed out
looking for buttons that no longer exist. Reproduced against a proxy
serving a fresh dashboard build; both pass after pointing them at the
menus.
---
 tests/e2e/ui/tests/modelsPage/credentials.spec.ts | 3 ++-
 tests/e2e/ui/tests/proxy-admin/keys.spec.ts       | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/e2e/ui/tests/modelsPage/credentials.spec.ts b/tests/e2e/ui/tests/modelsPage/credentials.spec.ts
index 8b7824813a4..7c836068567 100644
--- a/tests/e2e/ui/tests/modelsPage/credentials.spec.ts
+++ b/tests/e2e/ui/tests/modelsPage/credentials.spec.ts
@@ -38,7 +38,8 @@ test.describe("Edit LLM credential", () => {
 
     const row = page.locator("tr", { hasText: credentialName });
     await expect(row).toBeVisible({ timeout: 15_000 });
-    await row.getByRole("button").first().click();
+    await row.getByTestId(`credential-actions-${credentialName}`).click();
+    await page.getByTestId("credential-action-edit").click();
 
     const modal = page.locator(".ant-modal-content").filter({ hasText: "Edit Credential" });
     await expect(modal).toBeVisible({ timeout: 10_000 });
diff --git a/tests/e2e/ui/tests/proxy-admin/keys.spec.ts b/tests/e2e/ui/tests/proxy-admin/keys.spec.ts
index a55c19a53de..c44957ea737 100644
--- a/tests/e2e/ui/tests/proxy-admin/keys.spec.ts
+++ b/tests/e2e/ui/tests/proxy-admin/keys.spec.ts
@@ -103,7 +103,8 @@ test.describe("Proxy Admin - Keys", () => {
 
     await expect(page.getByText("Back to Keys")).toBeVisible({ timeout: 10_000 });
 
-    await page.getByRole("button", { name: "Delete Key" }).click();
+    await page.getByRole("button", { name: "More key actions" }).click();
+    await page.getByRole("menuitem", { name: "Delete Key" }).click();
 
     const modal = page.locator(".ant-modal:visible");
     await expect(modal).toBeVisible({ timeout: 5_000 });