From f0efc5f670851264b400caaee48ecd503852ed38 Mon Sep 17 00:00:00 2001 From: Krrish Dholakia Date: Mon, 20 Apr 2026 07:43:53 -0700 Subject: [PATCH] test: cover _finalize_adaptive_router_if_configured Router coverage check flagged this method as untested. Adds two cases: - initializes AdaptiveRouter from model_list and is idempotent on re-entry - no-op when no adaptive deployments are configured Co-Authored-By: Claude Opus 4.7 (1M context) --- .../adaptive_router/test_router_dispatch.py | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/tests/test_litellm/router_strategy/adaptive_router/test_router_dispatch.py b/tests/test_litellm/router_strategy/adaptive_router/test_router_dispatch.py index 7a67dac1a81..73cb66616ef 100644 --- a/tests/test_litellm/router_strategy/adaptive_router/test_router_dispatch.py +++ b/tests/test_litellm/router_strategy/adaptive_router/test_router_dispatch.py @@ -378,3 +378,56 @@ def test_init_adaptive_router_rejects_duplicate_model_name(): r.init_adaptive_router_deployment(deployment=deployment) with pytest.raises(ValueError, match="already exists"): r.init_adaptive_router_deployment(deployment=deployment) + + +def test_finalize_adaptive_router_if_configured_initializes_and_is_idempotent(): + """`_finalize_adaptive_router_if_configured` walks the model_list, builds an + AdaptiveRouter for each adaptive deployment, and is a safe no-op on + re-entry (models already in self.adaptive_routers are skipped).""" + r = Router( + model_list=[ + { + "model_name": "fast", + "litellm_params": {"model": "openai/gpt-4o-mini"}, + "model_info": {"input_cost_per_token": 0.00000015}, + }, + { + "model_name": "smart", + "litellm_params": {"model": "openai/gpt-4o"}, + "model_info": {"input_cost_per_token": 0.0000025}, + }, + { + "model_name": "my-router", + "litellm_params": { + "model": "auto_router/adaptive_router", + "adaptive_router_config": { + "available_models": ["fast", "smart"], + }, + }, + }, + ] + ) + + # Router __init__ already called _finalize_adaptive_router_if_configured. + assert "my-router" in r.adaptive_routers + original = r.adaptive_routers["my-router"] + + # Calling again must be idempotent: the existing AdaptiveRouter instance + # is preserved, not rebuilt. + r._finalize_adaptive_router_if_configured() + assert r.adaptive_routers["my-router"] is original + + +def test_finalize_adaptive_router_if_configured_noop_when_none_configured(): + """With no adaptive deployments in model_list, the finalizer leaves + `adaptive_routers` empty.""" + r = Router( + model_list=[ + { + "model_name": "fast", + "litellm_params": {"model": "openai/gpt-4o-mini"}, + } + ] + ) + r._finalize_adaptive_router_if_configured() + assert r.adaptive_routers == {}