scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-11-14 09:03:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 214

fix(proxy): release parked native success logs for every call type

Browse source 
The proxy defers non-stream success logging past post-call guardrails, and the native host parks its log on _native_pending_logging until the proxy releases it. The release only ran for OCR, so a unary /v1/messages call served by Rust logged no success event, no SpendLogs row and no key, team, user or end-user spend
This commit is contained in:
narmstrong-berri 2026-11-06 05:24:37 +00:00
parent 1d46ade6da
commit eeebcdcdbb
No known key found for this signature in database
2 changed files with 10 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
litellm/proxy/common_request_processing.py
View file

@ -4168,11 +4168,10 @@ class ProxyBaseLLMRequestProcessing:
Extracted as a static method so tests can exercise the production
gating logic directly rather than reimplementing the finally block.
"""
if getattr(logging_obj, "call_type", None) in ("ocr", "aocr"):
pending: Final = getattr(logging_obj, "_native_pending_logging", None)
if pending is not None:
logging_obj._native_pending_logging = None # rebind-ok: consume the native OCR release signal once
pending.release(not exception_raised)
pending: Final = getattr(logging_obj, "_native_pending_logging", None)
if pending is not None:
logging_obj._native_pending_logging = None # rebind-ok: consume the native release signal once
pending.release(not exception_raised)
_enqueue_fn: Final = getattr(logging_obj, "enqueue_deferred_logging", None)
if _enqueue_fn is None:
return

14
tests/unit/proxy/guardrails/test_deferred_guardrail_logging.py
View file

@ -416,9 +416,11 @@ async def test_deferred_anthropic_messages_bridged_to_the_responses_api_logs_the
# ---------------------------------------------------------------------------
@pytest.mark.parametrize("call_type", ["ocr", "aocr", "completion", "acompletion", "embedding", "responses"])
@pytest.mark.parametrize(
"call_type", ["ocr", "aocr", "anthropic_messages", "completion", "acompletion", "embedding", "responses"]
)
@pytest.mark.parametrize("exception_raised", [False, True])
def test_native_pending_logging_is_released_only_for_ocr(call_type: str, exception_raised: bool) -> None:
def test_native_pending_logging_is_released_once_for_every_call_type(call_type: str, exception_raised: bool) -> None:
pending: Final = MagicMock()
enqueue: Final = MagicMock()
logger: Final = MagicMock(
@ -436,12 +438,8 @@ def test_native_pending_logging_is_released_only_for_ocr(call_type: str, excepti
exception_raised=exception_raised,
)
if call_type in ("ocr", "aocr"):
pending.release.assert_called_once_with(not exception_raised)
assert logger._native_pending_logging is None
else:
pending.release.assert_not_called()
assert logger._native_pending_logging is pending
pending.release.assert_called_once_with(not exception_raised)
assert logger._native_pending_logging is None
if exception_raised:
enqueue.assert_not_called()
else: