fix(vector_stores): drop rewrite_query false from the chat file_search tool

False asks for the default search every store already runs, and MongoDB
rejects the field outright, so forwarding it made a MongoDB chat lose the
store's context for a no-op flag. True is still forwarded.
This commit is contained in:
mateo-berri 2026-11-11 14:33:48 -08:00
parent 37fe6920ae
commit ee74a39a77
2 changed files with 2 additions and 2 deletions

View file

@ -362,7 +362,7 @@ class VectorStoreToolParams:
"filters": self.filters, "filters": self.filters,
"max_num_results": self.max_num_results, "max_num_results": self.max_num_results,
"ranking_options": self.ranking_options, "ranking_options": self.ranking_options,
"rewrite_query": self.rewrite_query, "rewrite_query": self.rewrite_query or None,
}.items() }.items()
if v is not None if v is not None
} }

View file

@ -502,7 +502,7 @@ def test_vector_store_ids_to_run_reads_every_store_id_a_malformed_vector_store_i
[ [
("query_image", {"type": "base64", "media_type": "image/jpeg", "data": "/9j/"}, {"max_num_results": 3}), ("query_image", {"type": "base64", "media_type": "image/jpeg", "data": "/9j/"}, {"max_num_results": 3}),
("rewrite_query", True, {"max_num_results": 3, "rewrite_query": True}), ("rewrite_query", True, {"max_num_results": 3, "rewrite_query": True}),
("rewrite_query", False, {"max_num_results": 3, "rewrite_query": False}), ("rewrite_query", False, {"max_num_results": 3}),
], ],
) )
def test_file_search_tool_passes_its_store_only_the_fields_a_store_search_takes( def test_file_search_tool_passes_its_store_only_the_fields_a_store_search_takes(