diff --git a/tests/e2e/logging/logging_client.py b/tests/e2e/logging/logging_client.py index 3aff01a176d..9ec62a175c2 100644 --- a/tests/e2e/logging/logging_client.py +++ b/tests/e2e/logging/logging_client.py @@ -522,7 +522,7 @@ class LoggingClient: ) def config_callback_names(self) -> set[str]: - """Every name GET /get/config/callbacks lists as an active callback.""" + """Names GET /get/config/callbacks lists as configured (runtime-only read_only rows excluded).""" return { entry.name for entry in unwrap( @@ -533,6 +533,7 @@ class LoggingClient: response_type=ConfigCallbacksResponse, ) ).callbacks + if not entry.read_only } def delete_config_callback(self, callback_name: str) -> Result[CallbackDeleteResponse]: diff --git a/tests/e2e/logging/test_callback_delete_e2e.py b/tests/e2e/logging/test_callback_delete_e2e.py index 71d3243b8c2..b704a6ce807 100644 --- a/tests/e2e/logging/test_callback_delete_e2e.py +++ b/tests/e2e/logging/test_callback_delete_e2e.py @@ -1,14 +1,4 @@ -"""Live e2e: a callback the Admin UI lists must also be deletable. - -GET /get/config/callbacks enumerates litellm_settings.success_callback, -failure_callback and callbacks, plus runtime-only loggers, but -POST /config/callback/delete only looks inside success_callback. A callback -configured under `callbacks` or `failure_callback` is listed as active on the -Logging & Alerts -> Logging Callbacks page yet its delete answers 404 "Callback -not found in active configuration". The success_callback case is the control: -it proves the add/list/delete round trip works when the configured key is the -one the delete route actually reads. -""" +"""A callback listed by GET /get/config/callbacks must be deletable with POST /config/callback/delete.""" from collections.abc import Callable @@ -20,7 +10,7 @@ from models import LitellmCallbackSettings pytestmark = pytest.mark.e2e -CALLBACK_NAME = "datadog" +CALLBACK_NAME = "langsmith" def _assert_listed_then_deleted(