From ed1993d0167c25eec3f3024edfc39ed1e418da72 Mon Sep 17 00:00:00 2001
From: Ishaan Jaffer <ishaanjaffer0324@gmail.com>
Date: Wed, 11 Mar 2026 21:05:26 -0700
Subject: [PATCH] fix(mcp): fix allowedTools undefined semantics; remove unused
 import and color field

---
 .../src/components/mcp_tools/McpCrudPermissionPanel.tsx    | 1 -
 .../src/components/mcp_tools/mcp_tool_configuration.tsx    | 2 +-
 .../src/utils/mcpToolCrudClassification.ts                 | 7 +------
 3 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/ui/litellm-dashboard/src/components/mcp_tools/McpCrudPermissionPanel.tsx b/ui/litellm-dashboard/src/components/mcp_tools/McpCrudPermissionPanel.tsx
index 4ad46918797..248385fe002 100644
--- a/ui/litellm-dashboard/src/components/mcp_tools/McpCrudPermissionPanel.tsx
+++ b/ui/litellm-dashboard/src/components/mcp_tools/McpCrudPermissionPanel.tsx
@@ -17,7 +17,6 @@ import {
   CrudOp,
   MCPToolEntry,
   CRUD_GROUP_META,
-  classifyToolOp,
   groupToolsByCrud,
 } from "../../utils/mcpToolCrudClassification";
 
diff --git a/ui/litellm-dashboard/src/components/mcp_tools/mcp_tool_configuration.tsx b/ui/litellm-dashboard/src/components/mcp_tools/mcp_tool_configuration.tsx
index 31f6cff326c..af6890a6d83 100644
--- a/ui/litellm-dashboard/src/components/mcp_tools/mcp_tool_configuration.tsx
+++ b/ui/litellm-dashboard/src/components/mcp_tools/mcp_tool_configuration.tsx
@@ -467,7 +467,7 @@ const MCPToolConfiguration: React.FC<MCPToolConfigurationProps> = ({
               <McpCrudPermissionPanel
                 tools={tools}
                 searchFilter={toolSearchTerm}
-                value={allowedTools ?? undefined}
+                value={allowedTools.length === 0 ? undefined : allowedTools}
                 onChange={(allowed) => onAllowedToolsChange(allowed)}
               />
             )}
diff --git a/ui/litellm-dashboard/src/utils/mcpToolCrudClassification.ts b/ui/litellm-dashboard/src/utils/mcpToolCrudClassification.ts
index e2cd53761fe..523995cce46 100644
--- a/ui/litellm-dashboard/src/utils/mcpToolCrudClassification.ts
+++ b/ui/litellm-dashboard/src/utils/mcpToolCrudClassification.ts
@@ -56,36 +56,31 @@ export function groupToolsByCrud(tools: MCPToolEntry[]): Record<CrudOp, MCPToolE
 
 export const CRUD_GROUP_META: Record<
   CrudOp,
-  { label: string; description: string; risk: "low" | "medium" | "high" | "unknown"; color: string }
+  { label: string; description: string; risk: "low" | "medium" | "high" | "unknown" }
 > = {
   read: {
     label: "Read",
     description: "Safe operations — fetch, list, search. No side effects.",
     risk: "low",
-    color: "green",
   },
   create: {
     label: "Create",
     description: "Add new resources — insert, upload, register.",
     risk: "medium",
-    color: "blue",
   },
   update: {
     label: "Update",
     description: "Modify existing resources — edit, patch, rename.",
     risk: "medium",
-    color: "yellow",
   },
   delete: {
     label: "Delete",
     description: "Destructive operations — remove, purge, destroy.",
     risk: "high",
-    color: "red",
   },
   unknown: {
     label: "Other",
     description: "Operations that could not be automatically classified.",
     risk: "unknown",
-    color: "gray",
   },
 };