diff --git a/helm/litellm-helm/tests/migrations-job_tests.yaml b/helm/litellm-helm/tests/migrations-job_tests.yaml index 1fe545636d4..dd4276ac60f 100644 --- a/helm/litellm-helm/tests/migrations-job_tests.yaml +++ b/helm/litellm-helm/tests/migrations-job_tests.yaml @@ -112,6 +112,24 @@ tests: name: CUSTOM_VAR value: "custom_value" + - it: should override a user-supplied DISABLE_SCHEMA_UPDATE so the Job always migrates + template: migrations-job.yaml + set: + envVars: + DISABLE_SCHEMA_UPDATE: "true" + migrationJob: + enabled: true + asserts: + # The Job is what owns the schema, so it renders its own + # DISABLE_SCHEMA_UPDATE=false after envVars and extraEnvVars. Kubernetes + # takes the last value for a duplicated name, so the user's "true" cannot + # leave the schema unmigrated. Skipping migrations is migrationJob.enabled. + - equal: + path: spec.template.spec.containers[0].env[-1] + value: + name: DISABLE_SCHEMA_UPDATE + value: "false" + - it: should not include DATABASE_URL when deployStandalone is false template: migrations-job.yaml set: diff --git a/helm/litellm-helm/values.yaml b/helm/litellm-helm/values.yaml index fcee331a5aa..03d2a66a2b5 100644 --- a/helm/litellm-helm/values.yaml +++ b/helm/litellm-helm/values.yaml @@ -545,7 +545,6 @@ redis: # Prisma migration job settings migrationJob: enabled: true # Enable or disable the schema migration Job - retries: 3 # Number of retries for the Job in case of failure backoffLimit: 4 # Backoff limit for Job restarts # Wall-clock budget for the whole Job, shared across every `backoffLimit` # retry rather than granted per attempt. Without it a migration that blocks @@ -554,7 +553,6 @@ migrationJob: # stop reconciling the whole chart until someone deletes the Job by hand. # Set to null to opt out and restore the unbounded behaviour. activeDeadlineSeconds: 1800 - disableSchemaUpdate: false # Skip schema migrations for specific environments. When True, the job will exit with code 0. # Optional service account for the migration job. # Only used when migrationJob.hooks.helm.enabled=true and serviceAccount.create=true. # In that case, pre-install/pre-upgrade hooks run before normal resources, so this defaults to "default".