From e57250f5f87cb42917ba818bb9c9765f960f5330 Mon Sep 17 00:00:00 2001 From: yassin Date: Tue, 25 Aug 2026 20:13:13 +0000 Subject: [PATCH] test: suppress TQ008 on new CLI session tests that stub proxy_server globals Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- .../proxy/auth/test_user_api_key_auth.py | 6 ++-- .../test_cli_session_endpoints.py | 4 +-- .../proxy/management_endpoints/test_ui_sso.py | 32 +++++++++---------- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/tests/test_litellm/proxy/auth/test_user_api_key_auth.py b/tests/test_litellm/proxy/auth/test_user_api_key_auth.py index ce662621345..2f10c366973 100644 --- a/tests/test_litellm/proxy/auth/test_user_api_key_auth.py +++ b/tests/test_litellm/proxy/auth/test_user_api_key_auth.py @@ -6780,9 +6780,9 @@ async def _auth_with_cli_token(cli_token: str, cache: DualCache): mock_request.query_params = {} with ( - patch("litellm.proxy.proxy_server.master_key", "sk-master"), - patch("litellm.proxy.proxy_server.prisma_client", MagicMock()), - patch("litellm.proxy.proxy_server.user_api_key_cache", cache), + patch("litellm.proxy.proxy_server.master_key", "sk-master"), # test-quality-ok: auth reads proxy_server module globals, no injection seam + patch("litellm.proxy.proxy_server.prisma_client", MagicMock()), # test-quality-ok: auth reads proxy_server module globals, no injection seam + patch("litellm.proxy.proxy_server.user_api_key_cache", cache), # test-quality-ok: auth reads proxy_server module globals, no injection seam ): return await user_api_key_auth(request=mock_request, api_key=f"Bearer {cli_token}") diff --git a/tests/test_litellm/proxy/management_endpoints/test_cli_session_endpoints.py b/tests/test_litellm/proxy/management_endpoints/test_cli_session_endpoints.py index 9e972abd2bf..929819b4ded 100644 --- a/tests/test_litellm/proxy/management_endpoints/test_cli_session_endpoints.py +++ b/tests/test_litellm/proxy/management_endpoints/test_cli_session_endpoints.py @@ -36,8 +36,8 @@ def _caller(role: LitellmUserRoles, user_id: str = "admin-1") -> UserAPIKeyAuth: def _proxy(table: FakeCLISessionTable): return ( - patch("litellm.proxy.proxy_server.prisma_client", FakePrismaClient(table)), - patch("litellm.proxy.proxy_server.user_api_key_cache", DualCache()), + patch("litellm.proxy.proxy_server.prisma_client", FakePrismaClient(table)), # test-quality-ok: auth reads proxy_server module globals, no injection seam + patch("litellm.proxy.proxy_server.user_api_key_cache", DualCache()), # test-quality-ok: auth reads proxy_server module globals, no injection seam ) diff --git a/tests/test_litellm/proxy/management_endpoints/test_ui_sso.py b/tests/test_litellm/proxy/management_endpoints/test_ui_sso.py index 22f1c681fb4..c43895eba67 100644 --- a/tests/test_litellm/proxy/management_endpoints/test_ui_sso.py +++ b/tests/test_litellm/proxy/management_endpoints/test_ui_sso.py @@ -3524,7 +3524,7 @@ class TestCLIKeyRegenerationFlow: with ( patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), + patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), # test-quality-ok: auth reads proxy_server module globals, no injection seam patch( "litellm.proxy.auth.auth_checks.ExperimentalUIJWTToken.get_cli_jwt_auth_token", return_value=mock_jwt_token, @@ -3677,7 +3677,7 @@ class TestCLIKeyRegenerationFlow: with ( patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), + patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), # test-quality-ok: auth reads proxy_server module globals, no injection seam patch( "litellm.proxy.auth.auth_checks.ExperimentalUIJWTToken.get_cli_jwt_auth_token", return_value="minted-token", @@ -3742,7 +3742,7 @@ class TestCLIKeyRegenerationFlow: with ( patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), + patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), # test-quality-ok: auth reads proxy_server module globals, no injection seam patch( "litellm.proxy.auth.auth_checks.ExperimentalUIJWTToken.get_cli_jwt_auth_token", return_value="minted-token", @@ -3785,7 +3785,7 @@ class TestCLIKeyRegenerationFlow: with ( patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), + patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), # test-quality-ok: auth reads proxy_server module globals, no injection seam patch( "litellm.proxy.auth.auth_checks.ExperimentalUIJWTToken.get_cli_jwt_auth_token", return_value="minted-token", @@ -3839,7 +3839,7 @@ class TestCLIKeyRegenerationFlow: with ( patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), + patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), # test-quality-ok: auth reads proxy_server module globals, no injection seam patch( "litellm.proxy.auth.auth_checks.ExperimentalUIJWTToken.get_cli_jwt_auth_token", return_value=mock_jwt_token, @@ -3896,7 +3896,7 @@ class TestCLIKeyRegenerationFlow: with ( patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), + patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), # test-quality-ok: auth reads proxy_server module globals, no injection seam patch( "litellm.proxy.auth.auth_checks.ExperimentalUIJWTToken.get_cli_jwt_auth_token", return_value=mock_jwt_token, @@ -8126,7 +8126,7 @@ async def test_cli_poll_key_tolerates_missing_user_row(): with ( patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), + patch("litellm.proxy.proxy_server.prisma_client", _cli_session_registry_prisma()), # test-quality-ok: auth reads proxy_server module globals, no injection seam patch( "litellm.proxy.auth.auth_checks.ExperimentalUIJWTToken.get_cli_jwt_auth_token", return_value=mock_jwt_token, @@ -8690,9 +8690,9 @@ async def test_cli_poll_key_registers_the_session_it_mints(monkeypatch): prisma = _cli_session_registry_prisma() with ( - patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), - patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", prisma), + patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), # test-quality-ok: auth reads proxy_server module globals, no injection seam + patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), # test-quality-ok: auth reads proxy_server module globals, no injection seam + patch("litellm.proxy.proxy_server.prisma_client", prisma), # test-quality-ok: auth reads proxy_server module globals, no injection seam ): result = await cli_poll_key( key_id="cli-registered-session", @@ -8730,9 +8730,9 @@ async def test_cli_poll_key_withholds_the_credential_when_registration_fails(mon prisma.db.litellm_clisessiontable.create = AsyncMock(side_effect=Exception("registry write failed")) with ( - patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), - patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", prisma), + patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), # test-quality-ok: auth reads proxy_server module globals, no injection seam + patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), # test-quality-ok: auth reads proxy_server module globals, no injection seam + patch("litellm.proxy.proxy_server.prisma_client", prisma), # test-quality-ok: auth reads proxy_server module globals, no injection seam ): with pytest.raises(HTTPException) as exc_info: await cli_poll_key( @@ -8762,9 +8762,9 @@ async def test_cli_poll_key_registers_a_distinct_session_per_login(monkeypatch): prisma = _cli_session_registry_prisma() with ( - patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), - patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), - patch("litellm.proxy.proxy_server.prisma_client", prisma), + patch("litellm.proxy.proxy_server.user_api_key_cache", mock_cache), # test-quality-ok: auth reads proxy_server module globals, no injection seam + patch("litellm.proxy.proxy_server.cli_sso_session_cache", mock_cache), # test-quality-ok: auth reads proxy_server module globals, no injection seam + patch("litellm.proxy.proxy_server.prisma_client", prisma), # test-quality-ok: auth reads proxy_server module globals, no injection seam ): for key_id in ("cli-login-session-alpha", "cli-login-session-bravo"): await cli_poll_key(key_id=key_id, team_id=None, x_litellm_cli_poll_secret="poll-secret")