fix: add logging for silent None fallback, deduplicate return block

Address Greptile review feedback:
- Log when upstream returns None (non-2xx) without exception
- Remove duplicated fallback return block by letting delegate-auth
  path fall through to the shared return statement

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
devin-ai-integration[bot] 2026-07-01 04:29:36 +00:00 committed by GitHub
parent 0e0dc9871d
commit e56ae4604b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1085,18 +1085,18 @@ async def _build_oauth_protected_resource_response(
"unavailable, falling back to gateway-served AS metadata",
mcp_server.name,
)
return {
"authorization_servers": [
(f"{request_base_url}/{mcp_server_name}" if mcp_server_name else f"{request_base_url}")
],
"resource": resource_url,
"scopes_supported": (mcp_server.scopes if mcp_server and mcp_server.scopes else []),
}
elif upstream_metadata is None:
verbose_logger.info(
"delegate-auth MCP server %r: upstream returned no resource "
"metadata (non-2xx or non-dict), falling back to gateway AS",
mcp_server.name,
)
authorization_servers = [
(f"{request_base_url}/{mcp_server_name}" if mcp_server_name else f"{request_base_url}")
]
return {
"authorization_servers": [
(f"{request_base_url}/{mcp_server_name}" if mcp_server_name else f"{request_base_url}")
],
"authorization_servers": authorization_servers,
"resource": resource_url,
"scopes_supported": (mcp_server.scopes if mcp_server and mcp_server.scopes else []),
}