From e27bd8226421b843d4fa98de66e3f9cb29441d24 Mon Sep 17 00:00:00 2001
From: Atharva Jaiswal <92455570+AtharvaJaiswal005@users.noreply.github.com>
Date: Sat, 28 Mar 2026 23:11:27 +0530
Subject: [PATCH] fix(test): remove redundant outer patch in cache invalidation
 test

The outer patch on the module-level attribute has no effect since
_reset_budget_for_enduser uses a lazy local import. Only the
sys.modules patch intercepts the import.
---
 .../common_utils/test_reset_budget_job.py     | 29 +++++++++----------
 1 file changed, 13 insertions(+), 16 deletions(-)

diff --git a/tests/test_litellm/proxy/common_utils/test_reset_budget_job.py b/tests/test_litellm/proxy/common_utils/test_reset_budget_job.py
index 49cf7333278..79c796e70a6 100644
--- a/tests/test_litellm/proxy/common_utils/test_reset_budget_job.py
+++ b/tests/test_litellm/proxy/common_utils/test_reset_budget_job.py
@@ -269,23 +269,20 @@ def test_reset_budget_for_enduser_invalidates_cache():
     mock_cache.async_delete_cache = AsyncMock()
 
     async def _run():
-        with patch(
-            "litellm.proxy.common_utils.reset_budget_job.user_api_key_cache",
-            mock_cache,
-            create=True,
+        # Patch sys.modules so the lazy import inside _reset_budget_for_enduser
+        # (`from litellm.proxy.proxy_server import user_api_key_cache`)
+        # picks up our mock cache.
+        with patch.dict(
+            "sys.modules",
+            {
+                "litellm.proxy.proxy_server": type(
+                    "module", (), {"user_api_key_cache": mock_cache}
+                )()
+            },
         ):
-            # Patch the import inside the function
-            with patch.dict(
-                "sys.modules",
-                {
-                    "litellm.proxy.proxy_server": type(
-                        "module", (), {"user_api_key_cache": mock_cache}
-                    )()
-                },
-            ):
-                result = await ResetBudgetJob._reset_budget_for_enduser(
-                    enduser=test_enduser
-                )
+            result = await ResetBudgetJob._reset_budget_for_enduser(
+                enduser=test_enduser
+            )
 
         assert result is not None
         assert result.spend == 0.0